diff --git a/src/com/android/settings/wifi/WifiConfigController.java b/src/com/android/settings/wifi/WifiConfigController.java index a8b32503049..626e4f36a82 100644 --- a/src/com/android/settings/wifi/WifiConfigController.java +++ b/src/com/android/settings/wifi/WifiConfigController.java @@ -304,11 +304,12 @@ public class WifiConfigController implements TextWatcher, } mPrivacySettingsSpinner.setSelection(prefMacValue); - if (config.getIpAssignment() == IpAssignment.STATIC) { + if (config.getIpConfiguration().getIpAssignment() == IpAssignment.STATIC) { mIpSettingsSpinner.setSelection(STATIC_IP); showAdvancedFields = true; // Display IP address. - StaticIpConfiguration staticConfig = config.getStaticIpConfiguration(); + StaticIpConfiguration staticConfig = config.getIpConfiguration() + .getStaticIpConfiguration(); if (staticConfig != null && staticConfig.ipAddress != null) { addRow(group, R.string.wifi_ip_address, staticConfig.ipAddress.getAddress().getHostAddress()); @@ -322,10 +323,11 @@ public class WifiConfigController implements TextWatcher, showAdvancedFields = true; } - if (config.getProxySettings() == ProxySettings.STATIC) { + ProxySettings proxySettings = config.getIpConfiguration().getProxySettings(); + if (proxySettings == ProxySettings.STATIC) { mProxySettingsSpinner.setSelection(PROXY_STATIC); showAdvancedFields = true; - } else if (config.getProxySettings() == ProxySettings.PAC) { + } else if (proxySettings == ProxySettings.PAC) { mProxySettingsSpinner.setSelection(PROXY_PAC); showAdvancedFields = true; } else { @@ -1332,7 +1334,8 @@ public class WifiConfigController implements TextWatcher, mDns2View.addTextChangedListener(this); } if (config != null) { - StaticIpConfiguration staticConfig = config.getStaticIpConfiguration(); + StaticIpConfiguration staticConfig = config.getIpConfiguration() + .getStaticIpConfiguration(); if (staticConfig != null) { if (staticConfig.ipAddress != null) { mIpAddressView.setText( diff --git a/src/com/android/settings/wifi/WifiConfigController2.java b/src/com/android/settings/wifi/WifiConfigController2.java index add37ddca29..26042f51124 100644 --- a/src/com/android/settings/wifi/WifiConfigController2.java +++ b/src/com/android/settings/wifi/WifiConfigController2.java @@ -304,11 +304,12 @@ public class WifiConfigController2 implements TextWatcher, } mPrivacySettingsSpinner.setSelection(prefMacValue); - if (config.getIpAssignment() == IpAssignment.STATIC) { + if (config.getIpConfiguration().getIpAssignment() == IpAssignment.STATIC) { mIpSettingsSpinner.setSelection(STATIC_IP); showAdvancedFields = true; // Display IP address. - StaticIpConfiguration staticConfig = config.getStaticIpConfiguration(); + StaticIpConfiguration staticConfig = config.getIpConfiguration() + .getStaticIpConfiguration(); if (staticConfig != null && staticConfig.ipAddress != null) { addRow(group, R.string.wifi_ip_address, staticConfig.ipAddress.getAddress().getHostAddress()); @@ -322,10 +323,11 @@ public class WifiConfigController2 implements TextWatcher, showAdvancedFields = true; } - if (config.getProxySettings() == ProxySettings.STATIC) { + ProxySettings proxySettings = config.getIpConfiguration().getProxySettings(); + if (proxySettings == ProxySettings.STATIC) { mProxySettingsSpinner.setSelection(PROXY_STATIC); showAdvancedFields = true; - } else if (config.getProxySettings() == ProxySettings.PAC) { + } else if (proxySettings == ProxySettings.PAC) { mProxySettingsSpinner.setSelection(PROXY_PAC); showAdvancedFields = true; } else { @@ -1328,7 +1330,8 @@ public class WifiConfigController2 implements TextWatcher, mDns2View.addTextChangedListener(this); } if (config != null) { - StaticIpConfiguration staticConfig = config.getStaticIpConfiguration(); + StaticIpConfiguration staticConfig = config.getIpConfiguration() + .getStaticIpConfiguration(); if (staticConfig != null) { if (staticConfig.ipAddress != null) { mIpAddressView.setText( diff --git a/tests/robotests/src/com/android/settings/wifi/WifiConfigController2Test.java b/tests/robotests/src/com/android/settings/wifi/WifiConfigController2Test.java index a79ffd8c1a9..e0dc97fd699 100644 --- a/tests/robotests/src/com/android/settings/wifi/WifiConfigController2Test.java +++ b/tests/robotests/src/com/android/settings/wifi/WifiConfigController2Test.java @@ -24,6 +24,7 @@ import static org.mockito.Mockito.when; import android.content.Context; import android.content.res.Resources; +import android.net.IpConfiguration; import android.net.wifi.WifiConfiguration; import android.net.wifi.WifiEnterpriseConfig; import android.net.wifi.WifiEnterpriseConfig.Eap; @@ -391,6 +392,7 @@ public class WifiConfigController2Test { private void checkSavedMacRandomizedValue(int macRandomizedValue) { when(mWifiEntry.isSaved()).thenReturn(true); final WifiConfiguration mockWifiConfig = mock(WifiConfiguration.class); + when(mockWifiConfig.getIpConfiguration()).thenReturn(mock(IpConfiguration.class)); when(mWifiEntry.getWifiConfiguration()).thenReturn(mockWifiConfig); mockWifiConfig.macRandomizationSetting = macRandomizedValue; mController = new TestWifiConfigController2(mConfigUiBase, mView, mWifiEntry, @@ -505,6 +507,7 @@ public class WifiConfigController2Test { when(mWifiEntry.isSaved()).thenReturn(true); when(mWifiEntry.getSecurity()).thenReturn(WifiEntry.SECURITY_EAP); final WifiConfiguration mockWifiConfig = mock(WifiConfiguration.class); + when(mockWifiConfig.getIpConfiguration()).thenReturn(mock(IpConfiguration.class)); final WifiEnterpriseConfig mockWifiEnterpriseConfig = mock(WifiEnterpriseConfig.class); when(mockWifiEnterpriseConfig.getEapMethod()).thenReturn(Eap.PEAP); mockWifiConfig.enterpriseConfig = mockWifiEnterpriseConfig; diff --git a/tests/robotests/src/com/android/settings/wifi/WifiConfigControllerTest.java b/tests/robotests/src/com/android/settings/wifi/WifiConfigControllerTest.java index bf507425062..3a17b6c76fb 100644 --- a/tests/robotests/src/com/android/settings/wifi/WifiConfigControllerTest.java +++ b/tests/robotests/src/com/android/settings/wifi/WifiConfigControllerTest.java @@ -24,6 +24,7 @@ import static org.mockito.Mockito.when; import android.content.Context; import android.content.res.Resources; +import android.net.IpConfiguration; import android.net.wifi.WifiConfiguration; import android.net.wifi.WifiEnterpriseConfig; import android.net.wifi.WifiEnterpriseConfig.Eap; @@ -389,6 +390,7 @@ public class WifiConfigControllerTest { private void checkSavedMacRandomizedValue(int macRandomizedValue) { when(mAccessPoint.isSaved()).thenReturn(true); final WifiConfiguration mockWifiConfig = mock(WifiConfiguration.class); + when(mockWifiConfig.getIpConfiguration()).thenReturn(mock(IpConfiguration.class)); when(mAccessPoint.getConfig()).thenReturn(mockWifiConfig); mockWifiConfig.macRandomizationSetting = macRandomizedValue; mController = new TestWifiConfigController(mConfigUiBase, mView, mAccessPoint, @@ -503,6 +505,7 @@ public class WifiConfigControllerTest { when(mAccessPoint.isSaved()).thenReturn(true); when(mAccessPoint.getSecurity()).thenReturn(AccessPoint.SECURITY_EAP); final WifiConfiguration mockWifiConfig = mock(WifiConfiguration.class); + when(mockWifiConfig.getIpConfiguration()).thenReturn(mock(IpConfiguration.class)); final WifiEnterpriseConfig mockWifiEnterpriseConfig = mock(WifiEnterpriseConfig.class); when(mockWifiEnterpriseConfig.getEapMethod()).thenReturn(Eap.PEAP); mockWifiConfig.enterpriseConfig = mockWifiEnterpriseConfig ;