PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Hide sliceView if Slice is null

Browse Source 
Fixes: 142035673
Test: robolectric, visual
Change-Id: I2b5b34d068ba4590f65a284d4f62a1cc77f9666f
This commit is contained in:
Raff Tsai
2019-10-03 15:37:48 +08:00
parent 9e3a9fd255
commit 590042b3ba
3 changed files with 85 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/com/android/settings/slices/SlicePreferenceController.java
View File

@@ -18,6 +18,7 @@ package com.android.settings.slices;
import android.content.Context;
import android.net.Uri;
import android.util.Log;
import androidx.annotation.VisibleForTesting;
import androidx.lifecycle.LiveData;
@@ -38,6 +39,7 @@ import com.android.settingslib.core.lifecycle.events.OnStop;
*/
public class SlicePreferenceController extends BasePreferenceController implements
LifecycleObserver, OnStart, OnStop, Observer<Slice> {
private static final String TAG = "SlicePreferenceController";
@VisibleForTesting
LiveData<Slice> mLiveData;
@VisibleForTesting
@@ -61,7 +63,10 @@ public class SlicePreferenceController extends BasePreferenceController implemen
public void setSliceUri(Uri uri) {
mUri = uri;
mLiveData = SliceLiveData.fromUri(mContext, mUri);
mLiveData = SliceLiveData.fromUri(mContext, mUri, (int type, Throwable source) -> {
Log.w(TAG, "Slice may be null. uri = " + uri + ", error = " + type);
onChanged(null);
});
//TODO(b/120803703): figure out why we need to remove observer first
mLiveData.removeObserver(this);