Merge "Display "Android Auto" in Connected Devices summary text." into rvc-dev
This commit is contained in:
@@ -7485,6 +7485,14 @@
|
|||||||
<string name="connected_devices_dashboard_no_driving_mode_summary">Bluetooth, NFC</string>
|
<string name="connected_devices_dashboard_no_driving_mode_summary">Bluetooth, NFC</string>
|
||||||
<!-- Summary for Connected devices settings, explaning a few important settings under it [CHAR LIMIT=NONE]-->
|
<!-- Summary for Connected devices settings, explaning a few important settings under it [CHAR LIMIT=NONE]-->
|
||||||
<string name="connected_devices_dashboard_no_driving_mode_no_nfc_summary">Bluetooth</string>
|
<string name="connected_devices_dashboard_no_driving_mode_no_nfc_summary">Bluetooth</string>
|
||||||
|
<!--Summary for Connected devices settings, explaning a few important settings under it [CHAR LIMIT=NONE]-->
|
||||||
|
<string name="connected_devices_dashboard_android_auto_summary">Bluetooth, Android Auto, driving mode, NFC</string><!--
|
||||||
|
Summary for Connected devices settings, explaning a few important settings under it [CHAR LIMIT=NONE]-->
|
||||||
|
<string name="connected_devices_dashboard_android_auto_no_nfc_summary">Bluetooth, Android Auto, driving mode</string>
|
||||||
|
<!-- Summary for Connected devices settings, explaning a few important settings under it [CHAR LIMIT=NONE]-->
|
||||||
|
<string name="connected_devices_dashboard_android_auto_no_driving_mode_summary">Bluetooth, Android Auto, NFC</string>
|
||||||
|
<!-- Summary for Connected devices settings, explaning a few important settings under it [CHAR LIMIT=NONE]-->
|
||||||
|
<string name="connected_devices_dashboard_android_auto_no_nfc_no_driving_mode">Bluetooth, Android Auto</string>
|
||||||
<!-- Summary for Tap & pay settings, explaning a few important settings under it [CHAR LIMIT=NONE]-->
|
<!-- Summary for Tap & pay settings, explaning a few important settings under it [CHAR LIMIT=NONE]-->
|
||||||
<string name="nfc_and_payment_settings_payment_off_nfc_off_summary">Unavailable because NFC is off</string>
|
<string name="nfc_and_payment_settings_payment_off_nfc_off_summary">Unavailable because NFC is off</string>
|
||||||
<!-- Summary for Tap & pay settings, explaning a few important settings under it [CHAR LIMIT=NONE]-->
|
<!-- Summary for Tap & pay settings, explaning a few important settings under it [CHAR LIMIT=NONE]-->
|
||||||
|
@@ -15,7 +15,10 @@
|
|||||||
*/
|
*/
|
||||||
package com.android.settings.connecteddevice;
|
package com.android.settings.connecteddevice;
|
||||||
|
|
||||||
|
import static com.android.settingslib.drawer.TileUtils.IA_SETTINGS_ACTION;
|
||||||
|
|
||||||
import android.content.Context;
|
import android.content.Context;
|
||||||
|
import android.content.Intent;
|
||||||
import android.provider.Settings;
|
import android.provider.Settings;
|
||||||
|
|
||||||
import androidx.annotation.VisibleForTesting;
|
import androidx.annotation.VisibleForTesting;
|
||||||
@@ -31,6 +34,7 @@ public class AdvancedConnectedDeviceController extends BasePreferenceController
|
|||||||
|
|
||||||
private static final String DRIVING_MODE_SETTINGS_ENABLED =
|
private static final String DRIVING_MODE_SETTINGS_ENABLED =
|
||||||
"gearhead:driving_mode_settings_enabled";
|
"gearhead:driving_mode_settings_enabled";
|
||||||
|
private static final String GEARHEAD_PACKAGE = "com.google.android.projection.gearhead";
|
||||||
|
|
||||||
public AdvancedConnectedDeviceController(Context context, String preferenceKey) {
|
public AdvancedConnectedDeviceController(Context context, String preferenceKey) {
|
||||||
super(context, preferenceKey);
|
super(context, preferenceKey);
|
||||||
@@ -55,7 +59,7 @@ public class AdvancedConnectedDeviceController extends BasePreferenceController
|
|||||||
new NfcPreferenceController(context, NfcPreferenceController.KEY_TOGGLE_NFC);
|
new NfcPreferenceController(context, NfcPreferenceController.KEY_TOGGLE_NFC);
|
||||||
|
|
||||||
return getConnectedDevicesSummaryResourceId(nfcPreferenceController,
|
return getConnectedDevicesSummaryResourceId(nfcPreferenceController,
|
||||||
isDrivingModeAvailable(context));
|
isDrivingModeAvailable(context), isAndroidAutoSettingAvailable(context));
|
||||||
}
|
}
|
||||||
|
|
||||||
@VisibleForTesting
|
@VisibleForTesting
|
||||||
@@ -64,26 +68,57 @@ public class AdvancedConnectedDeviceController extends BasePreferenceController
|
|||||||
getInt(context.getContentResolver(), DRIVING_MODE_SETTINGS_ENABLED, 0) == 1;
|
getInt(context.getContentResolver(), DRIVING_MODE_SETTINGS_ENABLED, 0) == 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@VisibleForTesting
|
||||||
|
static boolean isAndroidAutoSettingAvailable(Context context) {
|
||||||
|
final Intent intent = new Intent(IA_SETTINGS_ACTION);
|
||||||
|
intent.setPackage(GEARHEAD_PACKAGE);
|
||||||
|
return intent.resolveActivity(context.getPackageManager()) != null;
|
||||||
|
}
|
||||||
|
|
||||||
@VisibleForTesting
|
@VisibleForTesting
|
||||||
static int getConnectedDevicesSummaryResourceId(NfcPreferenceController
|
static int getConnectedDevicesSummaryResourceId(NfcPreferenceController
|
||||||
nfcPreferenceController, boolean isDrivingModeAvailable) {
|
nfcPreferenceController,
|
||||||
|
boolean isDrivingModeAvailable,
|
||||||
|
boolean isAndroidAutoAvailable) {
|
||||||
final int resId;
|
final int resId;
|
||||||
|
|
||||||
if (nfcPreferenceController.isAvailable()) {
|
if (isAndroidAutoAvailable) {
|
||||||
if (isDrivingModeAvailable) {
|
if (nfcPreferenceController.isAvailable()) {
|
||||||
// NFC available, driving mode available
|
if (isDrivingModeAvailable) {
|
||||||
resId = R.string.connected_devices_dashboard_summary;
|
// NFC available, driving mode available
|
||||||
|
resId = R.string.connected_devices_dashboard_android_auto_summary;
|
||||||
|
} else {
|
||||||
|
// NFC available, driving mode not available
|
||||||
|
resId =
|
||||||
|
R.string.connected_devices_dashboard_android_auto_no_driving_mode_summary;
|
||||||
|
}
|
||||||
} else {
|
} else {
|
||||||
// NFC available, driving mode not available
|
if (isDrivingModeAvailable) {
|
||||||
resId = R.string.connected_devices_dashboard_no_driving_mode_summary;
|
// NFC not available, driving mode available
|
||||||
|
resId = R.string.connected_devices_dashboard_android_auto_no_nfc_summary;
|
||||||
|
} else {
|
||||||
|
// NFC not available, driving mode not available
|
||||||
|
resId =
|
||||||
|
R.string.connected_devices_dashboard_android_auto_no_nfc_no_driving_mode;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
if (isDrivingModeAvailable) {
|
if (nfcPreferenceController.isAvailable()) {
|
||||||
// NFC not available, driving mode available
|
if (isDrivingModeAvailable) {
|
||||||
resId = R.string.connected_devices_dashboard_no_nfc_summary;
|
// NFC available, driving mode available
|
||||||
|
resId = R.string.connected_devices_dashboard_summary;
|
||||||
|
} else {
|
||||||
|
// NFC available, driving mode not available
|
||||||
|
resId = R.string.connected_devices_dashboard_no_driving_mode_summary;
|
||||||
|
}
|
||||||
} else {
|
} else {
|
||||||
// NFC not available, driving mode not available
|
if (isDrivingModeAvailable) {
|
||||||
resId = R.string.connected_devices_dashboard_no_driving_mode_no_nfc_summary;
|
// NFC not available, driving mode available
|
||||||
|
resId = R.string.connected_devices_dashboard_no_nfc_summary;
|
||||||
|
} else {
|
||||||
|
// NFC not available, driving mode not available
|
||||||
|
resId = R.string.connected_devices_dashboard_no_driving_mode_no_nfc_summary;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -23,9 +23,15 @@ import static org.mockito.Mockito.spy;
|
|||||||
|
|
||||||
import android.content.ContentResolver;
|
import android.content.ContentResolver;
|
||||||
import android.content.Context;
|
import android.content.Context;
|
||||||
|
import android.content.Intent;
|
||||||
|
import android.content.pm.ActivityInfo;
|
||||||
|
import android.content.pm.ApplicationInfo;
|
||||||
|
import android.content.pm.ResolveInfo;
|
||||||
import android.nfc.NfcAdapter;
|
import android.nfc.NfcAdapter;
|
||||||
import android.provider.Settings;
|
import android.provider.Settings;
|
||||||
|
|
||||||
|
import androidx.test.core.content.pm.ApplicationInfoBuilder;
|
||||||
|
|
||||||
import com.android.settings.R;
|
import com.android.settings.R;
|
||||||
import com.android.settings.nfc.NfcPreferenceController;
|
import com.android.settings.nfc.NfcPreferenceController;
|
||||||
|
|
||||||
@@ -38,6 +44,7 @@ import org.robolectric.RuntimeEnvironment;
|
|||||||
import org.robolectric.Shadows;
|
import org.robolectric.Shadows;
|
||||||
import org.robolectric.annotation.Config;
|
import org.robolectric.annotation.Config;
|
||||||
import org.robolectric.shadows.ShadowNfcAdapter;
|
import org.robolectric.shadows.ShadowNfcAdapter;
|
||||||
|
import org.robolectric.shadows.ShadowPackageManager;
|
||||||
import org.robolectric.util.ReflectionHelpers;
|
import org.robolectric.util.ReflectionHelpers;
|
||||||
|
|
||||||
@RunWith(RobolectricTestRunner.class)
|
@RunWith(RobolectricTestRunner.class)
|
||||||
@@ -47,11 +54,13 @@ public class AdvancedConnectedDeviceControllerTest {
|
|||||||
private static final String KEY = "test_key";
|
private static final String KEY = "test_key";
|
||||||
private static final String DRIVING_MODE_SETTINGS_ENABLED =
|
private static final String DRIVING_MODE_SETTINGS_ENABLED =
|
||||||
"gearhead:driving_mode_settings_enabled";
|
"gearhead:driving_mode_settings_enabled";
|
||||||
|
private static final String ANDROID_AUTO_PACKAGE = "com.google.android.projection.gearhead";
|
||||||
|
|
||||||
private Context mContext;
|
private Context mContext;
|
||||||
private NfcPreferenceController mNfcController;
|
private NfcPreferenceController mNfcController;
|
||||||
private ShadowNfcAdapter mShadowNfcAdapter;
|
private ShadowNfcAdapter mShadowNfcAdapter;
|
||||||
private ContentResolver mContentResolver;
|
private ContentResolver mContentResolver;
|
||||||
|
private ShadowPackageManager mShadowPackageManager;
|
||||||
|
|
||||||
@Before
|
@Before
|
||||||
public void setUp() {
|
public void setUp() {
|
||||||
@@ -62,6 +71,7 @@ public class AdvancedConnectedDeviceControllerTest {
|
|||||||
mNfcController = new NfcPreferenceController(mContext,
|
mNfcController = new NfcPreferenceController(mContext,
|
||||||
NfcPreferenceController.KEY_TOGGLE_NFC);
|
NfcPreferenceController.KEY_TOGGLE_NFC);
|
||||||
mShadowNfcAdapter = Shadows.shadowOf(NfcAdapter.getNfcAdapter(mContext));
|
mShadowNfcAdapter = Shadows.shadowOf(NfcAdapter.getNfcAdapter(mContext));
|
||||||
|
mShadowPackageManager = Shadows.shadowOf(mContext.getPackageManager());
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
@@ -76,14 +86,41 @@ public class AdvancedConnectedDeviceControllerTest {
|
|||||||
public void isDrivingModeAvailable_returnTrue() {
|
public void isDrivingModeAvailable_returnTrue() {
|
||||||
Settings.System.putInt(mContentResolver, DRIVING_MODE_SETTINGS_ENABLED, 1);
|
Settings.System.putInt(mContentResolver, DRIVING_MODE_SETTINGS_ENABLED, 1);
|
||||||
|
|
||||||
assertThat(AdvancedConnectedDeviceController.isDrivingModeAvailable(mContext)).isTrue();
|
assertThat(
|
||||||
|
AdvancedConnectedDeviceController.isDrivingModeAvailable(mContext)).isTrue();
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void isDrivingModeAvailable_returnFalse() {
|
public void isDrivingModeAvailable_returnFalse() {
|
||||||
Settings.System.putInt(mContentResolver, DRIVING_MODE_SETTINGS_ENABLED, 0);
|
Settings.System.putInt(mContentResolver, DRIVING_MODE_SETTINGS_ENABLED, 0);
|
||||||
|
|
||||||
assertThat(AdvancedConnectedDeviceController.isDrivingModeAvailable(mContext)).isFalse();
|
assertThat(
|
||||||
|
AdvancedConnectedDeviceController.isDrivingModeAvailable(mContext)).isFalse();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void isAndroidAutoSettingAvailable_returnTrue() {
|
||||||
|
final ApplicationInfo appInfo =
|
||||||
|
ApplicationInfoBuilder.newBuilder().setPackageName(ANDROID_AUTO_PACKAGE).build();
|
||||||
|
final ActivityInfo activityInfo = new ActivityInfo();
|
||||||
|
activityInfo.packageName = ANDROID_AUTO_PACKAGE;
|
||||||
|
activityInfo.name = ANDROID_AUTO_PACKAGE;
|
||||||
|
activityInfo.applicationInfo = appInfo;
|
||||||
|
final ResolveInfo resolveInfo = new ResolveInfo();
|
||||||
|
resolveInfo.activityInfo = activityInfo;
|
||||||
|
mShadowPackageManager.addResolveInfoForIntent(
|
||||||
|
buildAndroidAutoSettingsIntent(),
|
||||||
|
resolveInfo);
|
||||||
|
|
||||||
|
assertThat(
|
||||||
|
AdvancedConnectedDeviceController.isAndroidAutoSettingAvailable(mContext)).isTrue();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void isAndroidAutoSettingAvailable_returnFalse() {
|
||||||
|
// No ResolveInfo for Android Auto, expect false.
|
||||||
|
assertThat(
|
||||||
|
AdvancedConnectedDeviceController.isAndroidAutoSettingAvailable(mContext)).isFalse();
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
@@ -91,7 +128,7 @@ public class AdvancedConnectedDeviceControllerTest {
|
|||||||
// NFC available, driving mode available
|
// NFC available, driving mode available
|
||||||
mShadowNfcAdapter.setEnabled(true);
|
mShadowNfcAdapter.setEnabled(true);
|
||||||
assertThat(AdvancedConnectedDeviceController
|
assertThat(AdvancedConnectedDeviceController
|
||||||
.getConnectedDevicesSummaryResourceId(mNfcController, true))
|
.getConnectedDevicesSummaryResourceId(mNfcController, true, false))
|
||||||
.isEqualTo(R.string.connected_devices_dashboard_summary);
|
.isEqualTo(R.string.connected_devices_dashboard_summary);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -100,7 +137,7 @@ public class AdvancedConnectedDeviceControllerTest {
|
|||||||
// NFC is available, driving mode not available
|
// NFC is available, driving mode not available
|
||||||
mShadowNfcAdapter.setEnabled(true);
|
mShadowNfcAdapter.setEnabled(true);
|
||||||
assertThat(AdvancedConnectedDeviceController
|
assertThat(AdvancedConnectedDeviceController
|
||||||
.getConnectedDevicesSummaryResourceId(mNfcController, false))
|
.getConnectedDevicesSummaryResourceId(mNfcController, false, false))
|
||||||
.isEqualTo(R.string.connected_devices_dashboard_no_driving_mode_summary);
|
.isEqualTo(R.string.connected_devices_dashboard_no_driving_mode_summary);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -109,7 +146,7 @@ public class AdvancedConnectedDeviceControllerTest {
|
|||||||
// NFC not available, driving mode available
|
// NFC not available, driving mode available
|
||||||
ReflectionHelpers.setField(mNfcController, "mNfcAdapter", null);
|
ReflectionHelpers.setField(mNfcController, "mNfcAdapter", null);
|
||||||
assertThat(AdvancedConnectedDeviceController
|
assertThat(AdvancedConnectedDeviceController
|
||||||
.getConnectedDevicesSummaryResourceId(mNfcController, true))
|
.getConnectedDevicesSummaryResourceId(mNfcController, true, false))
|
||||||
.isEqualTo(R.string.connected_devices_dashboard_no_nfc_summary);
|
.isEqualTo(R.string.connected_devices_dashboard_no_nfc_summary);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -118,7 +155,52 @@ public class AdvancedConnectedDeviceControllerTest {
|
|||||||
// NFC not available, driving mode not available
|
// NFC not available, driving mode not available
|
||||||
ReflectionHelpers.setField(mNfcController, "mNfcAdapter", null);
|
ReflectionHelpers.setField(mNfcController, "mNfcAdapter", null);
|
||||||
assertThat(AdvancedConnectedDeviceController
|
assertThat(AdvancedConnectedDeviceController
|
||||||
.getConnectedDevicesSummaryResourceId(mNfcController, false))
|
.getConnectedDevicesSummaryResourceId(mNfcController, false, false))
|
||||||
.isEqualTo(R.string.connected_devices_dashboard_no_driving_mode_no_nfc_summary);
|
.isEqualTo(R.string.connected_devices_dashboard_no_driving_mode_no_nfc_summary);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void getConnectedDevicesSummaryResourceId_Auto_NFC_DrivingMode_Available() {
|
||||||
|
// NFC available, driving mode available
|
||||||
|
mShadowNfcAdapter.setEnabled(true);
|
||||||
|
assertThat(AdvancedConnectedDeviceController
|
||||||
|
.getConnectedDevicesSummaryResourceId(mNfcController, true, true))
|
||||||
|
.isEqualTo(R.string.connected_devices_dashboard_android_auto_summary);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void getConnectedDevicesSummaryResourceId_Auto_NFC_Available() {
|
||||||
|
// NFC is available, driving mode not available
|
||||||
|
mShadowNfcAdapter.setEnabled(true);
|
||||||
|
assertThat(AdvancedConnectedDeviceController
|
||||||
|
.getConnectedDevicesSummaryResourceId(mNfcController, false, true))
|
||||||
|
.isEqualTo(
|
||||||
|
R.string.connected_devices_dashboard_android_auto_no_driving_mode_summary);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void getConnectedDevicesSummaryResourceId_Auto_DrivingMode_Available() {
|
||||||
|
// NFC not available, driving mode available
|
||||||
|
ReflectionHelpers.setField(mNfcController, "mNfcAdapter", null);
|
||||||
|
assertThat(AdvancedConnectedDeviceController
|
||||||
|
.getConnectedDevicesSummaryResourceId(mNfcController, true, true))
|
||||||
|
.isEqualTo(R.string.connected_devices_dashboard_android_auto_no_nfc_summary);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void getConnectedDevicesSummaryResourceId_Auto_Available() {
|
||||||
|
// NFC not available, driving mode not available
|
||||||
|
ReflectionHelpers.setField(mNfcController, "mNfcAdapter", null);
|
||||||
|
assertThat(AdvancedConnectedDeviceController
|
||||||
|
.getConnectedDevicesSummaryResourceId(mNfcController, false, true))
|
||||||
|
.isEqualTo(
|
||||||
|
R.string.connected_devices_dashboard_android_auto_no_nfc_no_driving_mode);
|
||||||
|
}
|
||||||
|
|
||||||
|
private Intent buildAndroidAutoSettingsIntent() {
|
||||||
|
final Intent intent = new Intent("com.android.settings.action.IA_SETTINGS");
|
||||||
|
intent.setPackage(ANDROID_AUTO_PACKAGE);
|
||||||
|
return intent;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user