Merge "Do not show the redundant RemoveAccountFailureDialog" into sc-v2-dev

This commit is contained in:
Jason Chiu
2021-12-09 02:40:05 +00:00
committed by Android (Google) Code Review

View File

@@ -53,6 +53,7 @@ import java.io.IOException;
public class RemoveAccountPreferenceController extends AbstractPreferenceController public class RemoveAccountPreferenceController extends AbstractPreferenceController
implements PreferenceControllerMixin, OnClickListener { implements PreferenceControllerMixin, OnClickListener {
private static final String TAG = "RemoveAccountPrefController";
private static final String KEY_REMOVE_ACCOUNT = "remove_account"; private static final String KEY_REMOVE_ACCOUNT = "remove_account";
private final MetricsFeatureProvider mMetricsFeatureProvider; private final MetricsFeatureProvider mMetricsFeatureProvider;
@@ -175,10 +176,11 @@ public class RemoveAccountPreferenceController extends AbstractPreferenceControl
| IOException | IOException
| AuthenticatorException e) { | AuthenticatorException e) {
// handled below // handled below
} Log.w(TAG, "Remove account error: " + e);
if (failed) {
RemoveAccountFailureDialog.show(getTargetFragment()); RemoveAccountFailureDialog.show(getTargetFragment());
} else { }
Log.i(TAG, "failed: " + failed);
if (!failed) {
targetActivity.finish(); targetActivity.finish();
} }
}, null, mUserHandle); }, null, mUserHandle);
@@ -210,7 +212,7 @@ public class RemoveAccountPreferenceController extends AbstractPreferenceControl
final Context context = getActivity(); final Context context = getActivity();
return new AlertDialog.Builder(context) return new AlertDialog.Builder(context)
.setTitle(R.string.really_remove_account_title) .setTitle(R.string.remove_account_label)
.setMessage(R.string.remove_account_failed) .setMessage(R.string.remove_account_failed)
.setPositiveButton(android.R.string.ok, null) .setPositiveButton(android.R.string.ok, null)
.create(); .create();