PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix videoPreference is broken when switch to multiple window

Browse Source 
Fixes: 117802997
Test: robolectric, switch between multiple window and single window.
The video should keep displaying.

Change-Id: I97b6a4516b2591b80d9a046809ce4090fb02c80f
This commit is contained in:
Raff Tsai
2019-12-04 12:06:56 +08:00
parent 810f7861f0
commit 5314f2a51c
5 changed files with 26 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/robotests/src/com/android/settings/gestures/GesturePreferenceControllerTest.java
View File

@@ -81,25 +81,25 @@ public class GesturePreferenceControllerTest {
}
@Test
public void onResume_shouldStartVideoPreference() {
public void onStart_shouldStartVideoPreference() {
final VideoPreference videoPreference = mock(VideoPreference.class);
when(mScreen.findPreference(mController.getVideoPrefKey())).thenReturn(videoPreference);
mController.mIsPrefAvailable = true;
mController.displayPreference(mScreen);
mController.onResume();
mController.onStart();
verify(videoPreference).onViewVisible();
}
@Test
public void onPause_shouldStopVideoPreference() {
public void onStop_shouldStopVideoPreference() {
final VideoPreference videoPreference = mock(VideoPreference.class);
when(mScreen.findPreference(mController.getVideoPrefKey())).thenReturn(videoPreference);
mController.mIsPrefAvailable = true;
mController.displayPreference(mScreen);
mController.onPause();
mController.onStop();
verify(videoPreference).onViewInvisible();
}

8
tests/robotests/src/com/android/settings/widget/VideoPreferenceControllerTest.java
View File

@@ -77,19 +77,19 @@ public class VideoPreferenceControllerTest {
}
@Test
public void onPause_shouldCallOnViewInvisibleOnPrefernece() {
public void onStop_shouldCallOnViewInvisibleOnPrefernece() {
mController.displayPreference(mScreen);
mController.onPause();
mController.onStop();
verify(mPreference).onViewInvisible();
}
@Test
public void onResume_shouldCallOnViewVisibleOnPrefernece() {
public void onStart_shouldCallOnViewVisibleOnPrefernece() {
mController.displayPreference(mScreen);
mController.onResume();
mController.onStart();
verify(mPreference).onViewVisible();
}