From 5015b5c54915c79bb200387f76397fec4e642179 Mon Sep 17 00:00:00 2001 From: Chris Antol Date: Mon, 27 Jan 2025 20:05:34 +0000 Subject: [PATCH] Update permission for accessing Brightness Level Bug: 388372939 Flag: com.android.settings.flags.catalyst_display_settings_screen Test: atest PreferenceServiceTest NO_IFTTT=Not applicable to preference controller Change-Id: I7126ca56eb19fd113ad64eed1417651758711f3f --- .../settings/display/BrightnessLevelPreference.kt | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/display/BrightnessLevelPreference.kt b/src/com/android/settings/display/BrightnessLevelPreference.kt index 3e0d07ed947..7d762319af8 100644 --- a/src/com/android/settings/display/BrightnessLevelPreference.kt +++ b/src/com/android/settings/display/BrightnessLevelPreference.kt @@ -97,8 +97,14 @@ class BrightnessLevelPreference : preference.isPersistent = false } - override fun getReadPermissions(context: Context) = - Permissions.allOf(Manifest.permission.CONTROL_DISPLAY_BRIGHTNESS) + // Note that we *currently* use restricted APIs to obtain the brightness value, but the + // brightness value itself is not data that requires permission restriction (as evidence this + // value is already available via the summary field). As long as we only + // expose the brightness value and not the other data obtained from BrightnessInfo, we do not + // require a permission control to obtain this value. A new API is in the works for Brightness + // that we can later migrate to that doesn't use any of these permission controls. + // Reference ticket: b/388557367 + override fun getReadPermissions(context: Context) = Permissions.EMPTY override fun getWritePermissions(context: Context) = Permissions.EMPTY