From 5024a3896547fc33b882ba78b5845d186375d9e0 Mon Sep 17 00:00:00 2001 From: jackqdyulei Date: Thu, 14 Sep 2017 16:11:02 -0700 Subject: [PATCH] Hook up lint color check to settings After this cl, settings will run hardcoded color check (go/color-check-guideline) for all the cls in pre-upload. This check will prompt error message if cl contains hardcoded color. Bug: 32750778 Test: repo upload . Change-Id: Id35ded5199094a14fcc4eeebc470164d052e278e --- PREUPLOAD.cfg | 1 + color-check-baseline.xml | 2484 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 2485 insertions(+) create mode 100644 color-check-baseline.xml diff --git a/PREUPLOAD.cfg b/PREUPLOAD.cfg index bbc1f689c71..62a2e434793 100644 --- a/PREUPLOAD.cfg +++ b/PREUPLOAD.cfg @@ -1,4 +1,5 @@ [Hook Scripts] checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT} -fw src/com/android/settings/print/ +checkcolor_hook = ${REPO_ROOT}/prebuilts/checkcolor/checkcolor.py -p . diff --git a/color-check-baseline.xml b/color-check-baseline.xml new file mode 100644 index 00000000000..cbcdf48ddea --- /dev/null +++ b/color-check-baseline.xml @@ -0,0 +1,2484 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +