From cba834dedf62912306d04b95a7612db7133c8b65 Mon Sep 17 00:00:00 2001 From: Fabrice Di Meglio Date: Fri, 8 Aug 2014 13:55:58 -0700 Subject: [PATCH] Fix bug #16578018 Wi-Fi network list items should be centered with icons - force correct refresh of the Preference summary - put some non used code into comment ... Change-Id: I17fc6fe2cf0717bae613d78cfac2c88d3e160ef4 --- .../android/settings/wifi/AccessPoint.java | 32 +++++++++++-------- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/src/com/android/settings/wifi/AccessPoint.java b/src/com/android/settings/wifi/AccessPoint.java index b3fafa40a6c..0ec1f13943f 100644 --- a/src/com/android/settings/wifi/AccessPoint.java +++ b/src/com/android/settings/wifi/AccessPoint.java @@ -520,6 +520,10 @@ class AccessPoint extends Preference { final Context context = getContext(); updateIcon(getLevel(), context); + // Force new summary + setSummary(null); + + // Update to new summary StringBuilder summary = new StringBuilder(); if (mState != null) { // This is the active connection @@ -551,22 +555,18 @@ class AccessPoint extends Preference { summary.append(context.getString(R.string.wifi_remembered)); } - if (security != SECURITY_NONE) { - String securityStrFormat; - if (summary.length() == 0) { - securityStrFormat = context.getString(R.string.wifi_secured_first_item); - } else { - securityStrFormat = context.getString(R.string.wifi_secured_second_item); - } - } +// TODO: Wi-Fi team needs to decide what to do with this code. +// if (security != SECURITY_NONE) { +// String securityStrFormat; +// if (summary.length() == 0) { +// securityStrFormat = context.getString(R.string.wifi_secured_first_item); +// } else { +// securityStrFormat = context.getString(R.string.wifi_secured_second_item); +// } +// } } - // This is a workaround, see bug report... - if (summary.length() < 1) { - summary.append(" "); - } - if (WifiSettings.mVerboseLogging > 0) { //add RSSI/band information for this config, what was seen up to 6 seconds ago //verbose WiFi Logging is only turned on thru developers settings @@ -591,7 +591,11 @@ class AccessPoint extends Preference { } } - setSummary(summary.toString()); + if (summary.length() > 0) { + setSummary(summary.toString()); + } else { + showSummary = false; + } } /**