diff --git a/res/xml/my_device_info.xml b/res/xml/my_device_info.xml index 535f61afa5d..67ad5d1ac72 100644 --- a/res/xml/my_device_info.xml +++ b/res/xml/my_device_info.xml @@ -96,6 +96,7 @@ android:title="@string/hardware_info" settings:keywords="@string/keywords_model_and_hardware" android:summary="@string/summary_placeholder" + settings:allowDynamicSummaryInSlice="true" settings:controller= "com.android.settings.deviceinfo.DeviceModelPreferenceController" /> @@ -109,11 +110,12 @@ diff --git a/src/com/android/settings/deviceinfo/DeviceModelPreferenceController.java b/src/com/android/settings/deviceinfo/DeviceModelPreferenceController.java index 8fdd19fe03f..25090dce0eb 100644 --- a/src/com/android/settings/deviceinfo/DeviceModelPreferenceController.java +++ b/src/com/android/settings/deviceinfo/DeviceModelPreferenceController.java @@ -73,6 +73,11 @@ public class DeviceModelPreferenceController extends BasePreferenceController { return true; } + @Override + public boolean isSliceable() { + return true; + } + public static String getDeviceModel() { FutureTask msvSuffixTask = new FutureTask(new Callable() { @Override diff --git a/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceController.java b/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceController.java index d2d3bf441be..7d12d433c56 100644 --- a/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceController.java +++ b/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceController.java @@ -56,4 +56,9 @@ public class FirmwareVersionPreferenceController extends BasePreferenceControlle FirmwareVersionDialogFragment.show(mFragment); return true; } + + @Override + public boolean isSliceable() { + return true; + } } diff --git a/tests/robotests/src/com/android/settings/deviceinfo/DeviceModelPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/deviceinfo/DeviceModelPreferenceControllerTest.java index e337141da25..aa84adfcaa1 100644 --- a/tests/robotests/src/com/android/settings/deviceinfo/DeviceModelPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/deviceinfo/DeviceModelPreferenceControllerTest.java @@ -48,7 +48,7 @@ import org.robolectric.annotation.Config; @RunWith(SettingsRobolectricTestRunner.class) public class DeviceModelPreferenceControllerTest { - private final String KEY = "device_model_key"; + private final String KEY = "device_model"; @Mock private Fragment mFragment; @@ -101,6 +101,11 @@ public class DeviceModelPreferenceControllerTest { .add(any(HardwareInfoDialogFragment.class), eq(HardwareInfoDialogFragment.TAG)); } + @Test + public void isSliceable_shouldBeTrue() { + assertThat(mController.isSliceable()).isTrue(); + } + private boolean containBuildModel(CharSequence result) { final String oracle = mContext.getResources().getString(R.string.model_summary, Build.MODEL); diff --git a/tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerTest.java index 3927e202433..e7b18934400 100644 --- a/tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerTest.java @@ -44,7 +44,7 @@ import org.robolectric.annotation.Resetter; @RunWith(SettingsRobolectricTestRunner.class) public class FirmwareVersionPreferenceControllerTest { - private final String KEY = "firmware_key"; + private final String KEY = "firmware_version"; @Mock private Fragment mFragment; @@ -103,6 +103,11 @@ public class FirmwareVersionPreferenceControllerTest { assertThat(result).isFalse(); } + @Test + public void isSliceable_shouldBeTrue() { + assertThat(mController.isSliceable()).isTrue(); + } + @Implements(FirmwareVersionDialogFragment.class) public static class ShadowFirmwareVersionDialogFragment {