PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

When BT is off hide rename preference

Browse Source 
* Hide the preference when BT is off, shown preference when BT is on.

Bug: 78247352
Test: make -j40 RunSettingsRoboTests ROBOTEST_FILTER=BluetoothDeviceNamePreferenceControllerTest
Change-Id: Id1e11c7b546d7ac5bc8606e8645d07d77f2b522f
This commit is contained in:
hughchen
2018-05-21 20:46:57 +08:00
committed by Lei Yu
parent cd28a977ca
commit 4e2160904d
4 changed files with 34 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/com/android/settings/bluetooth/BluetoothDeviceNamePreferenceController.java
View File

@@ -50,7 +50,7 @@ public class BluetoothDeviceNamePreferenceController extends BasePreferenceContr
@VisibleForTesting @VisibleForTesting
Preference mPreference; Preference mPreference;
private LocalBluetoothManager mLocalManager; private LocalBluetoothManager mLocalManager;
private LocalBluetoothAdapter mLocalAdapter; protected LocalBluetoothAdapter mLocalAdapter;
public BluetoothDeviceNamePreferenceController(Context context, Lifecycle lifecycle) { public BluetoothDeviceNamePreferenceController(Context context, Lifecycle lifecycle) {
this(context, (LocalBluetoothAdapter) null); this(context, (LocalBluetoothAdapter) null);
@@ -88,8 +88,10 @@ public class BluetoothDeviceNamePreferenceController extends BasePreferenceContr
@Override @Override
public void onStart() { public void onStart() {
mContext.registerReceiver(mReceiver, final IntentFilter intentFilter = new IntentFilter();
new IntentFilter(BluetoothAdapter.ACTION_LOCAL_NAME_CHANGED)); intentFilter.addAction(BluetoothAdapter.ACTION_LOCAL_NAME_CHANGED);
intentFilter.addAction(BluetoothAdapter.ACTION_STATE_CHANGED);
mContext.registerReceiver(mReceiver, intentFilter);
} }
@Override @Override
@@ -109,7 +111,7 @@ public class BluetoothDeviceNamePreferenceController extends BasePreferenceContr
@Override @Override
public void updateState(Preference preference) { public void updateState(Preference preference) {
updateDeviceName(preference); updatePreferenceState(preference);
} }
@Override @Override
@@ -145,7 +147,7 @@ public class BluetoothDeviceNamePreferenceController extends BasePreferenceContr
* *
* @param preference to set the summary for * @param preference to set the summary for
*/ */
protected void updateDeviceName(final Preference preference) { protected void updatePreferenceState(final Preference preference) {
preference.setSelectable(false); preference.setSelectable(false);
preference.setSummary(getSummary()); preference.setSummary(getSummary());
} }
@@ -166,8 +168,10 @@ public class BluetoothDeviceNamePreferenceController extends BasePreferenceContr
if (TextUtils.equals(action, BluetoothAdapter.ACTION_LOCAL_NAME_CHANGED)) { if (TextUtils.equals(action, BluetoothAdapter.ACTION_LOCAL_NAME_CHANGED)) {
if (mPreference != null && mLocalAdapter != null && mLocalAdapter.isEnabled()) { if (mPreference != null && mLocalAdapter != null && mLocalAdapter.isEnabled()) {
updateDeviceName(mPreference); updatePreferenceState(mPreference);
} }
} else if (TextUtils.equals(action, BluetoothAdapter.ACTION_STATE_CHANGED)) {
updatePreferenceState(mPreference);
} }
} }
}; };

3
src/com/android/settings/bluetooth/BluetoothDeviceRenamePreferenceController.java
View File

@@ -67,8 +67,9 @@ public class BluetoothDeviceRenamePreferenceController extends
} }
@Override @Override
protected void updateDeviceName(final Preference preference) { protected void updatePreferenceState(final Preference preference) {
preference.setSummary(getSummary()); preference.setSummary(getSummary());
preference.setVisible(mLocalAdapter != null && mLocalAdapter.isEnabled());
} }
@Override @Override

2
tests/robotests/src/com/android/settings/bluetooth/BluetoothDeviceNamePreferenceControllerTest.java
View File

@@ -68,7 +68,7 @@ public class BluetoothDeviceNamePreferenceControllerTest {
@Test @Test
public void testUpdateDeviceName_showSummaryWithDeviceName() { public void testUpdateDeviceName_showSummaryWithDeviceName() {
mController.updateDeviceName(mPreference); mController.updatePreferenceState(mPreference);
final CharSequence summary = mPreference.getSummary(); final CharSequence summary = mPreference.getSummary();

26
tests/robotests/src/com/android/settings/bluetooth/BluetoothDeviceRenamePreferenceControllerTest.java
View File

@@ -70,11 +70,13 @@ public class BluetoothDeviceRenamePreferenceControllerTest {
mController = spy(new BluetoothDeviceRenamePreferenceController( mController = spy(new BluetoothDeviceRenamePreferenceController(
mContext, PREF_KEY, mFragment, mLocalAdapter)); mContext, PREF_KEY, mFragment, mLocalAdapter));
doReturn(DEVICE_NAME).when(mController).getDeviceName(); doReturn(DEVICE_NAME).when(mController).getDeviceName();
when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference);
mController.displayPreference(mScreen);
} }
@Test @Test
public void testUpdateDeviceName_showSummaryWithDeviceName() { public void testUpdateDeviceName_showSummaryWithDeviceName() {
mController.updateDeviceName(mPreference); mController.updatePreferenceState(mPreference);
final CharSequence summary = mPreference.getSummary(); final CharSequence summary = mPreference.getSummary();
@@ -93,10 +95,24 @@ public class BluetoothDeviceRenamePreferenceControllerTest {
@Test @Test
public void displayPreference_shouldFindPreferenceWithMatchingPrefKey() { public void displayPreference_shouldFindPreferenceWithMatchingPrefKey() {
when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference);
mController.displayPreference(mScreen);
assertThat(mController.mPreference.getKey()).isEqualTo(mController.getPreferenceKey()); assertThat(mController.mPreference.getKey()).isEqualTo(mController.getPreferenceKey());
} }
@Test
public void updatePreferenceState_whenBTisOnPreferenceShouldBeVisible() {
when(mLocalAdapter.isEnabled()).thenReturn(true);
mController.updatePreferenceState(mPreference);
assertThat(mPreference.isVisible()).isTrue();
}
@Test
public void updatePreferenceState_whenBTisOffPreferenceShouldBeHide() {
when(mLocalAdapter.isEnabled()).thenReturn(false);
mController.updatePreferenceState(mPreference);
assertThat(mPreference.isVisible()).isFalse();
}
} }