diff --git a/AndroidManifest.xml b/AndroidManifest.xml index a94801f1dfa..04595e5c429 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -116,14 +116,6 @@ - - - - - - - - - - - - - - \ No newline at end of file diff --git a/res/values/themes.xml b/res/values/themes.xml index f2c1eae6a13..0de199f97a3 100644 --- a/res/values/themes.xml +++ b/res/values/themes.xml @@ -58,10 +58,6 @@ @color/battery_maybe_color_light @color/battery_bad_color_light - - @*android:color/primary_device_default_settings_light - @android:color/white - @style/Widget.SliceView.Settings diff --git a/src/com/android/settings/SettingsActivity.java b/src/com/android/settings/SettingsActivity.java index 8bd81eea912..541ca3a66ad 100644 --- a/src/com/android/settings/SettingsActivity.java +++ b/src/com/android/settings/SettingsActivity.java @@ -18,7 +18,6 @@ package com.android.settings; import android.app.ActionBar; import android.app.ActivityManager; -import android.app.settings.SettingsEnums; import android.content.BroadcastReceiver; import android.content.ComponentName; import android.content.Context; @@ -37,7 +36,6 @@ import android.util.Log; import android.view.View; import android.view.ViewGroup; import android.widget.Button; -import android.widget.Toolbar; import androidx.annotation.Nullable; import androidx.annotation.VisibleForTesting; @@ -165,12 +163,6 @@ public class SettingsActivity extends SettingsBaseActivity private Button mNextButton; - /** - * TODO(b/118444000): Remove this and all related code. - */ - @Deprecated - private boolean mIsShowingDashboard; - private ViewGroup mContent; // Categories @@ -253,11 +245,7 @@ public class SettingsActivity extends SettingsBaseActivity setTheme(R.style.Theme_SubSettings); } - mIsShowingDashboard = TextUtils.equals( - SettingsActivity.class.getName(), intent.getComponent().getClassName()); - - setContentView(mIsShowingDashboard ? - R.layout.settings_main_dashboard : R.layout.settings_main_prefs); + setContentView(R.layout.settings_main_prefs); mContent = findViewById(R.id.main_content); @@ -280,21 +268,12 @@ public class SettingsActivity extends SettingsBaseActivity } final boolean deviceProvisioned = Utils.isDeviceProvisioned(this); - if (mIsShowingDashboard) { - findViewById(R.id.search_bar).setVisibility( - deviceProvisioned ? View.VISIBLE : View.INVISIBLE); - findViewById(R.id.action_bar).setVisibility(View.GONE); - final Toolbar toolbar = findViewById(R.id.search_action_bar); - setActionBar(toolbar); - FeatureFactory.getFactory(this).getSearchFeatureProvider() - .initSearchToolbar(this, toolbar, SettingsEnums.SETTINGS_HOMEPAGE); - } - ActionBar actionBar = getActionBar(); + final ActionBar actionBar = getActionBar(); if (actionBar != null) { actionBar.setDisplayHomeAsUpEnabled(deviceProvisioned); actionBar.setHomeButtonEnabled(deviceProvisioned); - actionBar.setDisplayShowTitleEnabled(!mIsShowingDashboard); + actionBar.setDisplayShowTitleEnabled(true); } mSwitchBar = findViewById(R.id.switch_bar); if (mSwitchBar != null) { diff --git a/src/com/android/settings/core/FeatureFlags.java b/src/com/android/settings/core/FeatureFlags.java index 78fdfe778ad..f2ffe2255ea 100644 --- a/src/com/android/settings/core/FeatureFlags.java +++ b/src/com/android/settings/core/FeatureFlags.java @@ -21,7 +21,6 @@ package com.android.settings.core; */ public class FeatureFlags { public static final String AUDIO_SWITCHER_SETTINGS = "settings_audio_switcher"; - public static final String DYNAMIC_HOMEPAGE = "settings_dynamic_homepage"; public static final String HEARING_AID_SETTINGS = "settings_bluetooth_hearing_aid"; public static final String MOBILE_NETWORK_V2 = "settings_mobile_network_v2"; public static final String WIFI_MAC_RANDOMIZATION = "settings_wifi_mac_randomization"; diff --git a/src/com/android/settings/homepage/SettingsHomepageActivity.java b/src/com/android/settings/homepage/SettingsHomepageActivity.java index 7c5f9283167..9e869a9daab 100644 --- a/src/com/android/settings/homepage/SettingsHomepageActivity.java +++ b/src/com/android/settings/homepage/SettingsHomepageActivity.java @@ -18,9 +18,7 @@ package com.android.settings.homepage; import android.animation.LayoutTransition; import android.app.settings.SettingsEnums; -import android.content.Intent; import android.os.Bundle; -import android.util.FeatureFlagUtils; import android.view.View; import android.widget.FrameLayout; import android.widget.ImageView; @@ -32,9 +30,7 @@ import androidx.fragment.app.FragmentManager; import androidx.fragment.app.FragmentTransaction; import com.android.settings.R; -import com.android.settings.SettingsActivity; import com.android.settings.accounts.AvatarViewMixin; -import com.android.settings.core.FeatureFlags; import com.android.settings.core.SettingsBaseActivity; import com.android.settings.homepage.contextualcards.ContextualCardsFragment; import com.android.settings.overlay.FeatureFactory; @@ -45,13 +41,6 @@ public class SettingsHomepageActivity extends SettingsBaseActivity { protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); - if (!FeatureFlagUtils.isEnabled(this, FeatureFlags.DYNAMIC_HOMEPAGE)) { - final Intent settings = new Intent(this, SettingsActivity.class); - startActivity(settings); - finish(); - return; - } - updateWindowProperties(); setContentView(R.layout.settings_homepage_container); setHomepageContainerPaddingTop(); diff --git a/tests/robotests/src/com/android/settings/homepage/SettingsHomepageActivityTest.java b/tests/robotests/src/com/android/settings/homepage/SettingsHomepageActivityTest.java index df9e85d96c2..50a798f744b 100644 --- a/tests/robotests/src/com/android/settings/homepage/SettingsHomepageActivityTest.java +++ b/tests/robotests/src/com/android/settings/homepage/SettingsHomepageActivityTest.java @@ -18,36 +18,19 @@ package com.android.settings.homepage; import static com.google.common.truth.Truth.assertThat; -import android.util.FeatureFlagUtils; import android.view.View; import android.widget.FrameLayout; import com.android.settings.R; -import com.android.settings.SettingsActivity; -import com.android.settings.core.FeatureFlags; import org.junit.Test; import org.junit.runner.RunWith; import org.robolectric.Robolectric; import org.robolectric.RobolectricTestRunner; -import org.robolectric.RuntimeEnvironment; -import org.robolectric.Shadows; -import org.robolectric.shadows.ShadowActivity; @RunWith(RobolectricTestRunner.class) public class SettingsHomepageActivityTest { - @Test - public void launch_featureFlagOff_shouldRedirectToSettingsActivity() { - FeatureFlagUtils.setEnabled(RuntimeEnvironment.application, FeatureFlags.DYNAMIC_HOMEPAGE, - false); - - final ShadowActivity shadowActivity = Shadows.shadowOf( - Robolectric.setupActivity(SettingsHomepageActivity.class)); - assertThat(shadowActivity.getNextStartedActivity().getComponent().getClassName()) - .isEqualTo(SettingsActivity.class.getName()); - } - @Test public void setHomepageContainerPaddingTop_shouldBeSetPaddingTop() { final SettingsHomepageActivity activity = Robolectric.buildActivity(