From 4d70be899df6ab72e897c531037a32a0f06b57e4 Mon Sep 17 00:00:00 2001 From: Raff Tsai Date: Fri, 5 Jul 2019 15:06:32 +0800 Subject: [PATCH] Fix robolectric test error Fixes: 136778642 Test: make RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.deviceinfo" Change-Id: I55591ec44397c39e71de7503c37ec84bbc17bfb1 --- .../TopLevelStoragePreferenceControllerTest.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/robotests/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java b/tests/robotests/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java index 6a192038e65..7d7be6c6041 100644 --- a/tests/robotests/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java @@ -29,6 +29,8 @@ import android.icu.text.NumberFormat; import android.os.storage.VolumeInfo; import android.text.format.Formatter; +import androidx.preference.Preference; + import com.android.settings.R; import com.android.settingslib.deviceinfo.StorageManagerVolumeProvider; @@ -77,14 +79,15 @@ public class TopLevelStoragePreferenceControllerTest { when(mStorageManagerVolumeProvider .getFreeBytes(nullable(StorageStatsManager.class), nullable(VolumeInfo.class))) .thenReturn(0L); - ReflectionHelpers.setField(mController, "mStorageManagerVolumeProvider", mStorageManagerVolumeProvider); - final String percentage = NumberFormat.getPercentInstance().format(1); final String freeSpace = Formatter.formatFileSize(RuntimeEnvironment.application, 0); - assertThat(mController.getSummary()).isEqualTo( - RuntimeEnvironment.application.getString( - R.string.storage_summary, percentage, freeSpace)); + final Preference preference = new Preference(mContext); + + mController.updateState(preference); + + assertThat(preference.getSummary()).isEqualTo( + mContext.getString(R.string.storage_summary, percentage, freeSpace)); } }