Merge "Add saturation boost setting"

res/values/strings.xml

@@ -2332,6 +2332,8 @@
     <string name="display_settings">Display</string>
     <!-- Sound & display settings screen, accelerometer-based rotation check box label -->
     <string name="accelerometer_title">Auto-rotate screen</string>
+    <!-- Display settings screen, vivid (or vibrant or saturated) color mode switch label [CHAR LIMIT=30] -->
+    <string name="color_mode_title">Vivid colors</string>
     <!-- Sound & display settings screen, accelerometer-based rotation summary text when check box is selected -->
     <string name="accelerometer_summary_on" product="tablet">Switch orientation automatically when rotating tablet</string>
     <!-- Sound & display settings screen, accelerometer-based rotation summary text when check box is selected -->

res/xml/development_prefs.xml

@@ -71,7 +71,7 @@
         android:fragment="com.android.settings.applications.ConvertToFbe" />
 
     <com.android.settings.development.ColorModePreference
-        android:key="color_mode"
+        android:key="picture_color_mode"
         android:title="@string/picture_color_mode"
         android:summary="@string/picture_color_mode_desc" />
 

res/xml/display_settings.xml

@@ -62,6 +62,10 @@
         android:key="auto_rotate"
         android:title="@string/accelerometer_title" />
 
+    <SwitchPreference
+        android:key="color_mode"
+        android:title="@string/color_mode_title" />
+
     <Preference
         android:key="font_size"
         android:title="@string/title_font_size"

src/com/android/settings/DisplaySettings.java

@@ -28,6 +28,7 @@ import com.android.settings.display.AutoBrightnessPreferenceController;
 import com.android.settings.display.AutoRotatePreferenceController;
 import com.android.settings.display.BrightnessLevelPreferenceController;
 import com.android.settings.display.CameraGesturePreferenceController;
+import com.android.settings.display.ColorModePreferenceController;
 import com.android.settings.display.FontSizePreferenceController;
 import com.android.settings.display.LiftToWakePreferenceController;
 import com.android.settings.display.NightDisplayPreferenceController;
@@ -105,6 +106,7 @@ public class DisplaySettings extends DashboardFragment {
         controllers.add(new WallpaperPreferenceController(context));
         controllers.add(new ThemePreferenceController(context));
         controllers.add(new BrightnessLevelPreferenceController(context, lifecycle));
+        controllers.add(new ColorModePreferenceController(context));
         return controllers;
     }
 

src/com/android/settings/development/DevelopmentSettings.java

@@ -193,7 +193,7 @@ public class DevelopmentSettings extends RestrictedSettingsFragment
     private static final String WIFI_ALLOW_SCAN_WITH_TRAFFIC_KEY = "wifi_allow_scan_with_traffic";
     private static final String USB_CONFIGURATION_KEY = "select_usb_configuration";
     private static final String MOBILE_DATA_ALWAYS_ON = "mobile_data_always_on";
-    private static final String KEY_COLOR_MODE = "color_mode";
+    private static final String KEY_COLOR_MODE = "picture_color_mode";
     private static final String FORCE_RESIZABLE_KEY = "force_resizable_activities";
     private static final String COLOR_TEMPERATURE_KEY = "color_temperature";
 
@@ -555,7 +555,8 @@ public class DevelopmentSettings extends RestrictedSettingsFragment
 
         mColorModePreference = (ColorModePreference) findPreference(KEY_COLOR_MODE);
         mColorModePreference.updateCurrentAndSupported();
-        if (mColorModePreference.getColorModeCount() < 2) {
+        if (mColorModePreference.getColorModeCount() < 2 ||
+                getContext().getDisplay().isWideColorGamut()) {
             removePreference(KEY_COLOR_MODE);
             mColorModePreference = null;
         }

src/com/android/settings/display/ColorModePreferenceController.java

@@ -0,0 +1,118 @@
+/*
+ * Copyright (C) 2017 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the
+ * License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+package com.android.settings.display;
+
+import android.content.Context;
+import android.os.IBinder;
+import android.os.Parcel;
+import android.os.RemoteException;
+import android.os.ServiceManager;
+import android.os.SystemProperties;
+import android.support.v7.preference.Preference;
+import android.support.v7.preference.TwoStatePreference;
+import android.util.Log;
+import com.android.internal.annotations.VisibleForTesting;
+import com.android.settings.core.PreferenceController;
+
+public class ColorModePreferenceController extends PreferenceController implements
+        Preference.OnPreferenceChangeListener {
+    private static final String TAG = "ColorModePreference";
+
+    private static final String KEY_COLOR_MODE = "color_mode";
+
+    @VisibleForTesting
+    static final float COLOR_SATURATION_DEFAULT = 1.0f;
+    @VisibleForTesting
+    static final float COLOR_SATURATION_VIVID = 1.1f;
+
+    private static final int SURFACE_FLINGER_TRANSACTION_SATURATION = 1022;
+    @VisibleForTesting
+    static final String PERSISTENT_PROPERTY_SATURATION = "persist.sys.sf.color_saturation";
+
+    private final IBinder mSurfaceFlinger;
+    private final ConfigurationWrapper mConfigWrapper;
+
+    public ColorModePreferenceController(Context context) {
+        super(context);
+        mSurfaceFlinger = ServiceManager.getService("SurfaceFlinger");
+        mConfigWrapper = new ConfigurationWrapper(context);
+    }
+
+    @Override
+    public String getPreferenceKey() {
+        return KEY_COLOR_MODE;
+    }
+
+    @Override
+    public void updateState(Preference preference) {
+        TwoStatePreference colorMode = (TwoStatePreference) preference;
+        colorMode.setChecked(getSaturationValue() > 1.0f);
+    }
+
+    @Override
+    public boolean isAvailable() {
+        return mConfigWrapper.isScreenWideColorGamut();
+    }
+
+    @Override
+    public boolean onPreferenceChange(Preference preference, Object newValue) {
+        float saturation = (boolean) newValue
+                ? COLOR_SATURATION_VIVID : COLOR_SATURATION_DEFAULT;
+
+        SystemProperties.set(PERSISTENT_PROPERTY_SATURATION, Float.toString(saturation));
+        applySaturation(saturation);
+
+        return true;
+    }
+
+    /**
+     * Propagates the provided saturation to the SurfaceFlinger.
+     */
+    private void applySaturation(float saturation) {
+        if (mSurfaceFlinger != null) {
+            final Parcel data = Parcel.obtain();
+            data.writeInterfaceToken("android.ui.ISurfaceComposer");
+            data.writeFloat(saturation);
+            try {
+                mSurfaceFlinger.transact(SURFACE_FLINGER_TRANSACTION_SATURATION, data, null, 0);
+            } catch (RemoteException ex) {
+                Log.e(TAG, "Failed to set saturation", ex);
+            } finally {
+                data.recycle();
+            }
+        }
+    }
+
+    private static float getSaturationValue() {
+        try {
+            return Float.parseFloat(SystemProperties.get(
+                    PERSISTENT_PROPERTY_SATURATION, Float.toString(COLOR_SATURATION_DEFAULT)));
+        } catch (NumberFormatException e) {
+            return COLOR_SATURATION_DEFAULT;
+        }
+    }
+
+    @VisibleForTesting
+    static class ConfigurationWrapper {
+        private final Context mContext;
+
+        ConfigurationWrapper(Context context) {
+            mContext = context;
+        }
+
+        boolean isScreenWideColorGamut() {
+            return mContext.getResources().getConfiguration().isScreenWideColorGamut();
+        }
+    }
+}

tests/robotests/src/com/android/settings/display/ColorModePreferenceControllerTest.java

@@ -0,0 +1,113 @@
+/*
+ * Copyright (C) 2017 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.android.settings.display;
+
+import android.content.Context;
+import android.os.IBinder;
+import android.support.v14.preference.SwitchPreference;
+import android.support.v7.preference.PreferenceScreen;
+import com.android.settings.SettingsRobolectricTestRunner;
+import com.android.settings.TestConfig;
+import com.android.settings.testutils.shadow.SettingsShadowSystemProperties;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.robolectric.annotation.Config;
+import org.robolectric.util.ReflectionHelpers;
+
+import static com.google.common.truth.Truth.assertThat;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+@RunWith(SettingsRobolectricTestRunner.class)
+@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
+public class ColorModePreferenceControllerTest {
+    @Mock
+    private ColorModePreferenceController.ConfigurationWrapper mConfigWrapper;
+    @Mock
+    private SwitchPreference mPreference;
+    @Mock
+    private PreferenceScreen mScreen;
+    @Mock
+    private Context mContext;
+    @Mock
+    private IBinder mSurfaceFlinger;
+
+    private ColorModePreferenceController mController;
+
+    @Before
+    public void setup() {
+        MockitoAnnotations.initMocks(this);
+        SettingsShadowSystemProperties.clear();
+
+        mController = new ColorModePreferenceController(mContext);
+        ReflectionHelpers.setField(mController, "mSurfaceFlinger", mSurfaceFlinger);
+        ReflectionHelpers.setField(mController, "mConfigWrapper", mConfigWrapper);
+
+        when(mConfigWrapper.isScreenWideColorGamut()).thenReturn(true);
+
+        when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference);
+        when(mPreference.getKey()).thenReturn(mController.getPreferenceKey());
+    }
+
+    @Config(shadows = {SettingsShadowSystemProperties.class})
+    @Test
+    public void shouldCheckPreference() {
+        SettingsShadowSystemProperties.set(
+                ColorModePreferenceController.PERSISTENT_PROPERTY_SATURATION,
+                Float.toString(ColorModePreferenceController.COLOR_SATURATION_VIVID));
+
+        mController.updateState(mPreference);
+
+        verify(mPreference).setChecked(true);
+    }
+
+    @Config(shadows = {SettingsShadowSystemProperties.class})
+    @Test
+    public void shouldUncheckPreference() {
+        SettingsShadowSystemProperties.set(
+                ColorModePreferenceController.PERSISTENT_PROPERTY_SATURATION,
+                Float.toString(ColorModePreferenceController.COLOR_SATURATION_DEFAULT));
+
+        mController.updateState(mPreference);
+
+        verify(mPreference).setChecked(false);
+    }
+
+    @Config(shadows = {SettingsShadowSystemProperties.class})
+    @Test
+    public void shouldBoostSaturationOnCheck() {
+        mController.onPreferenceChange(mPreference, true);
+
+        String saturation = SettingsShadowSystemProperties
+                .get(ColorModePreferenceController.PERSISTENT_PROPERTY_SATURATION);
+        assertThat(saturation)
+                .isEqualTo(Float.toString(ColorModePreferenceController.COLOR_SATURATION_VIVID));
+    }
+
+    @Config(shadows = {SettingsShadowSystemProperties.class})
+    @Test
+    public void shouldResetSaturationOnUncheck() {
+        mController.onPreferenceChange(mPreference, false);
+
+        String saturation = SettingsShadowSystemProperties
+                .get(ColorModePreferenceController.PERSISTENT_PROPERTY_SATURATION);
+        assertThat(saturation)
+                .isEqualTo(Float.toString(ColorModePreferenceController.COLOR_SATURATION_DEFAULT));
+    }
+}

tests/robotests/src/com/android/settings/search/DatabaseIndexingManagerTest.java

@@ -258,7 +258,7 @@ public class DatabaseIndexingManagerTest {
         SearchIndexableResource resource = getFakeResource(R.xml.display_settings);
         mManager.indexOneSearchIndexableData(mDb, localeStr, resource, new HashMap<>());
         Cursor cursor = mDb.rawQuery("SELECT * FROM prefs_index", null);
-        assertThat(cursor.getCount()).isEqualTo(16);
+        assertThat(cursor.getCount()).isEqualTo(17);
     }
 
     @Test
@@ -273,7 +273,7 @@ public class DatabaseIndexingManagerTest {
         Cursor cursor = mDb.rawQuery("SELECT * FROM prefs_index WHERE enabled = 0", null);
         assertThat(cursor.getCount()).isEqualTo(2);
         cursor = mDb.rawQuery("SELECT * FROM prefs_index WHERE enabled = 1", null);
-        assertThat(cursor.getCount()).isEqualTo(14);
+        assertThat(cursor.getCount()).isEqualTo(15);
     }
 
     @Test