Merge "Add null check in displayPreference"
This commit is contained in:
committed by
Android (Google) Code Review
commit
4d142c992b
@@ -68,7 +68,10 @@ public class ZenModeStarredContactsPreferenceController extends
|
|||||||
public void displayPreference(PreferenceScreen screen) {
|
public void displayPreference(PreferenceScreen screen) {
|
||||||
super.displayPreference(screen);
|
super.displayPreference(screen);
|
||||||
mPreference = screen.findPreference(KEY);
|
mPreference = screen.findPreference(KEY);
|
||||||
mPreference.setOnPreferenceClickListener(this);
|
|
||||||
|
if (mPreference != null) {
|
||||||
|
mPreference.setOnPreferenceClickListener(this);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
@@ -190,4 +190,13 @@ public class ZenModeStarredContactsPreferenceControllerTest {
|
|||||||
assertThat(contacts.get(i)).isNotNull();
|
assertThat(contacts.get(i)).isNotNull();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void nullPreference_displayPreference() {
|
||||||
|
when(mPreferenceScreen.findPreference(mMessagesController.getPreferenceKey()))
|
||||||
|
.thenReturn(null);
|
||||||
|
|
||||||
|
// should not throw a null pointer
|
||||||
|
mMessagesController.displayPreference(mPreferenceScreen);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user