PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change the behavior of notifyAllowedNetworkTypesChanged.

Browse Source 
Bug: 180903931
Test: atest AllowedNetworkTypesListenerTest.java
Change-Id: Ic94816415920bf25896ef2b198e228f369039c94
This commit is contained in:
SongFerngWang
2021-03-02 22:04:10 +08:00
parent 0b29ebd420
commit 4ccbe5d785
2 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/com/android/settings/network/AllowedNetworkTypesListener.java
View File

@@ -24,7 +24,6 @@ import android.util.Log;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
import java.util.Map;
import java.util.concurrent.Executor; import java.util.concurrent.Executor;
@@ -72,9 +71,10 @@ public class AllowedNetworkTypesListener extends TelephonyCallback implements
} }
@Override @Override
public void onAllowedNetworkTypesChanged(Map<Integer, Long> allowedNetworkTypesList) { public void onAllowedNetworkTypesChanged(int reason, long newAllowedNetworkType) {
long newAllowedNetworkType = allowedNetworkTypesList.get( if (reason != TelephonyManager.ALLOWED_NETWORK_TYPES_REASON_USER) {
TelephonyManager.ALLOWED_NETWORK_TYPES_REASON_USER); return;
}
if (mListener != null && mAllowedNetworkType != newAllowedNetworkType) { if (mListener != null && mAllowedNetworkType != newAllowedNetworkType) {
mListener.onAllowedNetworkTypesChanged(); mListener.onAllowedNetworkTypesChanged();
Log.d(LOG_TAG, "onAllowedNetworkChanged: " + mAllowedNetworkType); Log.d(LOG_TAG, "onAllowedNetworkChanged: " + mAllowedNetworkType);

10
tests/unit/src/com/android/settings/network/AllowedNetworkTypesListenerTest.java
View File

@@ -40,9 +40,6 @@ import org.junit.runner.RunWith;
import org.mockito.Mock; import org.mockito.Mock;
import org.mockito.MockitoAnnotations; import org.mockito.MockitoAnnotations;
import java.util.HashMap;
import java.util.Map;
@RunWith(AndroidJUnit4.class) @RunWith(AndroidJUnit4.class)
public class AllowedNetworkTypesListenerTest { public class AllowedNetworkTypesListenerTest {
@@ -73,12 +70,11 @@ public class AllowedNetworkTypesListenerTest {
@Test @Test
public void onChange_shouldCallListener() { public void onChange_shouldCallListener() {
mAllowedNetworkTypesListener.mListener = mListener; mAllowedNetworkTypesListener.mListener = mListener;
Map<Integer, Long> allowedNetworkTypesList = new HashMap<>();
long networkType = (long) RadioAccessFamily.getRafFromNetworkType( long networkType = (long) RadioAccessFamily.getRafFromNetworkType(
TelephonyManager.NETWORK_MODE_LTE_CDMA_EVDO); TelephonyManager.NETWORK_MODE_LTE_CDMA_EVDO);
allowedNetworkTypesList.put(TelephonyManager.ALLOWED_NETWORK_TYPES_REASON_USER,
networkType); mAllowedNetworkTypesListener.onAllowedNetworkTypesChanged(
mAllowedNetworkTypesListener.onAllowedNetworkTypesChanged(allowedNetworkTypesList); TelephonyManager.ALLOWED_NETWORK_TYPES_REASON_USER, networkType);
verify(mListener).onAllowedNetworkTypesChanged(); verify(mListener).onAllowedNetworkTypesChanged();
} }