Merge "Makes call to MetricsLogger right away when taking bugreports." into nyc-dev

This commit is contained in:
Felipe Leme
2016-02-25 19:45:05 +00:00
committed by Android (Google) Code Review

View File

@@ -87,9 +87,13 @@ public class BugreportPreference extends CustomDialogPreference {
if (mFullTitle.isChecked()) { if (mFullTitle.isChecked()) {
Log.v(TAG, "Taking full bugreport right away"); Log.v(TAG, "Taking full bugreport right away");
MetricsLogger.action(getDialog().getContext(),
MetricsEvent.ACTION_BUGREPORT_FROM_SETTINGS_FULL);
takeBugreport(ActivityManager.BUGREPORT_OPTION_FULL); takeBugreport(ActivityManager.BUGREPORT_OPTION_FULL);
} else { } else {
Log.v(TAG, "Taking interactive bugreport in " + BUGREPORT_DELAY_SECONDS + "s"); Log.v(TAG, "Taking interactive bugreport in " + BUGREPORT_DELAY_SECONDS + "s");
MetricsLogger.action(getDialog().getContext(),
MetricsEvent.ACTION_BUGREPORT_FROM_SETTINGS_INTERACTIVE);
// Add a little delay before executing, to give the user a chance to close // Add a little delay before executing, to give the user a chance to close
// the Settings activity before it takes a screenshot. // the Settings activity before it takes a screenshot.
final Context context = getContext(); final Context context = getContext();
@@ -110,18 +114,6 @@ public class BugreportPreference extends CustomDialogPreference {
private void takeBugreport(int bugreportType) { private void takeBugreport(int bugreportType) {
try { try {
switch (bugreportType) {
case ActivityManager.BUGREPORT_OPTION_FULL:
MetricsLogger.action(getDialog().getContext(),
MetricsEvent.ACTION_BUGREPORT_FROM_SETTINGS_FULL);
break;
case ActivityManager.BUGREPORT_OPTION_INTERACTIVE:
MetricsLogger.action(getDialog().getContext(),
MetricsEvent.ACTION_BUGREPORT_FROM_SETTINGS_INTERACTIVE);
break;
default:
Log.w(TAG, "Unknown bugreportType: " + bugreportType);
}
ActivityManagerNative.getDefault().requestBugReport(bugreportType); ActivityManagerNative.getDefault().requestBugReport(bugreportType);
} catch (RemoteException e) { } catch (RemoteException e) {
Log.e(TAG, "error taking bugreport (bugreportType=" + bugreportType + ")", e); Log.e(TAG, "error taking bugreport (bugreportType=" + bugreportType + ")", e);