Add Icon at the start of the first row for all contextualcards
- set Icon as a title item rather than an end item in slice builders - call showTitleItems in renderer Test: robotest Bug: 119639527 Change-Id: I043173968ceb3d34e38c2e43ad824b923e647d47
This commit is contained in:
@@ -98,10 +98,10 @@ public class BatteryFixSlice implements CustomSliceable {
|
||||
ListBuilder.ICON_IMAGE,
|
||||
batteryTip.getTitle(mContext));
|
||||
sliceBuilder.addRow(new RowBuilder()
|
||||
.setTitleItem(icon, ListBuilder.ICON_IMAGE)
|
||||
.setTitle(batteryTip.getTitle(mContext))
|
||||
.setSubtitle(batteryTip.getSummary(mContext))
|
||||
.setPrimaryAction(primaryAction)
|
||||
.addEndItem(icon, ListBuilder.ICON_IMAGE));
|
||||
.setPrimaryAction(primaryAction));
|
||||
break;
|
||||
}
|
||||
}
|
||||
@@ -144,9 +144,9 @@ public class BatteryFixSlice implements CustomSliceable {
|
||||
final SliceAction primaryAction = SliceAction.createDeeplink(getPrimaryAction(), icon,
|
||||
ListBuilder.ICON_IMAGE, title);
|
||||
sliceBuilder.addRow(new RowBuilder()
|
||||
.setTitleItem(icon, ListBuilder.ICON_IMAGE)
|
||||
.setTitle(title)
|
||||
.setPrimaryAction(primaryAction)
|
||||
.addEndItem(icon, ListBuilder.ICON_IMAGE))
|
||||
.setPrimaryAction(primaryAction))
|
||||
.setIsError(isError);
|
||||
return sliceBuilder.build();
|
||||
}
|
||||
|
@@ -119,15 +119,10 @@ public class LowStorageSlice implements CustomSliceable {
|
||||
PendingIntent.getActivity(mContext, 0, getIntent(), 0), icon,
|
||||
ListBuilder.ICON_IMAGE, title);
|
||||
|
||||
/**
|
||||
* TODO(b/114808204): Contextual Home Page - "Low Storage"
|
||||
* Slices doesn't support "Icon on the left" in header. Now we intend to start with Icon
|
||||
* right aligned. Will update the icon to left until Slices support it.
|
||||
*/
|
||||
return new RowBuilder()
|
||||
.setTitleItem(icon, ListBuilder.ICON_IMAGE)
|
||||
.setTitle(title)
|
||||
.setSubtitle(summary)
|
||||
.addEndItem(icon, ListBuilder.ICON_IMAGE)
|
||||
.setPrimaryAction(primarySliceAction);
|
||||
}
|
||||
}
|
@@ -132,6 +132,7 @@ public class SliceContextualCardRenderer implements ContextualCardRenderer,
|
||||
cardHolder.sliceView.setOnSliceActionListener(this);
|
||||
|
||||
// Customize slice view for Settings
|
||||
cardHolder.sliceView.showTitleItems(true);
|
||||
if (card.isLargeCard()) {
|
||||
cardHolder.sliceView.showHeaderDivider(true);
|
||||
cardHolder.sliceView.showActionDividers(true);
|
||||
|
Reference in New Issue
Block a user