Index the System status page

- Page is found in System > About Phone > Status The page was simply never indexed. - Remove the unavailable summary text. - Suppress IP address because it appears in wifi settings as well. Test: make RunSettingsRoboTests Change-Id: I0c5eb5222fc356dd3686fb84ca47da8e2d3274f5 Fixes: 65443327
2017-09-08 14:05:15 -07:00
parent 6361c9d851
commit 4b0677a2a4
6 changed files with 135 additions and 10 deletions
--- a/tests/robotests/src/com/android/settings/wifi/ConfigureWifiSettingsTest.java
+++ b/tests/robotests/src/com/android/settings/wifi/ConfigureWifiSettingsTest.java
@@ -0,0 +1,83 @@
+package com.android.settings.wifi;
+
+import static com.google.common.truth.Truth.assertThat;
+
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.when;
+
+import android.content.Context;
+import android.net.ConnectivityManager;
+import android.net.NetworkInfo;
+import com.android.settings.TestConfig;
+import com.android.settings.testutils.SettingsRobolectricTestRunner;
+import com.android.settings.testutils.XmlTestUtils;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.robolectric.RuntimeEnvironment;
+import org.robolectric.annotation.Config;
+
+import java.util.List;
+
+@RunWith(SettingsRobolectricTestRunner.class)
+@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
+public class ConfigureWifiSettingsTest {
+
+    private Context mContext;
+
+    @Before
+    public void setUp() {
+        mContext = spy(RuntimeEnvironment.application);
+    }
+
+    @Test
+    public void testNonIndexableKeys_existInXmlLayout() {
+        final List<String> niks = ConfigureWifiSettings.SEARCH_INDEX_DATA_PROVIDER
+                .getNonIndexableKeys(mContext);
+        final int xmlId = new ConfigureWifiSettings().getPreferenceScreenResId();
+
+        final List<String> keys = XmlTestUtils.getKeysFromPreferenceXml(mContext, xmlId);
+
+        assertThat(keys).containsAllIn(niks);
+    }
+
+    @Test
+    public void testNonIndexableKeys_noConnection_blocksIP() {
+        ConnectivityManager manager = mock(ConnectivityManager.class);
+        when(manager.getActiveNetworkInfo()).thenReturn(null);
+        doReturn(manager).when(mContext).getSystemService(Context.CONNECTIVITY_SERVICE);
+
+        final List<String> niks = ConfigureWifiSettings.SEARCH_INDEX_DATA_PROVIDER
+                .getNonIndexableKeys(mContext);
+        assertThat(niks).contains(ConfigureWifiSettings.KEY_IP_ADDRESS);
+    }
+
+    @Test
+    public void testNonIndexableKeys_wifiConnection_blocksIP() {
+        ConnectivityManager manager = mock(ConnectivityManager.class);
+        NetworkInfo info = mock(NetworkInfo.class);
+        when(info.getType()).thenReturn(ConnectivityManager.TYPE_WIFI);
+        when(manager.getActiveNetworkInfo()).thenReturn(info);
+        doReturn(manager).when(mContext).getSystemService(Context.CONNECTIVITY_SERVICE);
+
+        final List<String> niks = ConfigureWifiSettings.SEARCH_INDEX_DATA_PROVIDER
+                .getNonIndexableKeys(mContext);
+        assertThat(niks).contains(ConfigureWifiSettings.KEY_IP_ADDRESS);
+    }
+
+    @Test
+    public void testNonIndexableKeys_mobileConnection_blocksIP() {
+        ConnectivityManager manager = mock(ConnectivityManager.class);
+        NetworkInfo info = mock(NetworkInfo.class);
+        when(info.getType()).thenReturn(ConnectivityManager.TYPE_MOBILE);
+        when(manager.getActiveNetworkInfo()).thenReturn(info);
+        doReturn(manager).when(mContext).getSystemService(Context.CONNECTIVITY_SERVICE);
+
+        final List<String> niks = ConfigureWifiSettings.SEARCH_INDEX_DATA_PROVIDER
+                .getNonIndexableKeys(mContext);
+        assertThat(niks).doesNotContain(ConfigureWifiSettings.KEY_IP_ADDRESS);
+    }
+}