PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix SummaryLoader lifecycle second and for all

Browse Source 
am: 9425839379

* commit '9425839379d862604d4b5a7b9161540f598f64f6':
  Fix SummaryLoader lifecycle second and for all
This commit is contained in:
Jason Monk
2016-03-08 18:26:08 +00:00
committed by android-build-merger
parent 704ea2ddef 9425839379
commit 4a93400a02
1 changed files with 26 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/com/android/settings/dashboard/SummaryLoader.java
View File

@@ -46,6 +46,7 @@ public class SummaryLoader {
private final HandlerThread mWorkerThread; private final HandlerThread mWorkerThread;
private DashboardAdapter mAdapter; private DashboardAdapter mAdapter;
private boolean mListening;
public SummaryLoader(Activity activity, List<DashboardCategory> categories) { public SummaryLoader(Activity activity, List<DashboardCategory> categories) {
mHandler = new Handler(); mHandler = new Handler();
@@ -64,6 +65,8 @@ public class SummaryLoader {
public void release() { public void release() {
mWorkerThread.quitSafely(); mWorkerThread.quitSafely();
// Make sure we aren't listening.
setListeningW(false);
} }
public void setAdapter(DashboardAdapter adapter) { public void setAdapter(DashboardAdapter adapter) {
@@ -122,6 +125,27 @@ public class SummaryLoader {
return tile.metaData; return tile.metaData;
} }
private synchronized void setListeningW(boolean listening) {
if (mListening == listening) return;
if (DEBUG) Log.d(TAG, "Listening " + listening);
for (SummaryProvider p : mSummaryMap.keySet()) {
p.setListening(listening);
}
mListening = listening;
}
private synchronized void makeProviderW(Tile tile) {
SummaryProvider provider = getSummaryProvider(tile);
if (provider != null) {
if (DEBUG) Log.d(TAG, "Creating " + tile);
mSummaryMap.put(provider, tile);
if (mListening) {
// If we are somehow already listening, put the provider in that state.
provider.setListening(true);
}
}
}
public interface SummaryProvider { public interface SummaryProvider {
void setListening(boolean listening); void setListening(boolean listening);
} }
@@ -143,18 +167,11 @@ public class SummaryLoader {
switch (msg.what) { switch (msg.what) {
case MSG_GET_PROVIDER: case MSG_GET_PROVIDER:
Tile tile = (Tile) msg.obj; Tile tile = (Tile) msg.obj;
SummaryProvider provider = getSummaryProvider(tile); makeProviderW(tile);
if (provider != null) {
if (DEBUG) Log.d(TAG, "Creating " + tile);
mSummaryMap.put(provider, tile);
}
break; break;
case MSG_SET_LISTENING: case MSG_SET_LISTENING:
boolean listening = msg.arg1 != 0; boolean listening = msg.arg1 != 0;
if (DEBUG) Log.d(TAG, "Listening " + listening); setListeningW(listening);
for (SummaryProvider p : mSummaryMap.keySet()) {
p.setListening(listening);
}
break; break;
} }
} }