PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add null pointer check to prevent crash

Browse Source 
Bug: 338082036
Test: atest EditShortcutsPreferenceFragmentTest
Flag: EXEMPT bugfix low risk
Change-Id: I70f00eb2912e4ddd6efbd298ae6b6885f28160de
This commit is contained in:
Chun-Ku Lin
2024-05-07 01:07:25 +00:00
parent 94291dfd2d
commit 4959e0fba0
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/com/android/settings/accessibility/shortcuts/EditShortcutsPreferenceFragment.java
View File

@@ -182,8 +182,10 @@ public class EditShortcutsPreferenceFragment extends DashboardFragment {
refreshPreferenceController(QuickSettingsShortcutOptionController.class); refreshPreferenceController(QuickSettingsShortcutOptionController.class);
} }
PreferredShortcuts.updatePreferredShortcutsFromSettings( if (getContext() != null) {
getContext(), mShortcutTargets); PreferredShortcuts.updatePreferredShortcutsFromSettings(
getContext(), mShortcutTargets);
}
} }
}; };
@@ -388,7 +390,7 @@ public class EditShortcutsPreferenceFragment extends DashboardFragment {
private void refreshPreferenceController( private void refreshPreferenceController(
Class<? extends AbstractPreferenceController> controllerClass) { Class<? extends AbstractPreferenceController> controllerClass) {
AbstractPreferenceController controller = use(controllerClass); AbstractPreferenceController controller = use(controllerClass);
if (controller != null) { if (controller != null && getPreferenceScreen() != null) {
controller.displayPreference(getPreferenceScreen()); controller.displayPreference(getPreferenceScreen());
if (!TextUtils.isEmpty(controller.getPreferenceKey())) { if (!TextUtils.isEmpty(controller.getPreferenceKey())) {
controller.updateState(findPreference(controller.getPreferenceKey())); controller.updateState(findPreference(controller.getPreferenceKey()));