Merge "[Settings] Code refactor"
This commit is contained in:
@@ -96,7 +96,7 @@ public class BillingCyclePreference extends Preference
|
||||
}
|
||||
|
||||
/**
|
||||
* Implementation of MobileDataEnabledListener.Client
|
||||
* Implementation of {@code MobileDataEnabledListener.Client}
|
||||
*/
|
||||
public void onMobileDataEnabledChange() {
|
||||
updateEnabled();
|
||||
|
||||
@@ -240,7 +240,7 @@ public class CellDataPreference extends CustomDialogPreferenceCompat
|
||||
};
|
||||
|
||||
/**
|
||||
* Implementation of MobileDataEnabledListener.Client
|
||||
* Implementation of {@code MobileDataEnabledListener.Client}
|
||||
*/
|
||||
@VisibleForTesting
|
||||
public void onMobileDataEnabledChange() {
|
||||
|
||||
@@ -201,7 +201,6 @@ public class DataUsageList extends DataUsageBaseFragment
|
||||
public void onDestroy() {
|
||||
mUidDetailProvider.clearCache();
|
||||
mUidDetailProvider = null;
|
||||
mDataStateListener.stop();
|
||||
|
||||
super.onDestroy();
|
||||
}
|
||||
@@ -232,7 +231,7 @@ public class DataUsageList extends DataUsageBaseFragment
|
||||
}
|
||||
|
||||
/**
|
||||
* Implementation of MobileDataEnabledListener.Client
|
||||
* Implementation of {@code MobileDataEnabledListener.Client}
|
||||
*/
|
||||
public void onMobileDataEnabledChange() {
|
||||
updatePolicy();
|
||||
|
||||
@@ -78,7 +78,7 @@ public class DataUsageSummary extends DataUsageBaseFragment implements DataUsage
|
||||
super.onCreate(icicle);
|
||||
Context context = getContext();
|
||||
|
||||
// enable ProxySubscriptionMgr with Lifecycle support for all controllers
|
||||
// Enable ProxySubscriptionMgr with Lifecycle support for all controllers
|
||||
// live within this fragment
|
||||
mProxySubscriptionMgr = ProxySubscriptionManager.getInstance(context);
|
||||
mProxySubscriptionMgr.setLifecycle(getLifecycle());
|
||||
|
||||
@@ -25,12 +25,12 @@ public class MobileDataEnabledListener {
|
||||
private Context mContext;
|
||||
private Client mClient;
|
||||
private int mSubId;
|
||||
/**
|
||||
* There're 2 listeners both activated at the same time.
|
||||
* For project that access MOBILE_DATA, only first listener is functional.
|
||||
* For project that access "MOBILE_DATA + subId", first listener will be stopped when receiving
|
||||
* any onChange from second listener.
|
||||
*/
|
||||
|
||||
// There're 2 listeners both activated at the same time.
|
||||
// For project that access MOBILE_DATA, only first listener is functional.
|
||||
// For project that access "MOBILE_DATA + subId", first listener will be stopped when receiving
|
||||
// any onChange from second listener.
|
||||
|
||||
private GlobalSettingsChangeListener mListener;
|
||||
private GlobalSettingsChangeListener mListenerForSubId;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user