Add compatibility change preference

Add UI for modifying the compatibility change overrides per-app.

Test: make RunSettingsRoboTests ROBOTEST_FILTER=PlatformCompatDashboardTest
Bug: 138280620
Change-Id: I07c7602e7a439e47b0b1fa59b047231afbbc0ab6
This commit is contained in:
Andrei Onea
2019-09-26 14:44:49 +01:00
parent 60bd816476
commit 486fd49e87
7 changed files with 496 additions and 0 deletions

View File

@@ -0,0 +1,176 @@
/*
* Copyright 2019 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.development.compat;
import static com.google.common.truth.Truth.assertThat;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.when;
import android.compat.Compatibility.ChangeConfig;
import android.content.Context;
import android.content.pm.ApplicationInfo;
import android.content.pm.PackageManager.NameNotFoundException;
import android.graphics.drawable.Drawable;
import android.os.RemoteException;
import androidx.preference.Preference;
import androidx.preference.PreferenceCategory;
import androidx.preference.PreferenceManager;
import androidx.preference.PreferenceScreen;
import androidx.preference.SwitchPreference;
import com.android.internal.compat.CompatibilityChangeConfig;
import com.android.internal.compat.CompatibilityChangeInfo;
import com.android.internal.compat.IPlatformCompat;
import com.android.settings.R;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
@RunWith(RobolectricTestRunner.class)
public class PlatformCompatDashboardTest {
private PlatformCompatDashboard mDashboard;
@Mock
private IPlatformCompat mPlatformCompat;
private PreferenceScreen mPreferenceScreen;
@Mock
private ApplicationInfo mApplicationInfo;
@Mock
private PreferenceManager mPreferenceManager;
private Context mContext;
private CompatibilityChangeInfo[] mChanges;
private static final String APP_NAME = "foo.bar.baz";
@Before
public void setUp() throws RemoteException, NameNotFoundException {
MockitoAnnotations.initMocks(this);
mChanges = new CompatibilityChangeInfo[5];
mChanges[0] = new CompatibilityChangeInfo(1L, "Default_Enabled", 0, false);
mChanges[1] = new CompatibilityChangeInfo(2L, "Default_Disabled", 0, true);
mChanges[2] = new CompatibilityChangeInfo(3L, "Enabled_After_SDK_1_1", 1, false);
mChanges[3] = new CompatibilityChangeInfo(4L, "Enabled_After_SDK_1_2", 1, false);
mChanges[4] = new CompatibilityChangeInfo(5L, "Enabled_After_SDK_2", 2, false);
when(mPlatformCompat.listAllChanges()).thenReturn(mChanges);
mContext = RuntimeEnvironment.application;
mPreferenceManager = new PreferenceManager(mContext);
mPreferenceScreen = mPreferenceManager.createPreferenceScreen(mContext);
mApplicationInfo.packageName = APP_NAME;
mDashboard = spy(new PlatformCompatDashboard());
mDashboard.mSelectedApp = APP_NAME;
doReturn(mApplicationInfo).when(mDashboard).getApplicationInfo();
doReturn(mPlatformCompat).when(mDashboard).getPlatformCompat();
doReturn(mPreferenceScreen).when(mDashboard).getPreferenceScreen();
doReturn(mPreferenceManager).when(mDashboard).getPreferenceManager();
}
@Test
public void getHelpResource_shouldNotHaveHelpResource() {
assertThat(mDashboard.getHelpResource()).isEqualTo(0);
}
@Test
public void getPreferenceScreenResId_shouldBePlatformCompatSettingsResId() {
assertThat(mDashboard.getPreferenceScreenResId())
.isEqualTo(R.xml.platform_compat_settings);
}
@Test
public void createAppPreference_targetSdkEquals1_summaryReturnsAppNameAndTargetSdk() {
mApplicationInfo.targetSdkVersion = 1;
Preference appPreference = mDashboard.createAppPreference(any(Drawable.class));
assertThat(appPreference.getSummary()).isEqualTo(APP_NAME + " SDK 1");
}
@Test
public void createPreferenceForChange_defaultEnabledChange_createCheckedEntry() {
CompatibilityChangeInfo enabledChange = mChanges[0];
CompatibilityChangeConfig config = new CompatibilityChangeConfig(
new ChangeConfig(new HashSet<Long>(Arrays.asList(enabledChange.getId())),
new HashSet<Long>()));
Preference enabledPreference = mDashboard.createPreferenceForChange(mContext, enabledChange,
config);
SwitchPreference enabledSwitchPreference = (SwitchPreference) enabledPreference;
assertThat(enabledPreference.getSummary()).isEqualTo(mChanges[0].getName());
assertThat(enabledPreference instanceof SwitchPreference).isTrue();
assertThat(enabledSwitchPreference.isChecked()).isTrue();
}
@Test
public void createPreferenceForChange_defaultDisabledChange_createUncheckedEntry() {
CompatibilityChangeInfo disabledChange = mChanges[1];
CompatibilityChangeConfig config = new CompatibilityChangeConfig(
new ChangeConfig(new HashSet<Long>(),
new HashSet<Long>(Arrays.asList(disabledChange.getId()))));
Preference disabledPreference = mDashboard.createPreferenceForChange(mContext,
disabledChange, config);
assertThat(disabledPreference.getSummary()).isEqualTo(mChanges[1].getName());
SwitchPreference disabledSwitchPreference = (SwitchPreference) disabledPreference;
assertThat(disabledSwitchPreference.isChecked()).isFalse();
}
@Test
public void createChangeCategoryPreference_enabledAndDisabled_hasTitleAndEntries() {
Set<Long> enabledChanges = new HashSet<>();
enabledChanges.add(mChanges[0].getId());
enabledChanges.add(mChanges[1].getId());
enabledChanges.add(mChanges[2].getId());
Set<Long> disabledChanges = new HashSet<>();
disabledChanges.add(mChanges[3].getId());
disabledChanges.add(mChanges[4].getId());
CompatibilityChangeConfig config = new CompatibilityChangeConfig(
new ChangeConfig(enabledChanges, disabledChanges));
List<CompatibilityChangeInfo> changesToAdd = new ArrayList<>();
for (int i = 0; i < mChanges.length; ++i) {
changesToAdd.add(new CompatibilityChangeInfo(mChanges[i].getId(), mChanges[i]
.getName(),
mChanges[i].getEnableAfterTargetSdk(), mChanges[i].getDisabled()));
}
PreferenceCategory category = mDashboard.createChangeCategoryPreference(changesToAdd,
config, "foo");
assertThat(category.getTitle()).isEqualTo("foo");
assertThat(category.getPreferenceCount()).isEqualTo(mChanges.length);
for (int i = 0; i < mChanges.length; ++i) {
Preference childPreference = category.getPreference(i);
assertThat(childPreference instanceof SwitchPreference).isTrue();
}
}
}