From c93fe0b5090f7c0077eae45c018ec5faa2e3cd10 Mon Sep 17 00:00:00 2001 From: Zaiyue Xue Date: Mon, 10 Jul 2023 15:05:41 +0800 Subject: [PATCH] Fix testUidCache_switchLocale_shouldCleanCache in BatteryEntryTest Remove unused code and test Bug: 290318160 Fix: 290318160 Test: presubmit Change-Id: I20c612270c67f55e0b01fa849514ba670b696db3 --- .../fuelgauge/batteryusage/BatteryEntry.java | 27 ------------------- .../batteryusage/BatteryEntryTest.java | 13 --------- 2 files changed, 40 deletions(-) diff --git a/src/com/android/settings/fuelgauge/batteryusage/BatteryEntry.java b/src/com/android/settings/fuelgauge/batteryusage/BatteryEntry.java index 7f86b7cf192..86538ee8811 100644 --- a/src/com/android/settings/fuelgauge/batteryusage/BatteryEntry.java +++ b/src/com/android/settings/fuelgauge/batteryusage/BatteryEntry.java @@ -252,33 +252,6 @@ public class BatteryEntry { return mPowerComponentId; } - void getQuickNameIconForUid( - final int uid, final String[] packages, final boolean loadDataInBackground) { - // Locale sync to system config in Settings - final Locale locale = Locale.getDefault(); - if (sCurrentLocale != locale) { - clearUidCache(); - sCurrentLocale = locale; - } - - final String uidString = Integer.toString(uid); - if (sUidCache.containsKey(uidString)) { - UidToDetail utd = sUidCache.get(uidString); - mDefaultPackageName = utd.mPackageName; - mName = utd.mName; - mIcon = utd.mIcon; - return; - } - - if (packages == null || packages.length == 0) { - final NameAndIcon nameAndIcon = getNameAndIconFromUid(mContext, mName, uid); - mIcon = nameAndIcon.mIcon; - mName = nameAndIcon.mName; - } else { - mIcon = mContext.getPackageManager().getDefaultActivityIcon(); - } - } - /** Loads the app label and icon image and stores into the cache. */ public static NameAndIcon loadNameAndIcon( Context context, diff --git a/tests/robotests/src/com/android/settings/fuelgauge/batteryusage/BatteryEntryTest.java b/tests/robotests/src/com/android/settings/fuelgauge/batteryusage/BatteryEntryTest.java index dec5d7d3345..8c696134131 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/batteryusage/BatteryEntryTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/batteryusage/BatteryEntryTest.java @@ -50,8 +50,6 @@ import org.mockito.junit.MockitoRule; import org.robolectric.RobolectricTestRunner; import org.robolectric.RuntimeEnvironment; -import java.util.Locale; - @RunWith(RobolectricTestRunner.class) public class BatteryEntryTest { @@ -232,17 +230,6 @@ public class BatteryEntryTest { assertThat(entry.getTimeInBackgroundMs()).isEqualTo(0); } - @Test - public void testUidCache_switchLocale_shouldCleanCache() { - Locale.setDefault(new Locale("en_US")); - BatteryEntry.sUidCache.put(Integer.toString(APP_UID), null); - assertThat(BatteryEntry.sUidCache).isNotEmpty(); - - Locale.setDefault(new Locale("zh_TW")); - createBatteryEntryForApp(null, null, HIGH_DRAIN_PACKAGE); - assertThat(BatteryEntry.sUidCache).isEmpty(); // check if cache is clear - } - @Test public void getKey_UidBatteryConsumer() { final BatteryEntry entry = createBatteryEntryForApp(null, null, null);