From e767d2ea97ef67dca22bdd3e0a18c47299923960 Mon Sep 17 00:00:00 2001 From: Fabrice Di Meglio Date: Tue, 17 Jun 2014 19:07:53 -0700 Subject: [PATCH] Fix Language & Input Settings layouts padding - make padding consistent with the rest of the Settings App See bug: #15384992 Setting Dashboard - padding updates Change-Id: I9aab93e6b18d0fa966e79e93a334b339fa2ca20a --- res/layout/preference_inputmethod.xml | 12 ++++++++++++ .../CheckBoxAndSettingsPreference.java | 16 +++++++++++++++- .../inputmethod/SpellCheckersPreference.java | 18 ++++++++++++++++-- 3 files changed, 43 insertions(+), 3 deletions(-) diff --git a/res/layout/preference_inputmethod.xml b/res/layout/preference_inputmethod.xml index 589ddc9835b..d0d23e31341 100644 --- a/res/layout/preference_inputmethod.xml +++ b/res/layout/preference_inputmethod.xml @@ -18,8 +18,11 @@ xmlns:android="http://schemas.android.com/apk/res/android" android:layout_width="match_parent" android:layout_height="wrap_content" + android:paddingStart="?android:attr/listPreferredItemPaddingStart" + android:paddingEnd="?android:attr/listPreferredItemPaddingEnd" android:minHeight="?android:attr/listPreferredItemHeight" android:gravity="center_vertical"> + + + + + + + + + + diff --git a/src/com/android/settings/inputmethod/CheckBoxAndSettingsPreference.java b/src/com/android/settings/inputmethod/CheckBoxAndSettingsPreference.java index f440bc842c0..375bee785f5 100644 --- a/src/com/android/settings/inputmethod/CheckBoxAndSettingsPreference.java +++ b/src/com/android/settings/inputmethod/CheckBoxAndSettingsPreference.java @@ -37,8 +37,22 @@ public class CheckBoxAndSettingsPreference extends CheckBoxPreference { private ImageView mSettingsButton; private Intent mSettingsIntent; + public CheckBoxAndSettingsPreference(Context context) { + this(context, null); + } + public CheckBoxAndSettingsPreference(Context context, AttributeSet attrs) { - super(context, attrs); + this(context, attrs, 0); + } + + public CheckBoxAndSettingsPreference(Context context, AttributeSet attrs, int defStyleAttr) { + this(context, attrs, defStyleAttr, 0); + } + + public CheckBoxAndSettingsPreference(Context context, AttributeSet attrs, int defStyleAttr, + int defStyleRes) { + super(context, attrs, defStyleAttr, defStyleRes); + setLayoutResource(R.layout.preference_inputmethod); setWidgetLayoutResource(R.layout.preference_inputmethod_widget); } diff --git a/src/com/android/settings/inputmethod/SpellCheckersPreference.java b/src/com/android/settings/inputmethod/SpellCheckersPreference.java index 5e4ebba1518..9e6860491c1 100644 --- a/src/com/android/settings/inputmethod/SpellCheckersPreference.java +++ b/src/com/android/settings/inputmethod/SpellCheckersPreference.java @@ -21,10 +21,24 @@ import android.util.AttributeSet; import android.view.textservice.TextServicesManager; public class SpellCheckersPreference extends CheckBoxAndSettingsPreference { - private final TextServicesManager mTsm; + private TextServicesManager mTsm; + + public SpellCheckersPreference(Context context) { + this(context, null); + } public SpellCheckersPreference(Context context, AttributeSet attrs) { - super(context, attrs); + this(context, attrs, 0); + } + + public SpellCheckersPreference(Context context, AttributeSet attrs, int defStyleAttr) { + this(context, attrs, defStyleAttr, 0); + } + + public SpellCheckersPreference(Context context, AttributeSet attrs, int defStyleAttr, + int defStyleRes) { + super(context, attrs, defStyleAttr, defStyleRes); + mTsm = (TextServicesManager) context.getSystemService( Context.TEXT_SERVICES_MANAGER_SERVICE); setChecked(mTsm.isSpellCheckerEnabled());