From 46cf90af0e2be00d3490508c4fb8c4ed15180a6c Mon Sep 17 00:00:00 2001 From: Mill Chen Date: Thu, 18 Feb 2021 23:29:21 +0800 Subject: [PATCH] Remove search and help menu items from toolbar Based on the Settings UI guideline, both of search and help menu items will be removed from toolbar on Android S. Bug: 179332520 Test: visual verified 1) Settings -> System -> Gestures -> System navigation 2) Observe the toolbar and check if search and help icons are existing Change-Id: I3d71eddffb8876f936cf56858d0604aba7d4ee4b --- .../gestures/SystemNavigationGestureSettings.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/gestures/SystemNavigationGestureSettings.java b/src/com/android/settings/gestures/SystemNavigationGestureSettings.java index ddcdd59d3ac..14fe6a664be 100644 --- a/src/com/android/settings/gestures/SystemNavigationGestureSettings.java +++ b/src/com/android/settings/gestures/SystemNavigationGestureSettings.java @@ -31,6 +31,7 @@ import android.os.RemoteException; import android.os.ServiceManager; import android.provider.Settings; import android.text.TextUtils; +import android.util.FeatureFlagUtils; import android.view.accessibility.AccessibilityManager; import androidx.annotation.VisibleForTesting; @@ -38,6 +39,7 @@ import androidx.preference.PreferenceScreen; import com.android.settings.R; import com.android.settings.SettingsTutorialDialogWrapperActivity; +import com.android.settings.core.FeatureFlags; import com.android.settings.dashboard.suggestions.SuggestionFeatureProvider; import com.android.settings.overlay.FeatureFactory; import com.android.settings.search.BaseSearchIndexProvider; @@ -77,8 +79,11 @@ public class SystemNavigationGestureSettings extends RadioButtonPickerFragment i @Override public void onAttach(Context context) { super.onAttach(context); - SearchMenuController.init(this /* host */); - HelpMenuController.init(this /* host */); + // TODO(b/176883483): Remove both search and help menu if this feature rolled out + if (!FeatureFlagUtils.isEnabled(getContext(), FeatureFlags.SILKY_HOME)) { + SearchMenuController.init(this /* host */); + HelpMenuController.init(this /* host */); + } SuggestionFeatureProvider suggestionFeatureProvider = FeatureFactory.getFactory(context) .getSuggestionFeatureProvider(context);