From 797dd7440d4af1764279f479e7cca2a1bebad38e Mon Sep 17 00:00:00 2001 From: Doris Ling Date: Fri, 26 Aug 2016 11:13:21 -0700 Subject: [PATCH] Fix NullPointerException in DashboardSummary. In onSaveInstanceState(), move saving the suggestions logging lists to the top so that it will be saved to the bundle even when layout manager is null. Test: run monkey Change-Id: I248563a255158feadeb85898a920af96a1565fa9 Fixes:31111795 --- src/com/android/settings/dashboard/DashboardSummary.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/dashboard/DashboardSummary.java b/src/com/android/settings/dashboard/DashboardSummary.java index e0f727fc14c..4a9f2c5b90b 100644 --- a/src/com/android/settings/dashboard/DashboardSummary.java +++ b/src/com/android/settings/dashboard/DashboardSummary.java @@ -178,13 +178,13 @@ public class DashboardSummary extends InstrumentedFragment @Override public void onSaveInstanceState(Bundle outState) { super.onSaveInstanceState(outState); + outState.putStringArrayList(EXTRA_SUGGESTION_HIDDEN_LOGGED, mSuggestionsHiddenLogged); + outState.putStringArrayList(EXTRA_SUGGESTION_SHOWN_LOGGED, mSuggestionsShownLogged); if (mLayoutManager == null) return; outState.putInt(EXTRA_SCROLL_POSITION, mLayoutManager.findFirstVisibleItemPosition()); if (mAdapter != null) { mAdapter.onSaveInstanceState(outState); } - outState.putStringArrayList(EXTRA_SUGGESTION_HIDDEN_LOGGED, mSuggestionsHiddenLogged); - outState.putStringArrayList(EXTRA_SUGGESTION_SHOWN_LOGGED, mSuggestionsShownLogged); } @Override