Merge changes Ibf8f546c,I172f336a into main

* changes:
  [Catalyst] Ring volume migration (1/n)
  [Catalyst] Media volume migration
This commit is contained in:
Treehugger Robot
2024-10-31 15:47:02 +00:00
committed by Android (Google) Code Review
10 changed files with 568 additions and 0 deletions

View File

@@ -58,6 +58,7 @@ import org.robolectric.annotation.Config;
import org.robolectric.annotation.Implementation;
import org.robolectric.annotation.Implements;
// LINT.IfChange
@RunWith(RobolectricTestRunner.class)
@Config(shadows = MediaVolumePreferenceControllerTest.ShadowSliceBackgroundWorker.class)
public class MediaVolumePreferenceControllerTest {
@@ -269,3 +270,4 @@ public class MediaVolumePreferenceControllerTest {
PendingIntent.FLAG_UPDATE_CURRENT | PendingIntent.FLAG_IMMUTABLE);
}
}
// LINT.ThenChange(MediaVolumePreference.kt)

View File

@@ -0,0 +1,56 @@
/*
* Copyright (C) 2024 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.notification
import android.content.ContextWrapper
import android.content.res.Resources
import androidx.test.core.app.ApplicationProvider
import androidx.test.ext.junit.runners.AndroidJUnit4
import com.google.common.truth.Truth.assertThat
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.ArgumentMatchers.anyInt
import org.mockito.kotlin.doReturn
import org.mockito.kotlin.mock
import org.mockito.kotlin.stub
// LINT.IfChange
@RunWith(AndroidJUnit4::class)
class MediaVolumePreferenceTest {
private val mockResources = mock<Resources>()
private val mediaVolumePreference = MediaVolumePreference()
private val context =
object : ContextWrapper(ApplicationProvider.getApplicationContext()) {
override fun getResources(): Resources = mockResources
}
@Test
fun isAvailable_configTrue_shouldReturnTrue() {
mockResources.stub { on { getBoolean(anyInt()) } doReturn true }
assertThat(mediaVolumePreference.isAvailable(context)).isTrue()
}
@Test
fun isAvailable_configFalse_shouldReturnFalse() {
mockResources.stub { on { getBoolean(anyInt()) } doReturn false }
assertThat(mediaVolumePreference.isAvailable(context)).isFalse()
}
}
// LINT.ThenChange(MediaVolumePreferenceControllerTest.java)

View File

@@ -41,6 +41,7 @@ import org.robolectric.RuntimeEnvironment;
import org.robolectric.annotation.Config;
import org.robolectric.shadows.ShadowApplication;
// LINT.IfChange
@RunWith(RobolectricTestRunner.class)
@Config(shadows = {ShadowDeviceConfig.class})
public class SeparateRingVolumePreferenceControllerTest {
@@ -108,3 +109,4 @@ public class SeparateRingVolumePreferenceControllerTest {
}
}
// LINT.ThenChange(SeparateRingVolumePreferenceTest.kt)

View File

@@ -0,0 +1,150 @@
/*
* Copyright (C) 2024 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.notification
import android.content.ContextWrapper
import android.media.AudioManager.RINGER_MODE_NORMAL
import android.media.AudioManager.RINGER_MODE_SILENT
import android.media.AudioManager.RINGER_MODE_VIBRATE
import android.os.Vibrator
import androidx.test.core.app.ApplicationProvider
import androidx.test.ext.junit.runners.AndroidJUnit4
import com.android.settings.R
import com.google.common.truth.Truth.assertThat
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.kotlin.doReturn
import org.mockito.kotlin.mock
import org.mockito.kotlin.spy
import org.mockito.kotlin.stub
// LINT.IfChange
@RunWith(AndroidJUnit4::class)
class SeparateRingVolumePreferenceTest {
private var audioHelper = mock<AudioHelper>()
private var vibrator: Vibrator? = null
private var ringVolumePreference = SeparateRingVolumePreference()
private val context =
object : ContextWrapper(ApplicationProvider.getApplicationContext()) {
override fun getSystemService(name: String): Any? =
when {
name == getSystemServiceName(Vibrator::class.java) -> vibrator
else -> super.getSystemService(name)
}
}
@Test
fun isAvailable_singleVolume_shouldReturnFalse() {
audioHelper = mock { on { isSingleVolume } doReturn true }
ringVolumePreference =
spy(ringVolumePreference).stub {
onGeneric { createAudioHelper(context) } doReturn audioHelper
}
assertThat(ringVolumePreference.isAvailable(context)).isFalse()
}
@Test
fun isAvailable_noSingleVolume_shouldReturnTrue() {
audioHelper = mock { on { isSingleVolume } doReturn false }
ringVolumePreference =
spy(ringVolumePreference).stub {
onGeneric { createAudioHelper(context) } doReturn audioHelper
}
assertThat(ringVolumePreference.isAvailable(context)).isTrue()
}
@Test
fun getEffectiveRingerMode_noVibratorAndVibrateMode_shouldReturnSilentMode() {
vibrator = mock { on { hasVibrator() } doReturn false }
audioHelper = mock { on { ringerModeInternal } doReturn RINGER_MODE_VIBRATE }
ringVolumePreference =
spy(ringVolumePreference).stub {
onGeneric { createAudioHelper(context) } doReturn audioHelper
}
assertThat(ringVolumePreference.getEffectiveRingerMode(context))
.isEqualTo(RINGER_MODE_SILENT)
}
@Test
fun getEffectiveRingerMode_hasVibratorAndVibrateMode_shouldReturnVibrateMode() {
vibrator = mock { on { hasVibrator() } doReturn true }
audioHelper = mock { on { ringerModeInternal } doReturn RINGER_MODE_VIBRATE }
ringVolumePreference =
spy(ringVolumePreference).stub {
onGeneric { createAudioHelper(context) } doReturn audioHelper
}
assertThat(ringVolumePreference.getEffectiveRingerMode(context))
.isEqualTo(RINGER_MODE_VIBRATE)
}
@Test
fun getEffectiveRingerMode_hasVibratorAndNormalMode_shouldReturnNormalMode() {
vibrator = mock { on { hasVibrator() } doReturn true }
audioHelper = mock { on { ringerModeInternal } doReturn RINGER_MODE_NORMAL }
ringVolumePreference =
spy(ringVolumePreference).stub {
onGeneric { createAudioHelper(context) } doReturn audioHelper
}
assertThat(ringVolumePreference.getEffectiveRingerMode(context))
.isEqualTo(RINGER_MODE_NORMAL)
}
@Test
fun getMuteIcon_normalMode_shouldReturnRingVolumeIcon() {
vibrator = mock { on { hasVibrator() } doReturn true }
audioHelper = mock { on { ringerModeInternal } doReturn RINGER_MODE_NORMAL }
ringVolumePreference =
spy(ringVolumePreference).stub {
onGeneric { createAudioHelper(context) } doReturn audioHelper
}
assertThat(ringVolumePreference.getMuteIcon(context)).isEqualTo(R.drawable.ic_ring_volume)
}
@Test
fun getMuteIcon_vibrateMode_shouldReturnVibrateIcon() {
vibrator = mock { on { hasVibrator() } doReturn true }
audioHelper = mock { on { ringerModeInternal } doReturn RINGER_MODE_VIBRATE }
ringVolumePreference =
spy(ringVolumePreference).stub {
onGeneric { createAudioHelper(context) } doReturn audioHelper
}
assertThat(ringVolumePreference.getMuteIcon(context))
.isEqualTo(R.drawable.ic_volume_ringer_vibrate)
}
@Test
fun getMuteIcon_silentMode_shouldReturnSilentIcon() {
vibrator = mock { on { hasVibrator() } doReturn false }
audioHelper = mock { on { ringerModeInternal } doReturn RINGER_MODE_VIBRATE }
ringVolumePreference =
spy(ringVolumePreference).stub {
onGeneric { createAudioHelper(context) } doReturn audioHelper
}
assertThat(ringVolumePreference.getMuteIcon(context))
.isEqualTo(R.drawable.ic_ring_volume_off)
}
}
// LINT.ThenChange(SeparateRingVolumePreferenceControllerTest.java)