From 25d259e3e290a564976a55c0bce957551180085e Mon Sep 17 00:00:00 2001 From: Weng Su Date: Fri, 26 May 2023 21:17:02 +0800 Subject: [PATCH 01/10] Restrict SimDialogActivity - Restrict UI if user is a guest - Restrict UI if user has DISALLOW_CONFIG_MOBILE_NETWORKS Bug: 262242946 Bug: 271849181 Test: manual test atest -c SimDialogActivityTest Change-Id: I227400aa71880895d8356f3d2961cb610ad2a357 --- .../settings/sim/SimDialogActivity.java | 16 +++- .../settings/sim/SimDialogActivityTest.java | 87 +++++++++++++++++++ 2 files changed, 102 insertions(+), 1 deletion(-) create mode 100644 tests/unit/src/com/android/settings/sim/SimDialogActivityTest.java diff --git a/src/com/android/settings/sim/SimDialogActivity.java b/src/com/android/settings/sim/SimDialogActivity.java index dcfa9832458..7d399387191 100644 --- a/src/com/android/settings/sim/SimDialogActivity.java +++ b/src/com/android/settings/sim/SimDialogActivity.java @@ -39,10 +39,12 @@ import androidx.fragment.app.Fragment; import androidx.fragment.app.FragmentActivity; import androidx.fragment.app.FragmentManager; +import com.android.internal.annotations.VisibleForTesting; import com.android.settings.R; import com.android.settings.network.CarrierConfigCache; import com.android.settings.network.SubscriptionUtil; import com.android.settings.network.ims.WifiCallingQueryImsState; +import com.android.settings.network.telephony.MobileNetworkUtils; import com.android.settings.network.telephony.SubscriptionActionDialogActivity; import com.android.settings.overlay.FeatureFactory; import com.android.settingslib.core.instrumentation.MetricsFeatureProvider; @@ -77,7 +79,10 @@ public class SimDialogActivity extends FragmentActivity { @Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); - + if (isUiRestricted()) { + finish(); + return; + } if (!SubscriptionUtil.isSimHardwareVisible(this)) { Log.d(TAG, "Not support on device without SIM."); finish(); @@ -91,6 +96,15 @@ public class SimDialogActivity extends FragmentActivity { showOrUpdateDialog(); } + @VisibleForTesting + boolean isUiRestricted() { + if (MobileNetworkUtils.isMobileNetworkUserRestricted(getApplicationContext())) { + Log.e(TAG, "This setting isn't available due to user restriction."); + return true; + } + return false; + } + @Override protected void onNewIntent(Intent intent) { super.onNewIntent(intent); diff --git a/tests/unit/src/com/android/settings/sim/SimDialogActivityTest.java b/tests/unit/src/com/android/settings/sim/SimDialogActivityTest.java new file mode 100644 index 00000000000..a2320341c62 --- /dev/null +++ b/tests/unit/src/com/android/settings/sim/SimDialogActivityTest.java @@ -0,0 +1,87 @@ +/* + * Copyright (C) 2023 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.sim; + +import static android.os.UserManager.DISALLOW_CONFIG_MOBILE_NETWORKS; + +import static com.google.common.truth.Truth.assertThat; + +import static org.mockito.Mockito.when; + +import android.content.Context; +import android.os.UserManager; + +import androidx.test.annotation.UiThreadTest; +import androidx.test.core.app.ApplicationProvider; +import androidx.test.ext.junit.runners.AndroidJUnit4; + +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Mock; +import org.mockito.Spy; +import org.mockito.junit.MockitoJUnit; +import org.mockito.junit.MockitoRule; + +@RunWith(AndroidJUnit4.class) +@UiThreadTest +public class SimDialogActivityTest { + @Rule + public final MockitoRule mMockitoRule = MockitoJUnit.rule(); + @Spy + private final Context mContext = ApplicationProvider.getApplicationContext(); + @Mock + private UserManager mUserManager; + + private MockSimDialogActivity mActivity; + + @Before + public void setUp() { + when(mContext.getSystemService(UserManager.class)).thenReturn(mUserManager); + when(mUserManager.isGuestUser()).thenReturn(false); + when(mUserManager.hasUserRestriction(DISALLOW_CONFIG_MOBILE_NETWORKS)).thenReturn(false); + + mActivity = new MockSimDialogActivity(); + } + + @Test + public void isUiRestricted_normally_returnFalse() { + assertThat(mActivity.isUiRestricted()).isFalse(); + } + + @Test + public void isUiRestricted_isGuestUser_returnTrue() { + when(mUserManager.isGuestUser()).thenReturn(true); + + assertThat(mActivity.isUiRestricted()).isTrue(); + } + + @Test + public void isUiRestricted_hasUserRestriction_returnTrue() { + when(mUserManager.hasUserRestriction(DISALLOW_CONFIG_MOBILE_NETWORKS)).thenReturn(true); + + assertThat(mActivity.isUiRestricted()).isTrue(); + } + + public class MockSimDialogActivity extends SimDialogActivity { + @Override + public Context getApplicationContext() { + return mContext; + } + } +} From f0dc0933c3862469650d2b0425087bc3ac49b0a8 Mon Sep 17 00:00:00 2001 From: Chaohui Wang Date: Wed, 31 May 2023 13:52:45 +0800 Subject: [PATCH 02/10] Fix padding issue on Scan QR code screen Fix: 284826809 Test: Manually when set Font and Display size to maximum Change-Id: I3c67b5603d27cefdb4776a43d72264051f40246f --- .../wifi_dpp_qrcode_scanner_fragment.xml | 79 ++++++++----------- 1 file changed, 33 insertions(+), 46 deletions(-) diff --git a/res/layout/wifi_dpp_qrcode_scanner_fragment.xml b/res/layout/wifi_dpp_qrcode_scanner_fragment.xml index 84470ba9a7d..ca2213f062e 100644 --- a/res/layout/wifi_dpp_qrcode_scanner_fragment.xml +++ b/res/layout/wifi_dpp_qrcode_scanner_fragment.xml @@ -23,59 +23,46 @@ android:icon="@drawable/ic_scan_32dp" app:sudDescriptionText="@string/wifi_dpp_scan_qr_code_join_unknown_network"> - + android:layout_height="match_parent"> - + - + android:layout_height="match_parent" /> - - - - + + - - - - - - - + + From e2f19b7de93c513c1d0d441cb5844f7817ae396a Mon Sep 17 00:00:00 2001 From: ykhung Date: Thu, 1 Jun 2023 12:47:50 +0800 Subject: [PATCH 03/10] Update incompatible charger checking rule Bug: 278316711 Test: make test RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.fuelgauge Change-Id: I8f720bcdf7c0efabc8278913ccf1c0427c857fac --- .../src/com/android/settings/testutils/BatteryTestUtils.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/robotests/src/com/android/settings/testutils/BatteryTestUtils.java b/tests/robotests/src/com/android/settings/testutils/BatteryTestUtils.java index b75fa8cfe1c..c54b750cb55 100644 --- a/tests/robotests/src/com/android/settings/testutils/BatteryTestUtils.java +++ b/tests/robotests/src/com/android/settings/testutils/BatteryTestUtils.java @@ -190,6 +190,7 @@ public class BatteryTestUtils { when(mockUsbPort.getStatus()).thenReturn(mockUsbPortStatus); when(mockUsbPort.supportsComplianceWarnings()).thenReturn(true); when(mockUsbPortStatus.isConnected()).thenReturn(true); - when(mockUsbPortStatus.getComplianceWarnings()).thenReturn(new int[]{1}); + when(mockUsbPortStatus.getComplianceWarnings()) + .thenReturn(new int[]{UsbPortStatus.COMPLIANCE_WARNING_OTHER}); } } From 0937c24f8f907ee4c65901823ec7d2dfcf4e53b8 Mon Sep 17 00:00:00 2001 From: Chaohui Wang Date: Thu, 1 Jun 2023 15:25:57 +0800 Subject: [PATCH 04/10] Unify the strings for Erase eSIM / eUICC erase_sim_confirm_button & erase_euicc_data_button are the same string and with same meanings, but since the description of erase_euicc_data_button is wrong and causes translate issue, clean up erase_euicc_data_button then. Fix: 279600315 Test: Visual check on Erase eSIMs dialog Change-Id: I5dec3dd5c1e851f84dd401dddd5416a27cb1a428 --- res/values/strings.xml | 2 -- .../android/settings/network/EraseEuiccDataDialogFragment.java | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index a90a3f7bd03..86be7311748 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -3020,8 +3020,6 @@ Bluetooth & Wi\u2011Fi have been reset - - Erase Erase eSIMs diff --git a/src/com/android/settings/network/EraseEuiccDataDialogFragment.java b/src/com/android/settings/network/EraseEuiccDataDialogFragment.java index 32903bde7ba..0200e524b07 100644 --- a/src/com/android/settings/network/EraseEuiccDataDialogFragment.java +++ b/src/com/android/settings/network/EraseEuiccDataDialogFragment.java @@ -23,7 +23,6 @@ import android.content.Context; import android.content.DialogInterface; import android.os.AsyncTask; import android.os.Bundle; -import android.os.RecoverySystem; import android.util.Log; import androidx.annotation.NonNull; @@ -62,7 +61,7 @@ public class EraseEuiccDataDialogFragment extends InstrumentedDialogFragment imp return new AlertDialog.Builder(getActivity()) .setTitle(R.string.reset_esim_title) .setMessage(R.string.reset_esim_desc) - .setPositiveButton(R.string.erase_euicc_data_button, this) + .setPositiveButton(R.string.erase_sim_confirm_button, this) .setNegativeButton(R.string.cancel, null) .setOnDismissListener(this) .create(); From 2560c0df9bc1bf759566e0cffd25d7ef8efb5260 Mon Sep 17 00:00:00 2001 From: Jason Chiu Date: Thu, 1 Jun 2023 15:49:48 +0800 Subject: [PATCH 05/10] Do not init dashboard categories when SetupWizard isn't finished yet The generated category cache during SetupWizard flow is invalid. Bug: 261885832 Test: manual Change-Id: Id2108b2cc4ab557b086c4dbbd5dc7722c73e74d3 --- src/com/android/settings/dashboard/CategoryManager.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/com/android/settings/dashboard/CategoryManager.java b/src/com/android/settings/dashboard/CategoryManager.java index 8ea5cf42cb3..2206af96f20 100644 --- a/src/com/android/settings/dashboard/CategoryManager.java +++ b/src/com/android/settings/dashboard/CategoryManager.java @@ -34,6 +34,8 @@ import com.android.settingslib.drawer.ProviderTile; import com.android.settingslib.drawer.Tile; import com.android.settingslib.drawer.TileUtils; +import com.google.android.setupcompat.util.WizardManagerHelper; + import java.util.ArrayList; import java.util.HashMap; import java.util.List; @@ -79,6 +81,9 @@ public class CategoryManager { } public synchronized List getCategories(Context context) { + if (!WizardManagerHelper.isUserSetupComplete(context)) { + return new ArrayList<>(); + } tryInitCategories(context); return mCategories; } @@ -142,6 +147,10 @@ public class CategoryManager { } private synchronized void tryInitCategories(Context context, boolean forceClearCache) { + if (!WizardManagerHelper.isUserSetupComplete(context)) { + // Don't init while setup wizard is still running. + return; + } if (mCategories == null) { final boolean firstLoading = mCategoryByKeyMap.isEmpty(); if (forceClearCache) { From 9ab4ef224e7540d4114c77021722ced3e9ebdc2e Mon Sep 17 00:00:00 2001 From: Chaohui Wang Date: Thu, 1 Jun 2023 17:13:50 +0800 Subject: [PATCH 06/10] Hide Show System on SPA version App languages To align with non-SPA version. Fix: 285264906 Test: Visual check on App languages Change-Id: I7f8b0aec0e33fcb46939075458a8b0a710fac640 --- src/com/android/settings/spa/system/AppLanguages.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/src/com/android/settings/spa/system/AppLanguages.kt b/src/com/android/settings/spa/system/AppLanguages.kt index f53a63d8be8..b878aa72ee0 100644 --- a/src/com/android/settings/spa/system/AppLanguages.kt +++ b/src/com/android/settings/spa/system/AppLanguages.kt @@ -41,6 +41,7 @@ object AppLanguagesPageProvider : SettingsPageProvider { AppListPage( title = stringResource(R.string.app_locales_picker_menu_title), listModel = rememberContext(::AppLanguagesListModel), + noMoreOptions = true, header = { Box(Modifier.padding(SettingsDimension.itemPadding)) { SettingsBody(stringResource(R.string.desc_app_locale_selection_supported)) From 3e980c7c8f0dc41acde82bf81d9d65adaaae9d60 Mon Sep 17 00:00:00 2001 From: Patty Huang Date: Thu, 1 Jun 2023 20:34:48 +0800 Subject: [PATCH 07/10] Default show LE audio toggle in Device Detail Bug: 284790607 Test: make RunSettingsRoboTests ROBOTEST_FILTER=BluetoothLeAudioDeviceDetailsPreferenceControllerTest Test: Checks the LE Audio toggle is shown in Device Detail by default Change-Id: Id301815513e8066941d3e4c44ab2e7b4d5ed011b --- .../bluetooth/BluetoothDetailsProfilesController.java | 2 +- ...luetoothLeAudioDeviceDetailsPreferenceController.java | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/com/android/settings/bluetooth/BluetoothDetailsProfilesController.java b/src/com/android/settings/bluetooth/BluetoothDetailsProfilesController.java index 724947c2fd6..aaedebd7634 100644 --- a/src/com/android/settings/bluetooth/BluetoothDetailsProfilesController.java +++ b/src/com/android/settings/bluetooth/BluetoothDetailsProfilesController.java @@ -99,7 +99,7 @@ public class BluetoothDetailsProfilesController extends BluetoothDetailsControll mIsLeContactSharingEnabled = DeviceConfig.getBoolean(DeviceConfig.NAMESPACE_SETTINGS_UI, SettingsUIDeviceConfig.BT_LE_AUDIO_CONTACT_SHARING_ENABLED, true); mIsLeAudioToggleEnabled = DeviceConfig.getBoolean(DeviceConfig.NAMESPACE_SETTINGS_UI, - SettingsUIDeviceConfig.BT_LE_AUDIO_DEVICE_DETAIL_ENABLED, false) + SettingsUIDeviceConfig.BT_LE_AUDIO_DEVICE_DETAIL_ENABLED, true) || DeviceConfig.getBoolean(DeviceConfig.NAMESPACE_BLUETOOTH, CONFIG_LE_AUDIO_ENABLED_BY_DEFAULT, false); // Call refresh here even though it will get called later in onResume, to avoid the diff --git a/src/com/android/settings/development/BluetoothLeAudioDeviceDetailsPreferenceController.java b/src/com/android/settings/development/BluetoothLeAudioDeviceDetailsPreferenceController.java index a54c594c84d..298ced091a9 100644 --- a/src/com/android/settings/development/BluetoothLeAudioDeviceDetailsPreferenceController.java +++ b/src/com/android/settings/development/BluetoothLeAudioDeviceDetailsPreferenceController.java @@ -40,6 +40,7 @@ public class BluetoothLeAudioDeviceDetailsPreferenceController private static final String PREFERENCE_KEY = "bluetooth_show_leaudio_device_details"; private static final String CONFIG_LE_AUDIO_ENABLED_BY_DEFAULT = "le_audio_enabled_by_default"; + private static final boolean LE_AUDIO_DEVICE_DETAIL_DEFAULT_VALUE = true; static int sLeAudioSupportedStateCache = BluetoothStatusCodes.ERROR_UNKNOWN; @VisibleForTesting @@ -75,7 +76,7 @@ public class BluetoothLeAudioDeviceDetailsPreferenceController DeviceConfig.setProperty( DeviceConfig.NAMESPACE_SETTINGS_UI, SettingsUIDeviceConfig.BT_LE_AUDIO_DEVICE_DETAIL_ENABLED, - isEnabled ? "true" : "false", false); + isEnabled ? "true" : "false", LE_AUDIO_DEVICE_DETAIL_DEFAULT_VALUE); return true; } @@ -87,7 +88,8 @@ public class BluetoothLeAudioDeviceDetailsPreferenceController final boolean leAudioDeviceDetailEnabled = DeviceConfig.getBoolean( DeviceConfig.NAMESPACE_SETTINGS_UI, - SettingsUIDeviceConfig.BT_LE_AUDIO_DEVICE_DETAIL_ENABLED, false); + SettingsUIDeviceConfig.BT_LE_AUDIO_DEVICE_DETAIL_ENABLED, + LE_AUDIO_DEVICE_DETAIL_DEFAULT_VALUE); final boolean leAudioEnabledByDefault = DeviceConfig.getBoolean( DeviceConfig.NAMESPACE_BLUETOOTH, CONFIG_LE_AUDIO_ENABLED_BY_DEFAULT, false); @@ -102,6 +104,7 @@ public class BluetoothLeAudioDeviceDetailsPreferenceController // Reset the toggle to null when the developer option is disabled DeviceConfig.setProperty( DeviceConfig.NAMESPACE_SETTINGS_UI, - SettingsUIDeviceConfig.BT_LE_AUDIO_DEVICE_DETAIL_ENABLED, "null", false); + SettingsUIDeviceConfig.BT_LE_AUDIO_DEVICE_DETAIL_ENABLED, "null", + LE_AUDIO_DEVICE_DETAIL_DEFAULT_VALUE); } } From ef811795384ecbc08f07382f474d120fe25fc4b6 Mon Sep 17 00:00:00 2001 From: Weng Su Date: Fri, 2 Jun 2023 03:27:44 +0800 Subject: [PATCH 08/10] Skip Wi-Fi hotspot in Settings Widgets - Do not show Wi-Fi hotspots in Settings Widgets if the config is not set to show Bug: 275268676 Test: Manual test atest -c CreateShortcutPreferenceControllerTest Change-Id: I5d86a78c9d48c9b63faff50d46f1254dbefd94cf --- .../CreateShortcutPreferenceController.java | 13 +++++++ ...reateShortcutPreferenceControllerTest.java | 36 ++++++++++++------- 2 files changed, 37 insertions(+), 12 deletions(-) diff --git a/src/com/android/settings/shortcut/CreateShortcutPreferenceController.java b/src/com/android/settings/shortcut/CreateShortcutPreferenceController.java index 89ee19bc8a7..bf953489be9 100644 --- a/src/com/android/settings/shortcut/CreateShortcutPreferenceController.java +++ b/src/com/android/settings/shortcut/CreateShortcutPreferenceController.java @@ -46,10 +46,12 @@ import androidx.preference.PreferenceGroup; import com.android.settings.R; import com.android.settings.Settings; import com.android.settings.Settings.TetherSettingsActivity; +import com.android.settings.Settings.WifiTetherSettingsActivity; import com.android.settings.activityembedding.ActivityEmbeddingUtils; import com.android.settings.core.BasePreferenceController; import com.android.settings.gestures.OneHandedSettingsUtils; import com.android.settings.overlay.FeatureFactory; +import com.android.settings.wifi.WifiUtils; import com.android.settingslib.core.instrumentation.MetricsFeatureProvider; import java.util.ArrayList; @@ -192,6 +194,12 @@ public class CreateShortcutPreferenceController extends BasePreferenceController continue; } } + if (info.activityInfo.name.endsWith(WifiTetherSettingsActivity.class.getSimpleName())) { + if (!canShowWifiHotspot()) { + Log.d(TAG, "Skipping Wi-Fi hotspot settings:" + info.activityInfo); + continue; + } + } if (!info.activityInfo.applicationInfo.isSystemApp()) { Log.d(TAG, "Skipping non-system app: " + info.activityInfo); continue; @@ -202,6 +210,11 @@ public class CreateShortcutPreferenceController extends BasePreferenceController return shortcuts; } + @VisibleForTesting + boolean canShowWifiHotspot() { + return WifiUtils.canShowWifiHotspot(mContext); + } + private void logCreateShortcut(ResolveInfo info) { if (info == null || info.activityInfo == null) { return; diff --git a/tests/robotests/src/com/android/settings/shortcut/CreateShortcutPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/shortcut/CreateShortcutPreferenceControllerTest.java index 49c1551c5d3..df1fec38b56 100644 --- a/tests/robotests/src/com/android/settings/shortcut/CreateShortcutPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/shortcut/CreateShortcutPreferenceControllerTest.java @@ -84,7 +84,7 @@ public class CreateShortcutPreferenceControllerTest { mShadowConnectivityManager = ShadowConnectivityManager.getShadow(); mShadowConnectivityManager.setTetheringSupported(true); - mController = new CreateShortcutPreferenceController(mContext, "key"); + mController = spy(new CreateShortcutPreferenceController(mContext, "key")); mController.setActivity(mHost); } @@ -159,27 +159,39 @@ public class CreateShortcutPreferenceControllerTest { @Test public void queryShortcuts_setSupportOneHandedMode_ShouldEnableShortcuts() { SystemProperties.set(SUPPORT_ONE_HANDED_MODE, "true"); + setupActivityInfo(Settings.OneHandedSettingsActivity.class.getSimpleName()); - setupOneHandedModeActivityInfo(); - final List info = mController.queryShortcuts(); - - assertThat(info).hasSize(1); + assertThat(mController.queryShortcuts()).hasSize(1); } @Test public void queryShortcuts_setUnsupportOneHandedMode_ShouldDisableShortcuts() { SystemProperties.set(SUPPORT_ONE_HANDED_MODE, "false"); + setupActivityInfo(Settings.OneHandedSettingsActivity.class.getSimpleName()); - setupOneHandedModeActivityInfo(); - final List info = mController.queryShortcuts(); - - assertThat(info).hasSize(0); + assertThat(mController.queryShortcuts()).hasSize(0); } - private void setupOneHandedModeActivityInfo() { - final ResolveInfo ri = new ResolveInfo(); + @Test + public void queryShortcuts_configShowWifiHotspot_ShouldEnableShortcuts() { + when(mController.canShowWifiHotspot()).thenReturn(true); + setupActivityInfo(Settings.WifiTetherSettingsActivity.class.getSimpleName()); + + assertThat(mController.queryShortcuts()).hasSize(1); + } + + @Test + public void queryShortcuts_configNotShowWifiHotspot_ShouldDisableShortcuts() { + when(mController.canShowWifiHotspot()).thenReturn(false); + setupActivityInfo(Settings.WifiTetherSettingsActivity.class.getSimpleName()); + + assertThat(mController.queryShortcuts()).hasSize(0); + } + + private void setupActivityInfo(String name) { + ResolveInfo ri = new ResolveInfo(); ri.activityInfo = new ActivityInfo(); - ri.activityInfo.name = Settings.OneHandedSettingsActivity.class.getSimpleName(); + ri.activityInfo.name = name; ri.activityInfo.applicationInfo = new ApplicationInfo(); ri.activityInfo.applicationInfo.flags = ApplicationInfo.FLAG_SYSTEM; From 23560717c4d4f2a3c8403adb43b094cae3ae2241 Mon Sep 17 00:00:00 2001 From: Yanli Wan Date: Thu, 1 Jun 2023 22:57:48 +0000 Subject: [PATCH 09/10] Update the string of Settings preference for device lock Bug: 282040794 Test: build & test locally Change-Id: Ic9139c061b8cbea08bf74d0462420bf3157c4477 --- res/values/strings.xml | 3 +-- res/xml/more_security_privacy_settings.xml | 4 ++-- res/xml/security_advanced_settings.xml | 4 ++-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 091b3af0bd2..a72794dc4b5 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -10178,8 +10178,7 @@ You can uninstall the creditor app - - Device Lock + Financed device info {count, plural, diff --git a/res/xml/more_security_privacy_settings.xml b/res/xml/more_security_privacy_settings.xml index 1a9d788ea76..47ea3e02a18 100644 --- a/res/xml/more_security_privacy_settings.xml +++ b/res/xml/more_security_privacy_settings.xml @@ -147,8 +147,8 @@ settings:controller="com.android.settings.enterprise.FinancedPrivacyPreferenceController"/> diff --git a/res/xml/security_advanced_settings.xml b/res/xml/security_advanced_settings.xml index 8223f509c1d..f52fb12d1fb 100644 --- a/res/xml/security_advanced_settings.xml +++ b/res/xml/security_advanced_settings.xml @@ -59,8 +59,8 @@ settings:controller="com.android.settings.enterprise.FinancedPrivacyPreferenceController"/> From 7a8602dce903158d50d0c90bcfe2dc8898dd16a8 Mon Sep 17 00:00:00 2001 From: Chun-Ku Lin Date: Mon, 22 May 2023 21:19:05 +0000 Subject: [PATCH 10/10] Set textDirection=locale and layoutDirection=locale for alert dialog It's strongly recommended by internationalization team to set android:textDirection="locale" and android:layoutDirection="locale" to tackle a text that consists of RTL and LTR characters. Bug: 279491415 Bug: 283608580 Bug: 283608637 Test: manual Merged-In: I0dfa0da22e70d267d8d8ed8e9c5be3d6db107841 Change-Id: I0dfa0da22e70d267d8d8ed8e9c5be3d6db107841 (cherry picked from commit 219d4e6ca16cd751fd876e8ce77491defdcd62ff) --- res/values/themes.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/res/values/themes.xml b/res/values/themes.xml index eeba1c77aca..e3c1b20cf3f 100644 --- a/res/values/themes.xml +++ b/res/values/themes.xml @@ -132,6 +132,8 @@ adjustResize true true + locale + locale @style/Widget.ActionBar