Refine the mobile data selection UI

-Adding the margin for bottom at dialog
-Modify the text color of summay in the list at dialog when device is
dark mode.

Bug: 212396431
Test: build pass and check the dialog UI.
Change-Id: I1ec587fd9d64ad67bbf3479c7931c0a901f572cf
This commit is contained in:
SongFerngWang
2021-12-28 21:52:24 +08:00
parent b5766e4422
commit 43ebe68063
5 changed files with 16 additions and 2 deletions

View File

@@ -36,6 +36,5 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_below="@id/title" android:layout_below="@id/title"
android:textColor="?android:attr/textColorSecondary"
android:layout_alignStart="@id/title" /> android:layout_alignStart="@id/title" />
</LinearLayout> </LinearLayout>

View File

@@ -28,6 +28,6 @@
<style name="TextAppearance.SimConfirmDialogList.Summary"> <style name="TextAppearance.SimConfirmDialogList.Summary">
<item name="android:textAppearance">?android:attr/textAppearanceSmall</item> <item name="android:textAppearance">?android:attr/textAppearanceSmall</item>
<item name="android:fontFamily">@*android:string/config_headlineFontFamily</item> <item name="android:fontFamily">@*android:string/config_headlineFontFamily</item>
<item name="android:textColor">?android:attr/textColorPrimaryInverse</item> <item name="android:textColor">?android:attr/textColorSecondaryInverse</item>
</style> </style>
</resources> </resources>

View File

@@ -456,4 +456,8 @@
<dimen name="chartview_trapezoid_radius">5dp</dimen> <dimen name="chartview_trapezoid_radius">5dp</dimen>
<dimen name="chartview_trapezoid_margin_start">1dp</dimen> <dimen name="chartview_trapezoid_margin_start">1dp</dimen>
<dimen name="chartview_trapezoid_margin_bottom">2dp</dimen> <dimen name="chartview_trapezoid_margin_bottom">2dp</dimen>
<!-- Sims/Data mobile/Calls/SMS select dialog-->
<dimen name="sims_select_margin_bottom">24dp</dimen>
<dimen name="sims_select_margin_top">8dp</dimen>
</resources> </resources>

View File

@@ -931,6 +931,7 @@
<style name="TextAppearance.SimConfirmDialogList.Summary"> <style name="TextAppearance.SimConfirmDialogList.Summary">
<item name="android:textAppearance">?android:attr/textAppearanceSmall</item> <item name="android:textAppearance">?android:attr/textAppearanceSmall</item>
<item name="android:textColor">?android:attr/textColorSecondary</item>
</style> </style>
<style name="SimConfirmDialog.OutlineButton" parent="@android:style/Widget.Material.Button"> <style name="SimConfirmDialog.OutlineButton" parent="@android:style/Widget.Material.Button">

View File

@@ -200,6 +200,16 @@ public class SimListDialogFragment extends SimDialogFragment implements
final TextView title = convertView.findViewById(R.id.title); final TextView title = convertView.findViewById(R.id.title);
final TextView summary = convertView.findViewById(R.id.summary); final TextView summary = convertView.findViewById(R.id.summary);
ViewGroup.MarginLayoutParams lp =
(ViewGroup.MarginLayoutParams) parent.getLayoutParams();
if (lp != null) {
lp.setMargins(0, mContext.getResources().getDimensionPixelSize(
R.dimen.sims_select_margin_top), 0,
mContext.getResources().getDimensionPixelSize(
R.dimen.sims_select_margin_bottom));
convertView.setLayoutParams(lp);
}
if (sub == null) { if (sub == null) {
if (position == 0) { if (position == 0) {
title.setText(R.string.sim_calls_ask_first_prefs_title); title.setText(R.string.sim_calls_ask_first_prefs_title);