diff --git a/res/xml/mobile_network_list.xml b/res/xml/mobile_network_list.xml index 6bf9ad2a09b..6008de7ac0d 100644 --- a/res/xml/mobile_network_list.xml +++ b/res/xml/mobile_network_list.xml @@ -13,7 +13,8 @@ See the License for the specific language governing permissions and limitations under the License. --> - + createPreferenceControllers(Context context) { final List controllers = new ArrayList<>(); - if (Utils.isProviderModelEnabled(getContext())) { - NetworkProviderSimsCategoryController simCategoryPrefCtrl = - new NetworkProviderSimsCategoryController(context, KEY_PREFERENCE_CATEGORY_SIM, - getSettingsLifecycle()); - controllers.add(simCategoryPrefCtrl); - NetworkProviderDownloadedSimsCategoryController downloadedSimsCategoryCtrl = - new NetworkProviderDownloadedSimsCategoryController(context, - KEY_PREFERENCE_CATEGORY_DOWNLOADED_SIM, getSettingsLifecycle()); - controllers.add(downloadedSimsCategoryCtrl); - } else { - controllers.add(new MobileNetworkListController(getContext(), getLifecycle())); - } + NetworkProviderSimsCategoryController simCategoryPrefCtrl = + new NetworkProviderSimsCategoryController(context, KEY_PREFERENCE_CATEGORY_SIM, + getSettingsLifecycle()); + controllers.add(simCategoryPrefCtrl); + NetworkProviderDownloadedSimsCategoryController downloadedSimsCategoryCtrl = + new NetworkProviderDownloadedSimsCategoryController(context, + KEY_PREFERENCE_CATEGORY_DOWNLOADED_SIM, getSettingsLifecycle()); + controllers.add(downloadedSimsCategoryCtrl); return controllers; } @@ -87,9 +81,7 @@ public class MobileNetworkListFragment extends DashboardFragment { boolean enabled) { final ArrayList result = new ArrayList<>(); final SearchIndexableResource sir = new SearchIndexableResource(context); - sir.xmlResId = Utils.isProviderModelEnabled(context) - ? R.xml.network_provider_sims_list - : R.xml.mobile_network_list; + sir.xmlResId = R.xml.network_provider_sims_list; result.add(sir); return result; } diff --git a/src/com/android/settings/network/NetworkDashboardFragment.java b/src/com/android/settings/network/NetworkDashboardFragment.java index c53b4f652ad..c7621977773 100644 --- a/src/com/android/settings/network/NetworkDashboardFragment.java +++ b/src/com/android/settings/network/NetworkDashboardFragment.java @@ -60,20 +60,13 @@ public class NetworkDashboardFragment extends DashboardFragment implements @Override protected int getPreferenceScreenResId() { - if (Utils.isProviderModelEnabled(getContext())) { - return R.xml.network_provider_internet; - } else { - return R.xml.network_and_internet; - } + return R.xml.network_provider_internet; } @Override public void onAttach(Context context) { super.onAttach(context); - if (!Utils.isProviderModelEnabled(context)) { - use(MultiNetworkHeaderController.class).init(getSettingsLifecycle()); - } use(AirplaneModePreferenceController.class).setFragment(this); getSettingsLifecycle().addObserver(use(AllInOneTetherPreferenceController.class)); } @@ -100,16 +93,8 @@ public class NetworkDashboardFragment extends DashboardFragment implements MobilePlanPreferenceHost mobilePlanHost) { final MobilePlanPreferenceController mobilePlanPreferenceController = new MobilePlanPreferenceController(context, mobilePlanHost); - final WifiPrimarySwitchPreferenceController wifiPreferenceController = - Utils.isProviderModelEnabled(context) - ? null - : new WifiPrimarySwitchPreferenceController( - context, - metricsFeatureProvider); final InternetPreferenceController internetPreferenceController = - Utils.isProviderModelEnabled(context) - ? new InternetPreferenceController(context, lifecycle) - : null; + new InternetPreferenceController(context, lifecycle); final VpnPreferenceController vpnPreferenceController = new VpnPreferenceController(context); @@ -118,9 +103,6 @@ public class NetworkDashboardFragment extends DashboardFragment implements if (lifecycle != null) { lifecycle.addObserver(mobilePlanPreferenceController); - if (wifiPreferenceController != null) { - lifecycle.addObserver(wifiPreferenceController); - } lifecycle.addObserver(vpnPreferenceController); lifecycle.addObserver(privateDnsPreferenceController); } @@ -132,9 +114,6 @@ public class NetworkDashboardFragment extends DashboardFragment implements controllers.add(vpnPreferenceController); controllers.add(new ProxyPreferenceController(context)); controllers.add(mobilePlanPreferenceController); - if (wifiPreferenceController != null) { - controllers.add(wifiPreferenceController); - } if (internetPreferenceController != null) { controllers.add(internetPreferenceController); } diff --git a/tests/unit/src/com/android/settings/network/CarrierWifiTogglePreferenceControllerTest.java b/tests/unit/src/com/android/settings/network/CarrierWifiTogglePreferenceControllerTest.java index 444401972fc..21a8444b687 100644 --- a/tests/unit/src/com/android/settings/network/CarrierWifiTogglePreferenceControllerTest.java +++ b/tests/unit/src/com/android/settings/network/CarrierWifiTogglePreferenceControllerTest.java @@ -70,7 +70,6 @@ public class CarrierWifiTogglePreferenceControllerTest { mController = new CarrierWifiTogglePreferenceController(mContext, CarrierWifiTogglePreferenceController.CARRIER_WIFI_TOGGLE_PREF_KEY); mController.init(mock(Lifecycle.class), SUB_ID); - mController.mIsProviderModelEnabled = true; mController.mIsCarrierProvisionWifiEnabled = true; doReturn(true).when(mWifiPickerTrackerHelper).isCarrierNetworkActive(); doReturn(SSID).when(mWifiPickerTrackerHelper).getCarrierNetworkSsid(); @@ -92,13 +91,6 @@ public class CarrierWifiTogglePreferenceControllerTest { mController.mCarrierNetworkPreference = mNetworkPreference; } - @Test - public void getAvailabilityStatus_providerModelDisable_returnUnavailable() { - mController.mIsProviderModelEnabled = false; - - assertThat(mController.getAvailabilityStatus()).isEqualTo(CONDITIONALLY_UNAVAILABLE); - } - @Test public void getAvailabilityStatus_carrierProvisionWifiEnabled_returnAvailable() { mController.mIsCarrierProvisionWifiEnabled = true;