Merge "Added guard to logging in AsyncTask" into nyc-mr1-dev

This commit is contained in:
Salvador Martinez
2016-08-25 19:57:24 +00:00
committed by Android (Google) Code Review

View File

@@ -236,17 +236,18 @@ public class DashboardSummary extends InstrumentedFragment
@Override
protected List<Tile> doInBackground(Void... params) {
final Context context = getContext();
List<Tile> suggestions = mSuggestionParser.getSuggestions();
for (int i = 0; i < suggestions.size(); i++) {
Tile suggestion = suggestions.get(i);
if (mSuggestionsChecks.isSuggestionComplete(suggestion)) {
mAdapter.disableSuggestion(suggestion);
suggestions.remove(i--);
} else {
String id = DashboardAdapter.getSuggestionIdentifier(getContext(), suggestion);
} else if (context != null) {
String id = DashboardAdapter.getSuggestionIdentifier(context, suggestion);
if (!mSuggestionsShownLogged.contains(id)) {
mSuggestionsShownLogged.add(id);
MetricsLogger.action(getContext(),
MetricsLogger.action(context,
MetricsEvent.ACTION_SHOW_SETTINGS_SUGGESTION, id);
}
}