From 83397eab96d95fbf6443e17c556e30d54cfa88da Mon Sep 17 00:00:00 2001 From: Li Wenji Date: Sat, 11 Feb 2012 11:52:30 +0800 Subject: [PATCH] TetheringSetting: Keep Tethering checkbox unchecked until tethering up When click Tethering, the checkbox will be checked and then unchecked, and finally move to checked states. This causes confusing to end user, we need to keep Tethering checkbox unchecked before tethering is really up. Change-Id: If2314b7dd1369e619dead45af38fd53c7e89c34e Author: Li Wenji Signed-off-by: Xiaokang Qin Signed-off-by: Bruce Beare Signed-off-by: Jack Ren Author-tracking-BZ: 18281 --- src/com/android/settings/TetherSettings.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/android/settings/TetherSettings.java b/src/com/android/settings/TetherSettings.java index 77a72a73e3c..4a79eca9ea6 100644 --- a/src/com/android/settings/TetherSettings.java +++ b/src/com/android/settings/TetherSettings.java @@ -493,8 +493,8 @@ public class TetherSettings extends SettingsPreferenceFragment private void setUsbTethering(boolean enabled) { ConnectivityManager cm = (ConnectivityManager)getSystemService(Context.CONNECTIVITY_SERVICE); + mUsbTether.setChecked(false); if (cm.setUsbTethering(enabled) != ConnectivityManager.TETHER_ERROR_NO_ERROR) { - mUsbTether.setChecked(false); mUsbTether.setSummary(R.string.usb_tethering_errored_subtext); return; }