PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update view alpha to improve text color constract in Battery usage

Browse Source 
- For light themes, first set the text color of title/summary/widget_summary to be consistent, then apply alpha = 0.65

[Before] https://screenshot.googleplex.com/4nVMMFBK7odhQju
A11y Scanner result: https://screenshot.googleplex.com/4nVMMFBK7odhQju

[After] https://screenshot.googleplex.com/B4r79v89HnWr4tw
A11y Scanner result: https://screenshot.googleplex.com/3zQfRMe4HToc8Xm

Dark mode:
[before] https://screenshot.googleplex.com/BfLxR6tqQRgP4mQ
[after]  https://screenshot.googleplex.com/8KeG62i7R5hW8Ks

Bug: 317139415
Bug: 265364351
Test: Accessibility Scanner
Change-Id: I65a71525bbce41c37ee364f3f73c0d2d1d9ace38
This commit is contained in:
mxyyiyi
2024-05-21 11:41:58 +08:00
parent 9c0654daea
commit 431c14fa18
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/com/android/settings/fuelgauge/batteryusage/PowerGaugePreference.java
View File

@@ -44,6 +44,8 @@ public class PowerGaugePreference extends AppPreference {
private static final float UNSELECTABLE_ALPHA_LIGHT_MODE = 0.65f; private static final float UNSELECTABLE_ALPHA_LIGHT_MODE = 0.65f;
private static final float UNSELECTABLE_ALPHA_DARK_MODE = 0.65f; private static final float UNSELECTABLE_ALPHA_DARK_MODE = 0.65f;
private final int mTitleColorNormal;
private BatteryEntry mInfo; private BatteryEntry mInfo;
private BatteryDiffEntry mBatteryDiffEntry; private BatteryDiffEntry mBatteryDiffEntry;
private CharSequence mContentDescription; private CharSequence mContentDescription;
@@ -78,6 +80,8 @@ public class PowerGaugePreference extends AppPreference {
mInfo = info; mInfo = info;
mContentDescription = contentDescription; mContentDescription = contentDescription;
mShowAnomalyIcon = false; mShowAnomalyIcon = false;
mTitleColorNormal =
Utils.getColorAttrDefaultColor(context, android.R.attr.textColorPrimary);
} }
/** Sets the content description. */ /** Sets the content description. */
@@ -155,6 +159,13 @@ public class PowerGaugePreference extends AppPreference {
final TextView titleView = (TextView) view.findViewById(android.R.id.title); final TextView titleView = (TextView) view.findViewById(android.R.id.title);
titleView.setContentDescription(mContentDescription); titleView.setContentDescription(mContentDescription);
} }
if (!isSelectable()) {
// Set colors consistently to meet contrast requirements for non-selectable items
((TextView) view.findViewById(android.R.id.title)).setTextColor(mTitleColorNormal);
((TextView) view.findViewById(android.R.id.summary)).setTextColor(mTitleColorNormal);
subtitle.setTextColor(mTitleColorNormal);
}
} }
private static void setViewAlpha(View view, float alpha) { private static void setViewAlpha(View view, float alpha) {