Merge "Fix bug #14158603 Stability: NPE in Settings: Attempt to invoke... ...interface method 'boolean android.view.MenuItem.collapseActionView()' ...on a null object reference"
This commit is contained in:
committed by
Android (Google) Code Review
commit
42aacb1f50
@@ -399,6 +399,10 @@ public class SettingsActivity extends Activity
|
|||||||
mSearchMenuItem = menu.findItem(R.id.search);
|
mSearchMenuItem = menu.findItem(R.id.search);
|
||||||
mSearchView = (SearchView) mSearchMenuItem.getActionView();
|
mSearchView = (SearchView) mSearchMenuItem.getActionView();
|
||||||
|
|
||||||
|
if (mSearchMenuItem == null || mSearchView == null) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
mSearchMenuItem.setOnActionExpandListener(this);
|
mSearchMenuItem.setOnActionExpandListener(this);
|
||||||
mSearchView.setOnQueryTextListener(this);
|
mSearchView.setOnQueryTextListener(this);
|
||||||
mSearchView.setOnCloseListener(this);
|
mSearchView.setOnCloseListener(this);
|
||||||
@@ -1289,6 +1293,8 @@ public class SettingsActivity extends Activity
|
|||||||
mSearchMenuItemExpanded = false;
|
mSearchMenuItemExpanded = false;
|
||||||
getFragmentManager().popBackStackImmediate(SettingsActivity.BACK_STACK_PREFS,
|
getFragmentManager().popBackStackImmediate(SettingsActivity.BACK_STACK_PREFS,
|
||||||
FragmentManager.POP_BACK_STACK_INCLUSIVE);
|
FragmentManager.POP_BACK_STACK_INCLUSIVE);
|
||||||
mSearchMenuItem.collapseActionView();
|
if (mSearchMenuItem != null) {
|
||||||
|
mSearchMenuItem.collapseActionView();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user