PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix blocked notifications screen

Browse Source 
Don't filter out apps have don't have any usage events -
the package's notifications are still blocked

Test: atest, and verify that the packages match the 'blocked
count' subtext on the previous screen on an affected device
Fixes: 158343184

Change-Id: Iac01708849e3ae0b82f97db679ce512fc9675a17
This commit is contained in:
Julia Reynolds
2020-06-09 12:17:58 -04:00
parent 21ac98e2f1
commit 425504c2de
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/com/android/settings/applications/AppStateNotificationBridge.java
View File

@@ -84,6 +84,9 @@ public class AppStateNotificationBridge extends AppStateBaseBridge {
for (AppEntry entry : apps) {
NotificationsSentState stats =
map.get(getKey(UserHandle.getUserId(entry.info.uid), entry.info.packageName));
if (stats == null) {
stats = new NotificationsSentState();
}
calculateAvgSentCounts(stats);
addBlockStatus(entry, stats);
entry.extraInfo = stats;

7
tests/robotests/src/com/android/settings/applications/AppStateNotificationBridgeTest.java
View File

@@ -211,7 +211,12 @@ public class AppStateNotificationBridgeTest {
when(mSession.getAllApps()).thenReturn(apps);
mBridge.loadAllExtraInfo();
assertThat(apps.get(0).extraInfo).isNull();
// extra info should exist and blocked status should be populated
assertThat(apps.get(0).extraInfo).isNotNull();
verify(mBackend).getNotificationsBanned(PKG1, 0);
// but the recent/frequent counts should be 0 so they don't appear on those screens
assertThat(((NotificationsSentState) apps.get(0).extraInfo).avgSentDaily).isEqualTo(0);
assertThat(((NotificationsSentState) apps.get(0).extraInfo).lastSent).isEqualTo(0);
}
@Test