PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Settings] Code refactor for IMS part

Browse Source 
Return boolean in method names starting with "is".

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceControllerTest
Change-Id: I2a9ca9ae829f0dcda478f3343cd50e61f441a9a7
This commit is contained in:
Bonian Chen
2020-02-14 03:41:33 +08:00
parent fd8e319801
commit 4074e9aab7
8 changed files with 48 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/com/android/settings/network/ims/VtQueryImsState.java
View File

@@ -55,8 +55,8 @@ public class VtQueryImsState extends ImsQueryController {
* Implementation of ImsQueryController#isEnabledByUser(int subId)
*/
@VisibleForTesting
ImsQuery isEnabledByUser(int subId) {
return new ImsQueryVtUserSetting(subId);
boolean isEnabledByUser(int subId) {
return (new ImsQueryVtUserSetting(subId)).query();
}
@VisibleForTesting
@@ -77,7 +77,7 @@ public class VtQueryImsState extends ImsQueryController {
}
return imsManager.isVtEnabledByPlatform()
&& isProvisionedOnDevice(mSubId).query()
&& isProvisionedOnDevice(mSubId)
&& MobileNetworkUtils.isImsServiceStateReady(imsManager);
}
@@ -91,7 +91,7 @@ public class VtQueryImsState extends ImsQueryController {
return false;
}
return ((!isTtyEnabled(mContext))
|| (isTtyOnVolteEnabled(mSubId).query()));
|| (isTtyOnVolteEnabled(mSubId)));
}
@VisibleForTesting
@@ -109,6 +109,6 @@ public class VtQueryImsState extends ImsQueryController {
if (!SubscriptionManager.isValidSubscriptionId(mSubId)) {
return false;
}
return isEnabledByUser(mSubId).query();
return isEnabledByUser(mSubId);
}
}