Update USb preference controller to use the new summary texts.
- since the choose usb mode dialog and the preference summary use separate strings now, the two classes can have their own handling for getting the title/summary text and hence revert the earlier change that move the setTitle() and setSummary() from the activity to controller - only show summary for the option for "supply power", and don't set summary for all other options - update the controller to use the new summary text. - update test correspondingly. Change-Id: Ie56eb33ba24262e6f3a2259e4ee5ad6f3bfb8061 Fix: 36234108 Test: make RunSettingsRoboTests
This commit is contained in:
@@ -0,0 +1,94 @@
|
||||
/*
|
||||
* Copyright (C) 2017 The Android Open Source Project
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
package com.android.settings.deviceinfo;
|
||||
|
||||
import static com.google.common.truth.Truth.assertThat;
|
||||
import static org.mockito.Matchers.anyInt;
|
||||
import static org.mockito.Mockito.never;
|
||||
import static org.mockito.Mockito.verify;
|
||||
|
||||
import android.widget.TextView;
|
||||
import com.android.settings.R;
|
||||
import com.android.settings.SettingsRobolectricTestRunner;
|
||||
import com.android.settings.TestConfig;
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.MockitoAnnotations;
|
||||
import org.robolectric.annotation.Config;
|
||||
|
||||
@RunWith(SettingsRobolectricTestRunner.class)
|
||||
@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
|
||||
public class UsbModeChooserActivityTest {
|
||||
|
||||
@Mock
|
||||
private TextView mTextView;
|
||||
|
||||
@Before
|
||||
public void setUp() {
|
||||
MockitoAnnotations.initMocks(this);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void updateSummary_chargeDevice_shouldNotSetSummary() {
|
||||
UsbModeChooserActivity.updateSummary(mTextView, UsbModeChooserActivity.DEFAULT_MODES[0]);
|
||||
verify(mTextView, never()).setText(anyInt());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void updateSummary_supplyPower_shouldSetSummary() {
|
||||
UsbModeChooserActivity.updateSummary(mTextView, UsbModeChooserActivity.DEFAULT_MODES[1]);
|
||||
verify(mTextView).setText(R.string.usb_use_power_only_desc);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void updateSummary_transferFiles_shouldNotSetSummary() {
|
||||
UsbModeChooserActivity.updateSummary(mTextView, UsbModeChooserActivity.DEFAULT_MODES[2]);
|
||||
verify(mTextView, never()).setText(anyInt());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void updateSummary_transferPhoto_shouldNotSetSummary() {
|
||||
UsbModeChooserActivity.updateSummary(mTextView, UsbModeChooserActivity.DEFAULT_MODES[3]);
|
||||
verify(mTextView, never()).setText(anyInt());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void updateSummary_MIDI_shouldNotSetSummary() {
|
||||
UsbModeChooserActivity.updateSummary(mTextView, UsbModeChooserActivity.DEFAULT_MODES[4]);
|
||||
verify(mTextView, never()).setText(anyInt());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void getTitle_shouldReturnCorrectTitle() {
|
||||
assertThat(UsbModeChooserActivity.getTitle(UsbModeChooserActivity.DEFAULT_MODES[0]))
|
||||
.isEqualTo(R.string.usb_use_charging_only);
|
||||
|
||||
assertThat(UsbModeChooserActivity.getTitle(UsbModeChooserActivity.DEFAULT_MODES[1]))
|
||||
.isEqualTo(R.string.usb_use_power_only);
|
||||
|
||||
assertThat(UsbModeChooserActivity.getTitle(UsbModeChooserActivity.DEFAULT_MODES[2]))
|
||||
.isEqualTo(R.string.usb_use_file_transfers);
|
||||
|
||||
assertThat(UsbModeChooserActivity.getTitle(UsbModeChooserActivity.DEFAULT_MODES[3]))
|
||||
.isEqualTo(R.string.usb_use_photo_transfers);
|
||||
|
||||
assertThat(UsbModeChooserActivity.getTitle(UsbModeChooserActivity.DEFAULT_MODES[4]))
|
||||
.isEqualTo(R.string.usb_use_MIDI);
|
||||
}
|
||||
|
||||
}
|
||||
Reference in New Issue
Block a user