Changes to 'Alarms & reminders' permission setting
Not showing apps that are targeting SDK < 31, because the change is not enabled for them. Now alarm manager service manages killing the process whenever the permission gets revoked, so we don't need to do it here. This also lets us kill the app on "Reset app preferences" if needed. Adding the preference under "Advanced" in the app info page so it appears for apps that have requested this permission. Test: atest SettingsUnitTests:AppStateAlarmsAndRemindersBridgeTest make -j64 RunSettingsRoboTests \ ROBOTEST_FILTER="AlarmsAndRemindersDetailsTest| AlarmsAndRemindersDetailPreferenceControllerTest" Manually: - There should be no observable difference in behavior when toggling the setting. ActivityManager logs should still indicate that the app is killed when the permission is revoked. - "Alarms & Reminders" should appear under "Advanced" when looking at the app info detail of an app that appears under "Alarms & reminders" special app access page. Bug: 179541791 Bug: 190070171 Change-Id: I2d437cec10ee10e4326fb25b2820de9ef9c31c67
This commit is contained in:
@@ -0,0 +1,98 @@
|
||||
/*
|
||||
* Copyright (C) 2021 The Android Open Source Project
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package com.android.settings.applications.appinfo;
|
||||
|
||||
import static com.google.common.truth.Truth.assertThat;
|
||||
|
||||
import static org.mockito.Mockito.doReturn;
|
||||
import static org.mockito.Mockito.spy;
|
||||
import static org.mockito.Mockito.verify;
|
||||
import static org.mockito.Mockito.when;
|
||||
|
||||
import android.content.Context;
|
||||
|
||||
import androidx.preference.Preference;
|
||||
|
||||
import com.android.settings.core.BasePreferenceController;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.MockitoAnnotations;
|
||||
import org.robolectric.RobolectricTestRunner;
|
||||
import org.robolectric.RuntimeEnvironment;
|
||||
|
||||
@RunWith(RobolectricTestRunner.class)
|
||||
public class AlarmsAndRemindersDetailPreferenceControllerTest {
|
||||
|
||||
@Mock
|
||||
private AppInfoDashboardFragment mFragment;
|
||||
@Mock
|
||||
private Preference mPreference;
|
||||
|
||||
private Context mContext;
|
||||
private AlarmsAndRemindersDetailPreferenceController mController;
|
||||
|
||||
@Before
|
||||
public void setUp() {
|
||||
MockitoAnnotations.initMocks(this);
|
||||
mContext = spy(RuntimeEnvironment.application);
|
||||
mController = spy(new AlarmsAndRemindersDetailPreferenceController(mContext, "test_key"));
|
||||
mController.setPackageName("Package1");
|
||||
mController.setParentFragment(mFragment);
|
||||
final String key = mController.getPreferenceKey();
|
||||
when(mPreference.getKey()).thenReturn(key);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void getAvailabilityStatus_notCandidate_shouldReturnUnavailable() {
|
||||
doReturn(false).when(mController).isCandidate();
|
||||
|
||||
assertThat(mController.getAvailabilityStatus())
|
||||
.isEqualTo(BasePreferenceController.CONDITIONALLY_UNAVAILABLE);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void getAvailabilityStatus_isCandidate_shouldReturnAvailable() {
|
||||
doReturn(true).when(mController).isCandidate();
|
||||
|
||||
assertThat(mController.getAvailabilityStatus())
|
||||
.isEqualTo(BasePreferenceController.AVAILABLE);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void getDetailFragmentClass_shouldReturnAlarmsAndRemindersDetails() {
|
||||
assertThat(mController.getDetailFragmentClass()).isEqualTo(AlarmsAndRemindersDetails.class);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void updateState_shouldSetSummary() {
|
||||
final String summary = "test summary";
|
||||
doReturn(summary).when(mController).getPreferenceSummary();
|
||||
|
||||
mController.updateState(mPreference);
|
||||
|
||||
verify(mPreference).setSummary(summary);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void isCandidate_nullPackageInfo_shouldNotCrash() {
|
||||
mController.isCandidate();
|
||||
// no crash
|
||||
}
|
||||
}
|
Reference in New Issue
Block a user