diff --git a/res/values/strings.xml b/res/values/strings.xml
index 80d7a9a783d..11f4c19803b 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -3169,7 +3169,7 @@
Wallpaper & style
- Colors, app grid
+ Colors, themed icons, app grid
Default
@@ -5179,7 +5179,7 @@
Accessibility settings
- Screen readers, display, interaction controls
+ Screen readers, interaction controls
Vision Settings
@@ -7680,7 +7680,7 @@
Help & feedback
- Help articles, phone & chat, getting started
+ Help articles, phone & chat
@@ -8076,15 +8076,15 @@
Network & internet
-
- mobile
-
- data usage
-
- hotspot
+
+ Mobile, Wi\u2011Fi, hotspot
+
+ Wi\u2011Fi, hotspot
Connected devices
+
+ Bluetooth, pairing
Bluetooth, driving mode, NFC
@@ -10899,7 +10899,7 @@
Sleep after %1$s of inactivity
- Screen timeout, font size
+ Dark theme, font size, brightness
Sleep after 10 minutes of inactivity
diff --git a/res/xml/top_level_settings.xml b/res/xml/top_level_settings.xml
index 6d73ad6654f..1b949e97e26 100644
--- a/res/xml/top_level_settings.xml
+++ b/res/xml/top_level_settings.xml
@@ -35,7 +35,7 @@
android:key="top_level_connected_devices"
android:order="-140"
android:title="@string/connected_devices_dashboard_title"
- android:summary="@string/summary_placeholder"
+ android:summary="@string/connected_devices_dashboard_default_summary"
settings:controller="com.android.settings.connecteddevice.TopLevelConnectedDevicesPreferenceController"/>
summaries = new ArrayList<>();
- if (mWifiPreferenceController.isAvailable()
- && !TextUtils.isEmpty(wifiSummary)) {
- summaries.add(wifiSummary);
+ if (mMobileNetworkPreferenceController.isAvailable()) {
+ return BidiFormatter.getInstance()
+ .unicodeWrap(mContext.getString(R.string.network_dashboard_summary_mobile));
+ } else {
+ return BidiFormatter.getInstance()
+ .unicodeWrap(mContext.getString(R.string.network_dashboard_summary_no_mobile));
}
- if (mMobileNetworkPreferenceController.isAvailable() && !TextUtils.isEmpty(mobileSummary)) {
- summaries.add(mobileSummary);
- }
- if (!TextUtils.isEmpty(dataUsageSummary)) {
- summaries.add(dataUsageSummary);
- }
- if (mTetherPreferenceController.isAvailable()
- && !TextUtils.isEmpty(hotspotSummary)) {
- summaries.add(hotspotSummary);
- }
- return concatSummaries(summaries);
- }
-
- private CharSequence concatSummaries(List summaries) {
- if (summaries.isEmpty()) {
- return mContext.getText(R.string.summary_placeholder);
- }
-
- String summary = summaries.get(0);
- final int summary_size = summaries.size();
- for (int i = 1; i < summary_size; i++) {
- summary = mContext.getString(R.string.join_two_unrelated_items, summary,
- summaries.get(i));
- }
- return summary;
}
}
diff --git a/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java
index 14fe4bd19e6..66f314df30f 100644
--- a/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java
+++ b/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java
@@ -23,16 +23,12 @@ import static com.google.common.truth.Truth.assertThat;
import android.content.Context;
-import com.android.settings.R;
-
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment;
import org.robolectric.annotation.Config;
-import org.robolectric.annotation.Implementation;
-import org.robolectric.annotation.Implements;
@RunWith(RobolectricTestRunner.class)
public class TopLevelConnectedDevicesPreferenceControllerTest {
@@ -56,20 +52,4 @@ public class TopLevelConnectedDevicesPreferenceControllerTest {
public void getAvailabilityStatus_unsupportedWhenSet() {
assertThat(mController.getAvailabilityStatus()).isEqualTo(UNSUPPORTED_ON_DEVICE);
}
-
- @Test
- @Config(shadows = ShadowAdvancedConnectedDeviceController.class)
- public void getSummary_shouldCallAdvancedConnectedDeviceController() {
- assertThat(mController.getSummary())
- .isEqualTo(mContext.getText(R.string.settings_label_launcher));
- }
-
- @Implements(AdvancedConnectedDeviceController.class)
- private static class ShadowAdvancedConnectedDeviceController {
-
- @Implementation
- protected static int getConnectedDevicesSummaryResourceId(Context context) {
- return R.string.settings_label_launcher;
- }
- }
}
diff --git a/tests/robotests/src/com/android/settings/network/TopLevelNetworkEntryPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/network/TopLevelNetworkEntryPreferenceControllerTest.java
index 81092eba162..a2bac8511cf 100644
--- a/tests/robotests/src/com/android/settings/network/TopLevelNetworkEntryPreferenceControllerTest.java
+++ b/tests/robotests/src/com/android/settings/network/TopLevelNetworkEntryPreferenceControllerTest.java
@@ -24,10 +24,11 @@ import static org.mockito.Mockito.when;
import android.content.Context;
import android.os.UserManager;
+import android.text.BidiFormatter;
+import com.android.settings.R;
import com.android.settings.testutils.shadow.ShadowRestrictedLockUtilsInternal;
import com.android.settings.testutils.shadow.ShadowUtils;
-import com.android.settings.wifi.WifiPrimarySwitchPreferenceController;
import org.junit.After;
import org.junit.Before;
@@ -47,11 +48,7 @@ import org.robolectric.util.ReflectionHelpers;
public class TopLevelNetworkEntryPreferenceControllerTest {
@Mock
- private WifiPrimarySwitchPreferenceController mWifiPreferenceController;
- @Mock
- private MobileNetworkPreferenceController mMobileNetworkPreferenceController;
- @Mock
- private TetherPreferenceController mTetherPreferenceController;
+ private MobileNetworkPreferenceController mMobileNetworkPreferenceController;;
private Context mContext;
private TopLevelNetworkEntryPreferenceController mController;
@@ -66,12 +63,8 @@ public class TopLevelNetworkEntryPreferenceControllerTest {
mController = new TopLevelNetworkEntryPreferenceController(mContext, "test_key");
- ReflectionHelpers.setField(mController, "mWifiPreferenceController",
- mWifiPreferenceController);
ReflectionHelpers.setField(mController, "mMobileNetworkPreferenceController",
mMobileNetworkPreferenceController);
- ReflectionHelpers.setField(mController, "mTetherPreferenceController",
- mTetherPreferenceController);
}
@After
@@ -86,21 +79,18 @@ public class TopLevelNetworkEntryPreferenceControllerTest {
}
@Test
- public void getSummary_hasMobileAndHotspot_shouldReturnMobileSummary() {
- when(mWifiPreferenceController.isAvailable()).thenReturn(true);
+ public void getSummary_hasMobile_shouldReturnMobileSummary() {
when(mMobileNetworkPreferenceController.isAvailable()).thenReturn(true);
- when(mTetherPreferenceController.isAvailable()).thenReturn(true);
- assertThat(mController.getSummary())
- .isEqualTo("Wi\u2011Fi, mobile, data usage, hotspot");
+ assertThat(mController.getSummary()).isEqualTo(BidiFormatter.getInstance().unicodeWrap(
+ mContext.getString(R.string.network_dashboard_summary_mobile)));
}
@Test
- public void getSummary_noMobileOrHotspot_shouldReturnSimpleSummary() {
- when(mWifiPreferenceController.isAvailable()).thenReturn(true);
+ public void getSummary_noMobile_shouldReturnNoMobileSummary() {
when(mMobileNetworkPreferenceController.isAvailable()).thenReturn(false);
- when(mTetherPreferenceController.isAvailable()).thenReturn(false);
- assertThat(mController.getSummary()).isEqualTo("Wi\u2011Fi, data usage");
+ assertThat(mController.getSummary()).isEqualTo(BidiFormatter.getInstance().unicodeWrap(
+ mContext.getString(R.string.network_dashboard_summary_no_mobile)));
}
}