diff --git a/res/layout/dialog_firmware_version.xml b/res/layout/dialog_firmware_version.xml new file mode 100644 index 00000000000..e49255f2183 --- /dev/null +++ b/res/layout/dialog_firmware_version.xml @@ -0,0 +1,89 @@ + + + + + + + + + + + + + + + + + + + + + + + diff --git a/res/values/strings.xml b/res/values/strings.xml index c6bc5498143..cd4c63c3ca1 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -2622,6 +2622,8 @@ Android version + + Android Android security patch level diff --git a/src/com/android/settings/DeviceInfoSettings.java b/src/com/android/settings/DeviceInfoSettings.java index c20b5e764c9..3ae5455a48d 100644 --- a/src/com/android/settings/DeviceInfoSettings.java +++ b/src/com/android/settings/DeviceInfoSettings.java @@ -41,6 +41,7 @@ import com.android.settings.deviceinfo.SafetyInfoPreferenceController; import com.android.settings.deviceinfo.SecurityPatchPreferenceController; import com.android.settings.deviceinfo.simstatus.SimStatusDualSimPreferenceController; import com.android.settings.deviceinfo.simstatus.SimStatusPreferenceControllerV2; +import com.android.settings.deviceinfo.firmwareversion.FirmwareVersionPreferenceControllerV2; import com.android.settings.search.BaseSearchIndexProvider; import com.android.settings.search.Indexable; import com.android.settingslib.core.AbstractPreferenceController; @@ -138,7 +139,7 @@ public class DeviceInfoSettings extends DashboardFragment implements Indexable { controllers.add(new ImeiInfoDualSimPreferenceController(context, fragment)); - // Android version + controllers.add(new FirmwareVersionPreferenceControllerV2(context, fragment)); // IP address diff --git a/src/com/android/settings/deviceinfo/FirmwareVersionPreferenceController.java b/src/com/android/settings/deviceinfo/FirmwareVersionPreferenceController.java index fd73ed55847..8c9a2f1a4ee 100644 --- a/src/com/android/settings/deviceinfo/FirmwareVersionPreferenceController.java +++ b/src/com/android/settings/deviceinfo/FirmwareVersionPreferenceController.java @@ -27,13 +27,17 @@ import android.text.TextUtils; import android.util.Log; import com.android.settings.core.PreferenceControllerMixin; +import com.android.settings.deviceinfo.firmwareversion.FirmwareVersionPreferenceControllerV2; import com.android.settingslib.RestrictedLockUtils; import com.android.settingslib.core.AbstractPreferenceController; import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.LifecycleObserver; import com.android.settingslib.core.lifecycle.events.OnResume; - +/** + * deprecated in favor of {@link FirmwareVersionPreferenceControllerV2} + */ +@Deprecated public class FirmwareVersionPreferenceController extends AbstractPreferenceController implements PreferenceControllerMixin, LifecycleObserver, OnResume { diff --git a/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionDialogFragment.java b/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionDialogFragment.java new file mode 100644 index 00000000000..3af21a93f53 --- /dev/null +++ b/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionDialogFragment.java @@ -0,0 +1,59 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.deviceinfo.firmwareversion; + +import android.app.AlertDialog; +import android.app.Dialog; +import android.app.Fragment; +import android.app.FragmentManager; +import android.os.Bundle; +import android.view.LayoutInflater; +import android.view.View; + +import com.android.internal.logging.nano.MetricsProto; +import com.android.settings.R; +import com.android.settings.core.instrumentation.InstrumentedDialogFragment; + +public class FirmwareVersionDialogFragment extends InstrumentedDialogFragment { + + private static final String TAG = "firmwareVersionDialog"; + + public static void show(Fragment host) { + final FragmentManager manager = host.getChildFragmentManager(); + if (manager.findFragmentByTag(TAG) == null) { + final FirmwareVersionDialogFragment dialog = new FirmwareVersionDialogFragment(); + dialog.show(manager, TAG); + } + } + + @Override + public int getMetricsCategory() { + return MetricsProto.MetricsEvent.DIALOG_FIRMWARE_VERSION; + } + + @Override + public Dialog onCreateDialog(Bundle savedInstanceState) { + final AlertDialog.Builder builder = new AlertDialog.Builder(getActivity()) + .setTitle(R.string.firmware_title) + .setPositiveButton(android.R.string.ok, null /* listener */); + + final View view = LayoutInflater.from(getActivity()).inflate( + R.layout.dialog_firmware_version, null /* parent */); + + return builder.setView(view).create(); + } +} diff --git a/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerV2.java b/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerV2.java new file mode 100644 index 00000000000..3ce9ee1cdc6 --- /dev/null +++ b/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerV2.java @@ -0,0 +1,71 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.deviceinfo.firmwareversion; + +import android.app.Fragment; +import android.content.Context; +import android.os.Build; +import android.support.v7.preference.Preference; +import android.support.v7.preference.PreferenceScreen; +import android.text.TextUtils; + +import com.android.settings.core.PreferenceControllerMixin; +import com.android.settingslib.core.AbstractPreferenceController; + +public class FirmwareVersionPreferenceControllerV2 extends AbstractPreferenceController implements + PreferenceControllerMixin { + + private final static String FIRMWARE_VERSION_KEY = "firmware_version"; + + private final Fragment mFragment; + + public FirmwareVersionPreferenceControllerV2(Context context, Fragment fragment) { + super(context); + + mFragment = fragment; + } + + + @Override + public boolean isAvailable() { + return true; + } + + @Override + public void displayPreference(PreferenceScreen screen) { + super.displayPreference(screen); + final Preference pref = screen.findPreference(getPreferenceKey()); + if (pref != null) { + pref.setSummary(Build.VERSION.RELEASE); + } + } + + @Override + public String getPreferenceKey() { + return FIRMWARE_VERSION_KEY; + } + + @Override + public boolean handlePreferenceTreeClick(Preference preference) { + if (!TextUtils.equals(preference.getKey(), getPreferenceKey())) { + return false; + } + + FirmwareVersionDialogFragment.show(mFragment); + return true; + } +} diff --git a/tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerV2Test.java b/tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerV2Test.java new file mode 100644 index 00000000000..5fa8a913708 --- /dev/null +++ b/tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerV2Test.java @@ -0,0 +1,94 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.deviceinfo.firmwareversion; + +import static com.google.common.truth.Truth.assertThat; + +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.never; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +import android.app.Fragment; +import android.app.FragmentManager; +import android.content.Context; +import android.os.Build; +import android.support.v7.preference.Preference; +import android.support.v7.preference.PreferenceScreen; + +import com.android.settings.TestConfig; +import com.android.settings.testutils.SettingsRobolectricTestRunner; + +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Answers; +import org.mockito.Mock; +import org.mockito.MockitoAnnotations; +import org.robolectric.RuntimeEnvironment; +import org.robolectric.annotation.Config; + +@RunWith(SettingsRobolectricTestRunner.class) +@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION) +public class FirmwareVersionPreferenceControllerV2Test { + + @Mock + private Preference mPreference; + @Mock + private PreferenceScreen mScreen; + @Mock + private Fragment mFragment; + + private Context mContext; + private FirmwareVersionPreferenceControllerV2 mController; + + @Before + public void setup() { + MockitoAnnotations.initMocks(this); + mContext = RuntimeEnvironment.application; + mController = new FirmwareVersionPreferenceControllerV2(mContext, mFragment); + when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference); + } + + @Test + public void displayPreference_shouldSetSummaryToBuildNumber() { + mController.displayPreference(mScreen); + + verify(mPreference).setSummary(Build.VERSION.RELEASE); + } + + @Test + public void handlePreferenceTreeClick_samePreferenceKey_shouldStartDialogFragment() { + when(mPreference.getKey()).thenReturn(mController.getPreferenceKey()); + when(mFragment.getChildFragmentManager()).thenReturn( + mock(FragmentManager.class, Answers.RETURNS_DEEP_STUBS)); + + mController.handlePreferenceTreeClick(mPreference); + + verify(mFragment).getChildFragmentManager(); + } + + @Test + public void handlePreferenceTreeClick_unknownPreferenceKey_shouldDoNothingAndReturnFalse() { + when(mPreference.getKey()).thenReturn("foobar"); + + final boolean result = mController.handlePreferenceTreeClick(mPreference); + + assertThat(result).isFalse(); + verify(mFragment, never()).getChildFragmentManager(); + } +}