Extract counting of installed apps into helper class

This CL extracts the code that counts the number of installed apps for a set of users from ManageApplications to a helper class, InstalledAppCounter. The new helper is designed to be unit-testable (PackageManager dependencies are injected via a new PackageManagerWrapper abstraction) and customizable (the set of users for which to count is specified by subclasses). The CL adds a unit test for the InstalledAppCounter as well. Test: make RunSettingsRoboTests Bug: 32692748 Change-Id: Ie7fbd40d9dd998b27f1f9de227b6a187b5c9d315
2016-11-17 21:04:34 +01:00
parent 10dd465969
commit 3d83300deb
9 changed files with 433 additions and 42 deletions
--- a/src/com/android/settings/applications/InstalledAppCounter.java
+++ b/src/com/android/settings/applications/InstalledAppCounter.java
@@ -0,0 +1,52 @@
+/*
+ * Copyright (C) 2016 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the
+ * License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+
+package com.android.settings.applications;
+
+import android.content.Context;
+import android.content.Intent;
+import android.content.pm.ApplicationInfo;
+import android.content.pm.ResolveInfo;
+import android.content.pm.PackageManager;
+import android.os.UserHandle;
+
+import java.util.List;
+
+public abstract class InstalledAppCounter extends AppCounter {
+
+    public InstalledAppCounter(Context context, PackageManagerWrapper packageManager) {
+        super(context, packageManager);
+    }
+
+    @Override
+    protected boolean includeInCount(ApplicationInfo info) {
+        if ((info.flags & ApplicationInfo.FLAG_UPDATED_SYSTEM_APP) != 0) {
+            return true;
+        }
+        if ((info.flags & ApplicationInfo.FLAG_SYSTEM) == 0) {
+            return true;
+        }
+        Intent launchIntent = new Intent(Intent.ACTION_MAIN, null)
+                .addCategory(Intent.CATEGORY_LAUNCHER)
+                .setPackage(info.packageName);
+        int userId = UserHandle.getUserId(info.uid);
+        List<ResolveInfo> intents = mPm.queryIntentActivitiesAsUser(
+                launchIntent,
+                PackageManager.GET_DISABLED_COMPONENTS
+                        | PackageManager.MATCH_DIRECT_BOOT_AWARE
+                        | PackageManager.MATCH_DIRECT_BOOT_UNAWARE,
+                userId);
+        return intents != null && intents.size() != 0;
+    }
+}