Refactor nfc preference controller
- Remove BaseNfcPreferenceController. - NfcPreferenceController inherit from TogglePreferenceController. - AndroidBeamPreferenceController inherit from BasePreferenceController. - Override getIntentFilter in NfcPreferenceController to listen changes. - Add an API (hasAsyncUpdate) into BasePreferenceController to distinguish the setting which is updated asynchronously. Change-Id: I7c9c48ea7f1ad01a02524beabf9d30baa3db891f Fixes: 67997761 Fixes: 74887543 Test: RunSettingsRoboTests
This commit is contained in:
@@ -16,35 +16,118 @@
|
||||
package com.android.settings.nfc;
|
||||
|
||||
import android.content.Context;
|
||||
import android.content.IntentFilter;
|
||||
import android.nfc.NfcAdapter;
|
||||
import android.provider.Settings;
|
||||
|
||||
import androidx.preference.Preference;
|
||||
import androidx.preference.PreferenceScreen;
|
||||
import androidx.preference.SwitchPreference;
|
||||
|
||||
import com.android.settings.core.PreferenceControllerMixin;
|
||||
import com.android.settings.core.TogglePreferenceController;
|
||||
import com.android.settingslib.core.lifecycle.LifecycleObserver;
|
||||
import com.android.settingslib.core.lifecycle.events.OnPause;
|
||||
import com.android.settingslib.core.lifecycle.events.OnResume;
|
||||
|
||||
import java.util.List;
|
||||
|
||||
public class NfcPreferenceController extends BaseNfcPreferenceController {
|
||||
public class NfcPreferenceController extends TogglePreferenceController
|
||||
implements LifecycleObserver, OnResume, OnPause {
|
||||
|
||||
public static final String KEY_TOGGLE_NFC = "toggle_nfc";
|
||||
private final NfcAdapter mNfcAdapter;
|
||||
private NfcEnabler mNfcEnabler;
|
||||
private NfcAirplaneModeObserver mAirplaneModeObserver;
|
||||
|
||||
public NfcPreferenceController(Context context) {
|
||||
super(context);
|
||||
public NfcPreferenceController(Context context, String key) {
|
||||
super(context, key);
|
||||
mNfcAdapter = NfcAdapter.getDefaultAdapter(context);
|
||||
}
|
||||
|
||||
@Override
|
||||
public void displayPreference(PreferenceScreen screen) {
|
||||
super.displayPreference(screen);
|
||||
if (!isAvailable()) {
|
||||
mNfcEnabler = null;
|
||||
return;
|
||||
}
|
||||
|
||||
mNfcEnabler = new NfcEnabler(mContext, (SwitchPreference) mPreference);
|
||||
final SwitchPreference switchPreference =
|
||||
(SwitchPreference) screen.findPreference(getPreferenceKey());
|
||||
|
||||
mNfcEnabler = new NfcEnabler(mContext, switchPreference);
|
||||
|
||||
// Manually set dependencies for NFC when not toggleable.
|
||||
if (!isToggleableInAirplaneMode(mContext)) {
|
||||
mAirplaneModeObserver = new NfcAirplaneModeObserver(mContext,
|
||||
mNfcAdapter, (Preference) switchPreference);
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public String getPreferenceKey() {
|
||||
return KEY_TOGGLE_NFC;
|
||||
public boolean isChecked() {
|
||||
return mNfcAdapter.isEnabled();
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean setChecked(boolean isChecked) {
|
||||
if (isChecked) {
|
||||
mNfcAdapter.enable();
|
||||
} else {
|
||||
mNfcAdapter.disable();
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
@Override
|
||||
@AvailabilityStatus
|
||||
public int getAvailabilityStatus() {
|
||||
return mNfcAdapter != null
|
||||
? AVAILABLE
|
||||
: UNSUPPORTED_ON_DEVICE;
|
||||
}
|
||||
|
||||
@Override
|
||||
public IntentFilter getIntentFilter() {
|
||||
final IntentFilter filter = new IntentFilter();
|
||||
filter.addAction(NfcAdapter.ACTION_ADAPTER_STATE_CHANGED);
|
||||
filter.addAction(NfcAdapter.EXTRA_ADAPTER_STATE);
|
||||
return filter;
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean hasAsyncUpdate() {
|
||||
return true;
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean isSliceable() {
|
||||
return true;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onResume() {
|
||||
if (mAirplaneModeObserver != null) {
|
||||
mAirplaneModeObserver.register();
|
||||
}
|
||||
if (mNfcEnabler != null) {
|
||||
mNfcEnabler.resume();
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onPause() {
|
||||
if (mAirplaneModeObserver != null) {
|
||||
mAirplaneModeObserver.unregister();
|
||||
}
|
||||
if (mNfcEnabler != null) {
|
||||
mNfcEnabler.pause();
|
||||
}
|
||||
}
|
||||
|
||||
public static boolean isToggleableInAirplaneMode(Context context) {
|
||||
final String toggleable = Settings.Global.getString(context.getContentResolver(),
|
||||
Settings.Global.AIRPLANE_MODE_TOGGLEABLE_RADIOS);
|
||||
return toggleable != null && toggleable.contains(Settings.Global.RADIO_NFC);
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user