From 7548f1fa770ac0f847386baeb761f75ee91f037b Mon Sep 17 00:00:00 2001 From: jackqdyulei Date: Tue, 16 May 2017 18:38:12 -0700 Subject: [PATCH] Add screen usage string for battery settings In advanced battery page we still use "Used for" Bug: 38328647 Test: Build & Screenshot Change-Id: Ic194bfed45a76c811c431a13b5554f5bc978bca5 --- res/values/strings.xml | 2 ++ src/com/android/settings/fuelgauge/PowerUsageSummary.java | 2 +- .../android/settings/fuelgauge/PowerUsageSummaryTest.java | 6 +++--- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 8e3fbe270bb..a01b921bc66 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -4686,6 +4686,8 @@ Used for ^1 + + Screen usage ^1 %1$s used by %2$s diff --git a/src/com/android/settings/fuelgauge/PowerUsageSummary.java b/src/com/android/settings/fuelgauge/PowerUsageSummary.java index 0309296bd14..2e75d5f0415 100644 --- a/src/com/android/settings/fuelgauge/PowerUsageSummary.java +++ b/src/com/android/settings/fuelgauge/PowerUsageSummary.java @@ -652,7 +652,7 @@ public class PowerUsageSummary extends PowerUsageBase { final CharSequence timeSequence = Utils.formatElapsedTime(getContext(), usageTimeMs, false); preference.setSummary( - TextUtils.expandTemplate(getText(R.string.battery_used_for), timeSequence)); + TextUtils.expandTemplate(getText(R.string.battery_screen_usage), timeSequence)); } } diff --git a/tests/robotests/src/com/android/settings/fuelgauge/PowerUsageSummaryTest.java b/tests/robotests/src/com/android/settings/fuelgauge/PowerUsageSummaryTest.java index 3d5d5dce6f2..ed94bb28f22 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/PowerUsageSummaryTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/PowerUsageSummaryTest.java @@ -360,10 +360,10 @@ public class PowerUsageSummaryTest { @Test public void testSetUsageSummary_timeMoreThanOneMinute_setSummary() { final long usageTimeMs = 2 * DateUtils.MINUTE_IN_MILLIS; - doReturn(mRealContext.getText(R.string.battery_used_for)).when(mFragment).getText( - R.string.battery_used_for); + doReturn(mRealContext.getText(R.string.battery_screen_usage)).when(mFragment).getText( + R.string.battery_screen_usage); doReturn(mRealContext).when(mFragment).getContext(); - final String expectedSummary = "Used for 2m"; + final String expectedSummary = "Screen usage 2m"; mFragment.setUsageSummary(mPreference, usageTimeMs);