From 9862f8632a3882d528076909bdd62f22af9f59f2 Mon Sep 17 00:00:00 2001 From: Mill Chen Date: Thu, 16 May 2019 17:43:06 +0800 Subject: [PATCH] Revert "Revert "Update dialog background color for dark theme"" This reverts commit 77259dc9bbe7d61c66a674ed0ac77fcc69a55cb0. Previously, using a general attribute to change the background color for alert dialog. It will also impact on the background of other components. To fix it, we used another attribute to change the dialog background. Bug: 132753127 Bug: 132623454 Bug: 129993336 Test: visual Change-Id: I09091ee8fb45238d0ea94760f2fca5c206299a57 --- res/values-night/colors.xml | 2 ++ res/values-night/themes.xml | 1 + res/values/colors.xml | 3 +++ res/values/themes.xml | 1 + .../settings/accessibility/HearingAidDialogFragment.java | 3 ++- 5 files changed, 9 insertions(+), 1 deletion(-) diff --git a/res/values-night/colors.xml b/res/values-night/colors.xml index 4041d0df609..f7612173840 100644 --- a/res/values-night/colors.xml +++ b/res/values-night/colors.xml @@ -22,6 +22,8 @@ @*android:color/material_grey_900 @*android:color/material_grey_900 @*android:color/material_grey_800 + + @*android:color/material_grey_800 @*android:color/material_grey_800 #AECBFA #5F6368 diff --git a/res/values-night/themes.xml b/res/values-night/themes.xml index 2227b889bb3..f47513e7b6f 100644 --- a/res/values-night/themes.xml +++ b/res/values-night/themes.xml @@ -33,6 +33,7 @@ diff --git a/res/values/colors.xml b/res/values/colors.xml index e1c9228f1cb..4a4c896a770 100644 --- a/res/values/colors.xml +++ b/res/values/colors.xml @@ -144,4 +144,7 @@ @android:color/white + + @*android:color/background_device_default_light + \ No newline at end of file diff --git a/res/values/themes.xml b/res/values/themes.xml index d9d1e744015..83169715f39 100644 --- a/res/values/themes.xml +++ b/res/values/themes.xml @@ -121,6 +121,7 @@