From 386071e91dab6c1ab3df00dff049ba5798a1ec4f Mon Sep 17 00:00:00 2001 From: Jason Chang Date: Sat, 7 Sep 2024 13:29:10 +0000 Subject: [PATCH] Fix fingerprint enrollment animation is not in correct position. 1. Change SPFS ring progress bar and lottie animaiton from layout_marginLeft/ layout_marginRight to marginStart/marginEnd for RTL language. 2. Modify SPFS ring progress bar and lottie animaiton dimensioin for RTL language and check three different SFPS projects. Flag: NONE bug-fixing Bug: 338911438 Test: manual build and check UI visually. Change-Id: I88edad459eefbb3c6be337263045cd87685810e9 --- res/layout/sfps_enroll_enrolling.xml | 4 ++-- res/values-ldrtl/dimens.xml | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/res/layout/sfps_enroll_enrolling.xml b/res/layout/sfps_enroll_enrolling.xml index e0f9d1f8454..bd6e69a4175 100644 --- a/res/layout/sfps_enroll_enrolling.xml +++ b/res/layout/sfps_enroll_enrolling.xml @@ -45,7 +45,7 @@ android:id="@+id/illustration_lottie" android:layout_width="@dimen/fingerprint_progress_bar_max_size" android:layout_height="@dimen/fingerprint_progress_bar_max_size" - android:layout_marginRight="@dimen/sfps_lottie_translate_x" + android:layout_marginEnd="@dimen/sfps_lottie_translate_x" android:layout_marginBottom="@dimen/sfps_lottie_translate_y" android:scaleType="centerInside" android:visibility="gone" @@ -66,7 +66,7 @@ android:id="@+id/fingerprint_progress_bar" android:layout_width="match_parent" android:layout_height="match_parent" - android:layout_marginLeft="@dimen/sfps_progress_bar_translate_x" + android:layout_marginStart="@dimen/sfps_progress_bar_translate_x" android:layout_marginTop="@dimen/sfps_progress_bar_translate_y" android:layout_gravity="center" android:minHeight="@dimen/fingerprint_progress_bar_min_size" diff --git a/res/values-ldrtl/dimens.xml b/res/values-ldrtl/dimens.xml index cbe7eb5abdc..f11b2f458a7 100755 --- a/res/values-ldrtl/dimens.xml +++ b/res/values-ldrtl/dimens.xml @@ -23,4 +23,8 @@ 20dp 0dp 20dp + + + 242dp + 10dp