diff --git a/res/xml/connected_devices.xml b/res/xml/connected_devices.xml index 6d25c584b85..75f99886400 100644 --- a/res/xml/connected_devices.xml +++ b/res/xml/connected_devices.xml @@ -48,21 +48,6 @@ android:fragment="com.android.settings.connecteddevice.PreviouslyConnectedDeviceDashboardFragment" settings:allowDividerAbove="true"/> - - - - - - + + + + + android:order="-6"/> + android:order="-4"/> + android:order="-3"/> + android:order="-8"/> diff --git a/src/com/android/settings/connecteddevice/AdvancedConnectedDeviceDashboardFragment.java b/src/com/android/settings/connecteddevice/AdvancedConnectedDeviceDashboardFragment.java index e347c3fc04c..e437b7647a4 100644 --- a/src/com/android/settings/connecteddevice/AdvancedConnectedDeviceDashboardFragment.java +++ b/src/com/android/settings/connecteddevice/AdvancedConnectedDeviceDashboardFragment.java @@ -24,6 +24,7 @@ import com.android.settings.R; import com.android.settings.bluetooth.BluetoothFilesPreferenceController; import com.android.settings.dashboard.DashboardFragment; import com.android.settings.nfc.AndroidBeamPreferenceController; +import com.android.settings.nfc.NfcPreferenceController; import com.android.settings.print.PrintSettingPreferenceController; import com.android.settings.search.BaseSearchIndexProvider; import com.android.settingslib.core.AbstractPreferenceController; @@ -80,10 +81,16 @@ public class AdvancedConnectedDeviceDashboardFragment extends DashboardFragment final PrintSettingPreferenceController printerController = new PrintSettingPreferenceController(context); + final NfcPreferenceController nfcPreferenceController = + new NfcPreferenceController(context); + if (lifecycle != null) { lifecycle.addObserver(beamPreferenceController); lifecycle.addObserver(printerController); + lifecycle.addObserver(nfcPreferenceController); } + + controllers.add(nfcPreferenceController); controllers.add(printerController); return controllers; diff --git a/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragment.java b/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragment.java index 32a51f53878..7582950c182 100644 --- a/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragment.java +++ b/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragment.java @@ -26,11 +26,8 @@ import com.android.settings.dashboard.DashboardFragment; import com.android.settings.dashboard.SummaryLoader; import com.android.settings.nfc.NfcPreferenceController; import com.android.settings.search.BaseSearchIndexProvider; -import com.android.settingslib.core.AbstractPreferenceController; -import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.search.SearchIndexable; -import java.util.ArrayList; import java.util.Arrays; import java.util.List; @@ -64,25 +61,6 @@ public class ConnectedDeviceDashboardFragment extends DashboardFragment { return R.xml.connected_devices; } - @Override - protected List createPreferenceControllers(Context context) { - return buildPreferenceControllers(context, getLifecycle()); - } - - private static List buildPreferenceControllers(Context context, - Lifecycle lifecycle) { - final List controllers = new ArrayList<>(); - final NfcPreferenceController nfcPreferenceController = - new NfcPreferenceController(context); - controllers.add(nfcPreferenceController); - - if (lifecycle != null) { - lifecycle.addObserver(nfcPreferenceController); - } - - return controllers; - } - @Override public void onAttach(Context context) { super.onAttach(context); @@ -140,12 +118,6 @@ public class ConnectedDeviceDashboardFragment extends DashboardFragment { return Arrays.asList(sir); } - @Override - public List createPreferenceControllers(Context - context) { - return buildPreferenceControllers(context, null /* lifecycle */); - } - @Override public List getNonIndexableKeys(Context context) { List keys = super.getNonIndexableKeys(context);