From e18a7140f38d9b9e0fab6163419fa02a2a232c2e Mon Sep 17 00:00:00 2001 From: Ioana Alexandru Date: Thu, 20 Apr 2023 16:05:50 +0000 Subject: [PATCH] Add keywords for AOD setting. Used the WiFi slice for inspiration: ag/6793584 Also added "ambient" to the keywords, since "ambient display" is another phrase used for AOD. Bug: 279029717 Test: manually checked that the setting shows up when searching for "aod" Change-Id: I8a3a4a6635c9724565426b859722242d2bae9e49 --- res/values/strings.xml | 4 ++-- .../settings/display/AlwaysOnDisplaySlice.java | 13 +++++++++++++ .../AmbientDisplayAlwaysOnPreferenceController.java | 3 +-- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 6d0577b53d8..b9d26e68a61 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -7097,8 +7097,8 @@ text size, large print, large font, large text, low vision, make text bigger, font enlarger, font enlargement - - always on display, AOD + + always on ambient display, AOD nfc, tag, reader diff --git a/src/com/android/settings/display/AlwaysOnDisplaySlice.java b/src/com/android/settings/display/AlwaysOnDisplaySlice.java index c66f4edee78..003c6039a22 100644 --- a/src/com/android/settings/display/AlwaysOnDisplaySlice.java +++ b/src/com/android/settings/display/AlwaysOnDisplaySlice.java @@ -28,6 +28,7 @@ import android.hardware.display.AmbientDisplayConfiguration; import android.net.Uri; import android.os.UserHandle; import android.provider.Settings; +import android.text.TextUtils; import androidx.slice.Slice; import androidx.slice.builders.ListBuilder; @@ -40,6 +41,10 @@ import com.android.settings.overlay.FeatureFactory; import com.android.settings.slices.CustomSliceRegistry; import com.android.settings.slices.CustomSliceable; +import java.util.Arrays; +import java.util.Set; +import java.util.stream.Collectors; + /** * Custom {@link Slice} for Always on Display. *

@@ -75,6 +80,7 @@ public class AlwaysOnDisplaySlice implements CustomSliceable { return new ListBuilder(mContext, CustomSliceRegistry.ALWAYS_ON_SLICE_URI, ListBuilder.INFINITY) .setAccentColor(color) + .setKeywords(getKeywords()) .addRow(new ListBuilder.RowBuilder() .setTitle(mContext.getText(R.string.doze_always_on_title)) .setSubtitle(mContext.getText(R.string.doze_always_on_summary)) @@ -84,6 +90,13 @@ public class AlwaysOnDisplaySlice implements CustomSliceable { .build(); } + private Set getKeywords() { + final String keywords = mContext.getString(R.string.keywords_always_show_time_info); + return Arrays.stream(TextUtils.split(keywords, ",")) + .map(String::trim) + .collect(Collectors.toSet()); + } + @Override public Uri getUri() { return CustomSliceRegistry.ALWAYS_ON_SLICE_URI; diff --git a/src/com/android/settings/display/AmbientDisplayAlwaysOnPreferenceController.java b/src/com/android/settings/display/AmbientDisplayAlwaysOnPreferenceController.java index e0e25dfc34f..5d95ddbfeb8 100644 --- a/src/com/android/settings/display/AmbientDisplayAlwaysOnPreferenceController.java +++ b/src/com/android/settings/display/AmbientDisplayAlwaysOnPreferenceController.java @@ -22,7 +22,6 @@ import android.os.PowerManager; import android.os.SystemProperties; import android.os.UserHandle; import android.provider.Settings; -import android.text.TextUtils; import androidx.preference.Preference; @@ -59,7 +58,7 @@ public class AmbientDisplayAlwaysOnPreferenceController extends TogglePreference @Override public boolean isSliceable() { - return TextUtils.equals(getPreferenceKey(), "ambient_display_always_on"); + return true; } @Override