From 35fba3eeafe47ccd900b3e18b6b64a16ad677462 Mon Sep 17 00:00:00 2001 From: John Spurlock Date: Fri, 10 Apr 2015 08:11:12 -0400 Subject: [PATCH] Settings: New zen option to allow repeat callers. Bug: 20064962 Change-Id: Icc65da146503386c057d7f78d6610f83f56d1a92 --- res/values/strings.xml | 9 ++++++ res/xml/zen_mode_priority_settings.xml | 8 ++++++ .../notification/ZenModePrioritySettings.java | 28 +++++++++++++++---- .../notification/ZenModeSettings.java | 3 +- 4 files changed, 42 insertions(+), 6 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 940f6bf99f4..e300d425b72 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -5915,6 +5915,15 @@ Events + + Selected callers + + + Repeat callers + + + If the same person calls a second time within a %d minute period, allow it + Automatically turn on diff --git a/res/xml/zen_mode_priority_settings.xml b/res/xml/zen_mode_priority_settings.xml index 6cdbe95c0de..5b1dbf8e5fa 100644 --- a/res/xml/zen_mode_priority_settings.xml +++ b/res/xml/zen_mode_priority_settings.xml @@ -67,4 +67,12 @@ android:title="@string/zen_mode_from" android:persistent="false" /> + + + diff --git a/src/com/android/settings/notification/ZenModePrioritySettings.java b/src/com/android/settings/notification/ZenModePrioritySettings.java index af74a46fc37..89e9ea384a6 100644 --- a/src/com/android/settings/notification/ZenModePrioritySettings.java +++ b/src/com/android/settings/notification/ZenModePrioritySettings.java @@ -35,6 +35,7 @@ public class ZenModePrioritySettings extends ZenModeSettingsBase implements Inde private static final String KEY_MESSAGES = "messages"; private static final String KEY_CALLS = "calls"; private static final String KEY_STARRED = "starred"; + private static final String KEY_REPEAT_CALLERS = "repeat_callers"; private boolean mDisableListeners; private SwitchPreference mReminders; @@ -42,6 +43,7 @@ public class ZenModePrioritySettings extends ZenModeSettingsBase implements Inde private SwitchPreference mMessages; private SwitchPreference mCalls; private DropDownPreference mStarred; + private SwitchPreference mRepeatCallers; @Override public void onCreate(Bundle savedInstanceState) { @@ -123,6 +125,23 @@ public class ZenModePrioritySettings extends ZenModeSettingsBase implements Inde } }); + mRepeatCallers = (SwitchPreference) root.findPreference(KEY_REPEAT_CALLERS); + mRepeatCallers.setSummary(mContext.getString(R.string.zen_mode_repeat_callers_summary, + mContext.getResources().getInteger(com.android.internal.R.integer + .config_zen_repeat_callers_threshold))); + mRepeatCallers.setOnPreferenceChangeListener(new OnPreferenceChangeListener() { + @Override + public boolean onPreferenceChange(Preference preference, Object newValue) { + if (mDisableListeners) return true; + final boolean val = (Boolean) newValue; + if (val == mConfig.allowRepeatCallers) return true; + if (DEBUG) Log.d(TAG, "onPrefChange allowRepeatCallers=" + val); + final ZenModeConfig newConfig = mConfig.copy(); + newConfig.allowRepeatCallers = val; + return setZenModeConfig(newConfig); + } + }); + updateControls(); } @@ -143,9 +162,12 @@ public class ZenModePrioritySettings extends ZenModeSettingsBase implements Inde } mMessages.setChecked(mConfig.allowMessages); mStarred.setSelectedValue(mConfig.allowFrom); + mStarred.setEnabled(mConfig.allowCalls || mConfig.allowMessages); mReminders.setChecked(mConfig.allowReminders); mEvents.setChecked(mConfig.allowEvents); - updateStarredEnabled(); + mRepeatCallers.setChecked(mConfig.allowRepeatCallers); + mRepeatCallers.setEnabled(!mConfig.allowCalls + || mConfig.allowFrom != ZenModeConfig.SOURCE_ANYONE); mDisableListeners = false; } @@ -154,8 +176,4 @@ public class ZenModePrioritySettings extends ZenModeSettingsBase implements Inde return MetricsLogger.NOTIFICATION_ZEN_MODE_PRIORITY; } - private void updateStarredEnabled() { - mStarred.setEnabled(mConfig.allowCalls || mConfig.allowMessages); - } - } diff --git a/src/com/android/settings/notification/ZenModeSettings.java b/src/com/android/settings/notification/ZenModeSettings.java index 88ecef5939e..24774cb69f8 100644 --- a/src/com/android/settings/notification/ZenModeSettings.java +++ b/src/com/android/settings/notification/ZenModeSettings.java @@ -159,10 +159,11 @@ public class ZenModeSettings extends ZenModeSettingsBase } private void updatePrioritySettingsSummary() { + final boolean callers = mConfig.allowCalls || mConfig.allowRepeatCallers; String s = getResources().getString(R.string.zen_mode_alarms); s = appendLowercase(s, mConfig.allowReminders, R.string.zen_mode_reminders); s = appendLowercase(s, mConfig.allowEvents, R.string.zen_mode_events); - s = appendLowercase(s, mConfig.allowCalls, R.string.zen_mode_calls); + s = appendLowercase(s, callers, R.string.zen_mode_selected_callers); s = appendLowercase(s, mConfig.allowMessages, R.string.zen_mode_messages); mPrioritySettings.setSummary(s); }