PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "[Settings] Request focus in Add network dialog"

Browse Source 
This reverts commit 49d314f8c3.

Reason for revert: Revert for proper fix in pi-dev branch. Solution in 
 http://ag/3714337 is proper fix to make all case in wifi dialog can get focus.

Change-Id: I99035a4c437ea6c033e3ba6a83e39967c236d973
This commit is contained in:
Yuchen Chang
2018-03-13 05:26:47 +00:00
parent 49d314f8c3
commit 35c14a2ac3
2 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/com/android/settings/wifi/WifiConfigController.java
View File

@@ -215,7 +215,6 @@ public class WifiConfigController implements TextWatcher,
mSsidView = (TextView) mView.findViewById(R.id.ssid); mSsidView = (TextView) mView.findViewById(R.id.ssid);
mSsidView.addTextChangedListener(this); mSsidView.addTextChangedListener(this);
mSsidView.requestFocus();
mSecuritySpinner = ((Spinner) mView.findViewById(R.id.security)); mSecuritySpinner = ((Spinner) mView.findViewById(R.id.security));
mSecuritySpinner.setOnItemSelectedListener(this); mSecuritySpinner.setOnItemSelectedListener(this);
mView.findViewById(R.id.type).setVisibility(View.VISIBLE); mView.findViewById(R.id.type).setVisibility(View.VISIBLE);

9
tests/robotests/src/com/android/settings/wifi/WifiConfigControllerTest.java
View File

@@ -210,15 +210,6 @@ public class WifiConfigControllerTest {
assertThat(mView.findViewById(R.id.eap).getVisibility()).isEqualTo(View.GONE); assertThat(mView.findViewById(R.id.eap).getVisibility()).isEqualTo(View.GONE);
} }
@Test
public void ssidGetFocus_addNewNetwork_shouldReturnTrue() {
mController = new TestWifiConfigController(mConfigUiBase, mView, null /* accessPoint */,
WifiConfigUiBase.MODE_CONNECT);
final TextView ssid = mView.findViewById(R.id.ssid);
// Verify ssid text get focus when add new network (accesspoint is null)
assertThat(ssid.isFocused()).isTrue();
}
public class TestWifiConfigController extends WifiConfigController { public class TestWifiConfigController extends WifiConfigController {
private TestWifiConfigController( private TestWifiConfigController(