From 3587914cefffadb294d501955c40e36e015b8e73 Mon Sep 17 00:00:00 2001 From: Phil Weaver Date: Fri, 15 Jul 2016 12:54:45 -0700 Subject: [PATCH] Fix return when virtual keyboard setting changes. The OnPreferenceChangeListener for the preference to show the virtual keyboard was returning false, indicating that the new preference was not to be persisted, even though it was persisting the setting. That caused the accessibility framework not to be informed of the new value, which led TalkBack to speak the old value rather than the new one. Bug: 30140972 Change-Id: I02b7dc1db52cb7646650e6f2e49a1e15c2233897 --- .../android/settings/inputmethod/PhysicalKeyboardFragment.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/android/settings/inputmethod/PhysicalKeyboardFragment.java b/src/com/android/settings/inputmethod/PhysicalKeyboardFragment.java index 84223b7a8a4..bb68dd8ca72 100644 --- a/src/com/android/settings/inputmethod/PhysicalKeyboardFragment.java +++ b/src/com/android/settings/inputmethod/PhysicalKeyboardFragment.java @@ -266,7 +266,7 @@ public final class PhysicalKeyboardFragment extends SettingsPreferenceFragment @Override public boolean onPreferenceChange(Preference preference, Object newValue) { mSettings.setShowImeWithHardKeyboard((Boolean) newValue); - return false; + return true; } };